delta/libgit2.git/src/path.h, branch ethomson/proxy

path: export the dotgit-checking functions

2018-10-15T11:54:17+00:00

These checks are preformed by libgit2 on checkout, but they're also useful for
performing checks in applications which do not involve checkout.

Expose them under `sys/` as it's still fairly in the weeds even for this
library.

path: unify `git_path_is_*` APIs

2018-06-01T10:49:09+00:00

Right now, there's quite a lot of different function calls to determine
whether a path component matches a specific name after normalization
from the filesystem. We have a function for each of {gitattributes,
gitmodules, gitignore} multiplicated with {generic, NTFS, HFS} checks.
In the long time, this is unmaintainable in case there are e.g. new
filesystems with specific semantics, blowing up the number of functions
we need to implement.

Replace all functions with a simple `git_path_is_gitfile` function,
which accepts an enum pointing out the filename that is to be checked
against as well as the filesystem normalizations to check for. This
greatly simplifies implementation at the expense of the caller having to
invoke a somewhat longer function call.

path: reject .gitmodules as a symlink

2018-05-23T06:47:08+00:00

Any part of the library which asks the question can pass in the mode to have it
checked against `.gitmodules` being a symlink.

This is particularly relevant for adding entries to the index from the worktree
and for checking out files.

path: accept the name length as a parameter

2018-05-22T13:27:29+00:00

We may take in names from the middle of a string so we want the caller to let us
know how long the path component is that we should be checking.

path: expose dotgit detection functions per filesystem

2018-05-22T11:58:24+00:00

These will be used by the checkout code to detect them for the particular
filesystem they're on.

path: hide the dotgit file functions

2018-05-18T13:16:53+00:00

These can't go into the public API yet as we don't want to introduce API or ABI
changes in a security release.

path: expose `git_path_is_dirsep`

2017-10-09T09:19:41+00:00

This function has previously been implemented in Windows-specific path
handling code as `path__is_dirsep`. As we will need this functionality
in other parts, extract the logic into "path.h" alongside with a
non-Windows implementation.

path: expose `git_path_is_absolute`

2017-10-09T09:19:41+00:00

This function has previously been implemented in Windows-specific path
handling code as `path__is_absolute`. As we will need this functionality
in other parts, extract the logic into "path.h" alongside with a
non-Windows implementation.

Make sure to always include "common.h" first

2017-07-03T08:51:48+00:00

Next to including several files, our "common.h" header also declares
various macros which are then used throughout the project. As such, we
have to make sure to always include this file first in all
implementation files. Otherwise, we might encounter problems or even
silent behavioural differences due to macros or defines not being
defined as they should be. So in fact, our header and implementation
files should make sure to always include "common.h" first.

This commit does so by establishing a common include pattern. Header
files inside of "src" will now always include "common.h" as its first
other file, separated by a newline from all the other includes to make
it stand out as special. There are two cases for the implementation
files. If they do have a matching header file, they will always include
this one first, leading to "common.h" being transitively included as
first file. If they do not have a matching header file, they instead
include "common.h" as first file themselves.

This fixes the outlined problems and will become our standard practice
for header and source files inside of the "src/" from now on.

Patch parsing from patch files

2016-05-26T16:36:11+00:00