delta/libgit2.git/src/fetch.h, branch users/ethomson/cmake2

Make sure to always include "common.h" first

2017-07-03T08:51:48+00:00

Next to including several files, our "common.h" header also declares
various macros which are then used throughout the project. As such, we
have to make sure to always include this file first in all
implementation files. Otherwise, we might encounter problems or even
silent behavioural differences due to macros or defines not being
defined as they should be. So in fact, our header and implementation
files should make sure to always include "common.h" first.

This commit does so by establishing a common include pattern. Header
files inside of "src" will now always include "common.h" as its first
other file, separated by a newline from all the other includes to make
it stand out as special. There are two cases for the implementation
files. If they do have a matching header file, they will always include
this one first, leading to "common.h" being transitively included as
first file. If they do not have a matching header file, they instead
include "common.h" as first file themselves.

This fixes the outlined problems and will become our standard practice
for header and source files inside of the "src/" from now on.

Fix missing include for header files

2017-07-03T08:51:47+00:00

Some of our header files are not included at all by any of their
implementing counter-parts. Including them inside of these files leads
to some compile errors mostly due to unknown types because of missing
includes. But there's also one case where a declared function does not
match the implementation's prototype.

Fix all these errors by fixing up the prototype and adding missing
includes. This is preparatory work for fixing up missing includes in the
implementation files.

Fix #3093 - remove declaration of unused function git_fetch__download_pack

2015-06-30T20:48:47+00:00

Function was added in commit 2c982daa2eec64b80c7940bfe1142295bd72edd8 on October 5, 2011,
and removed in commit 41fb1ca0ec51ad1d2a14b911aab3215e42965d1b on October 29, 2012.
Given the length of time it's gone unused, it's safe to remove now.

remote: move the tagopt setting to the fetch options

2015-05-13T07:46:36+00:00

This is another option which we should not be keeping in the remote, but
is specific to each particular operation.

Remove the callbacks struct from the remote

2015-05-13T07:46:35+00:00

Having the setting be different from calling its actions was not a great
idea and made for the sake of the wrong convenience.

Instead of that, accept either fetch options, push options or the
callbacks when dealing with the remote. The fetch options are currently
only the callbacks, but more options will be moved from setters and
getters on the remote to the options.

This does mean passing the same struct along the different functions but
the typical use-case will only call git_remote_fetch() or
git_remote_push() and so won't notice much difference.

Don't redefine the same callback types, their signatures may change

2014-04-21T09:28:49+00:00

remote: put the _download() callback with the others

2013-10-02T04:41:42+00:00

The text progress and update_tips callbacks are already part of the
struct, which was meant to unify the callback setup, but the download
one was left out.

update copyrights

2013-01-08T23:31:27+00:00

Remove 'bytes' param from git_remote_download

2012-10-24T21:07:07+00:00

Network progress: rename things

2012-10-24T20:29:14+00:00

git_indexer_stats and friends -> git_transfer_progress*

Also made git_transfer_progress members more sanely
named.