delta/libgit2.git/src/diff_parse.c, branch v0.26.2 github.com: libgit2/libgit2.git diff_parse: free object instead of its pointer 2017-04-25T07:51:49+00:00 Patrick Steinhardt ps@pks.im 2017-04-25T07:48:59+00:00 1cb30b1bb45645a2f01ddc855a8644079215f931 In e7330016a (diff_parse: check return value of `git_diff_init_options`, 2017-03-20), we've introduced an error check whether we're able to correctly initialize the diff options. This simple commit actually introduced a segfault in that we now try to free the pointer to the allocated diff in an error case, instead of the allocated diff itself. This commit fixes the issue. 
In e7330016a (diff_parse: check return value of `git_diff_init_options`,
2017-03-20), we've introduced an error check whether we're able to
correctly initialize the diff options. This simple commit actually
introduced a segfault in that we now try to free the pointer to the
allocated diff in an error case, instead of the allocated diff itself.
This commit fixes the issue.
diff_parse: check return value of `git_diff_init_options` 2017-03-21T14:48:16+00:00 Patrick Steinhardt ps@pks.im 2017-03-20T11:38:28+00:00 e7330016af5603021e9521c836b266295a1f2416 






diff_parse: correctly set options for parsed diffs
2017-03-14T12:09:35+00:00

Patrick Steinhardt
ps@pks.im

2017-03-14T10:01:19+00:00

c0eba379d18c6f7979d09c672b48feeaca69dfbd

The function `diff_parsed_alloc` allocates and initializes a
`git_diff_parsed` structure. This structure also contains diff options.
While we initialize its flags, we fail to do a real initialization of
its values. This bites us when we want to actually use the generated
diff as we do not se the option's version field, which is required to
operate correctly.

Fix the issue by executing `git_diff_init_options` on the embedded
struct.





The function `diff_parsed_alloc` allocates and initializes a
`git_diff_parsed` structure. This structure also contains diff options.
While we initialize its flags, we fail to do a real initialization of
its values. This bites us when we want to actually use the generated
diff as we do not se the option's version field, which is required to
operate correctly.

Fix the issue by executing `git_diff_init_options` on the embedded
struct.







Teach `git_patch_from_diff` about parsed diffs
2016-08-24T14:08:57+00:00

Edward Thomson
ethomson@github.com

2016-08-24T04:38:39+00:00

b859faa61ce3f1fda5c29ac1e72a3d58fee2ede6

Ensure that `git_patch_from_diff` can return the patch for parsed diffs,
not just generate a patch for a generated diff.





Ensure that `git_patch_from_diff` can return the patch for parsed diffs,
not just generate a patch for a generated diff.







introduce `git_diff_from_buffer` to parse diffs
2016-05-26T18:01:09+00:00

Edward Thomson
ethomson@github.com

2016-04-25T04:35:48+00:00

7166bb16659790ae2b398e1e95c752f784f6f1d3

Parse diff files into a `git_diff` structure.





Parse diff files into a `git_diff` structure.