delta/libgit2.git/src/config.c, branch editorconfig

config: pass repository when opening config files

2017-10-09T09:19:42+00:00

Our current configuration logic is completely oblivious of any
repository, but only cares for actual file paths. Unfortunately, we are
forced to break this assumption by the introduction of conditional
includes, which are evaluated in the context of a repository. Right now,
only one conditional exists with "gitdir:" -- it will only include the
configuration if the current repository's git directory matches the
value passed to "gitdir:".

To support these conditionals, we have to break our API and make the
repository available when opening a configuration file. This commit
extends the `open` call of configuration backends to include another
repository and adjusts existing code to have it available. This includes
the user-visible functions `git_config_add_file_ondisk` and
`git_config_add_backend`.

Make sure to always include "common.h" first

2017-07-03T08:51:48+00:00

Next to including several files, our "common.h" header also declares
various macros which are then used throughout the project. As such, we
have to make sure to always include this file first in all
implementation files. Otherwise, we might encounter problems or even
silent behavioural differences due to macros or defines not being
defined as they should be. So in fact, our header and implementation
files should make sure to always include "common.h" first.

This commit does so by establishing a common include pattern. Header
files inside of "src" will now always include "common.h" as its first
other file, separated by a newline from all the other includes to make
it stand out as special. There are two cases for the implementation
files. If they do have a matching header file, they will always include
this one first, leading to "common.h" being transitively included as
first file. If they do not have a matching header file, they instead
include "common.h" as first file themselves.

This fixes the outlined problems and will become our standard practice
for header and source files inside of the "src/" from now on.

Merge pull request #4179 from libgit2/ethomson/expand_tilde

2017-05-20T15:18:07+00:00

Introduce home directory expansion function for config files, attribute files

config: skip r/o backends when writing

2017-04-26T07:35:11+00:00

Configuration backends have a readonly-flag which is currently used to
distinguish configuration snapshots. But somewhat unexpectedly, we do
not use the flag to prevent writing to a readonly backend but happily
proceed to do so.

This commit modifies logic to also honor the readonly flag for
configuration setters. We will now traverse through all backends and
pick the first one which is not marked as read-only whenever we want to
write new configuration.

config: expand paths with `git_sysdir_expand...`

2017-03-23T12:12:39+00:00

giterr_set: consistent error messages

2016-12-29T12:26:03+00:00

Error messages should be sentence fragments, and therefore:

1. Should not begin with a capital letter,
2. Should not conclude with punctuation, and
3. Should not end a sentence and begin a new one

Make sure we use the `C` locale for `regcomp` on macOS.

2016-10-06T11:15:31+00:00

config: add a ProgramData level

2015-10-21T13:11:18+00:00

This is where portable git stores the global configuration which we can
use to adhere to it even though git isn't quite installed on the system.

Fix build warning: implicit declaration of function ‘git_transaction_config_new’

2015-08-17T19:18:47+00:00

config: perform unlocking via git_transaction

2015-08-12T02:09:38+00:00

This makes the API for commiting or discarding changes the same as for
references.