delta/libgit2.git, branch rb/diff-update-index-stat-cache

Fix remaining init_options inconsistencies

2014-04-30T18:16:31+00:00

There were a couple of "init_opts()" functions a few more cases
of structure initialization that I somehow missed.

Make init_options fns use unsigned ints and macro

2014-04-30T17:57:42+00:00

Use an unsigned int for the version and add a helper macro so the
code is simplified (and so the error message is a common string).

Remove trace / add git_diff_perfdata struct + api

2014-04-29T22:05:58+00:00

Get rid of redundant git_diff_options_init fn

2014-04-29T21:30:15+00:00

Since git_diff_init_options was introduced, remove this old fn.

Add payloads, bitmaps to trace API

2014-04-29T18:29:49+00:00

This is a proposed adjustment to the trace APIs.  This makes the
trace levels into a bitmask so that they can be selectively enabled
and adds a callback-level payload, plus a message-level payload.

This makes it easier for me to a GIT_TRACE_PERF callbacks that
are simply bypassed if the PERF level is not set.

Don't use trace if GIT_TRACE not defined

2014-04-28T23:47:39+00:00

Add GIT_STATUS_OPT_UPDATE_INDEX and use trace API

2014-04-28T23:39:53+00:00

This adds an option to refresh the stat cache while generating
status.  It also rips out the GIT_PERF stuff I had an makes use
of the trace API to keep statistics about what happens during diff.

Add diff option to update index stat cache

2014-04-28T21:50:49+00:00

When diff is scanning the working directory, if it finds a file
where it is not sure if the index entry matches the working dir,
it will recalculate the OID (which is pretty expensive).  This
adds a new flag to diff so that if the OID calculation finds that
the file actually has not changed (i.e. just the modified time was
altered or such), then it will refresh the stat cache in the index
so that future calls to diff will not have to check the oid again.

Lay groundwork for updating stat cache in diff

2014-04-28T21:50:49+00:00

This reorganized the diff OID calculation to make it easier to
correctly update the stat cache during a diff once the flags to
do so are enabled.

This includes marking the path of a git_index_entry as const so
we can make a "fake" git_index_entry with a "const char *" path
and not get warnings.  I was a little surprised at how unobtrusive
this change was, but I think it's probably a good thing.

Skip diff oid calc when size definitely changed

2014-04-28T21:50:49+00:00

When we think the stat cache in the index seems valid and the size
or mode of a file has definitely changed, then don't bother trying
to recalculate the OID of the workdir bits to confirm that it is
modified - just accept that it is modified.

This can result in files that show as modified with no actual diff,
but the behavior actually appears to match Git on the command line.

This also includes a minor optimization to not perform a submodule
lookup on the ".git" directory itself.