<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git, branch ethomson/callback_names</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>trace: suffix the callbacks with `_cb`</title>
<updated>2019-06-10T10:37:00+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-08T22:16:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=178df697e3650972a70c8b812c7a1222eecaffb7'/>
<id>178df697e3650972a70c8b812c7a1222eecaffb7</id>
<content type='text'>
The trace logging callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The trace logging callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</pre>
</div>
</content>
</entry>
<entry>
<title>credentials: suffix the callbacks with `_cb`</title>
<updated>2019-06-10T10:37:00+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-08T22:14:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=810cefd93fce0eaca7d1dc09d366145be5214e76'/>
<id>810cefd93fce0eaca7d1dc09d366145be5214e76</id>
<content type='text'>
The credential callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The credential callbacks should match the other callback naming
conventions, using the `_cb` suffix instead of a `_callback` suffix.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5095 from pks-t/pks/ignore-escaped-trailing-space</title>
<updated>2019-06-06T13:48:30+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-06T13:48:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=e50d138e898dd034161663873f75716086266f86'/>
<id>e50d138e898dd034161663873f75716086266f86</id>
<content type='text'>
ignore: handle escaped trailing whitespace</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ignore: handle escaped trailing whitespace</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5074 from libgit2/ethomson/ignore_leading_slash</title>
<updated>2019-06-06T13:47:43+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-06T13:47:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4de6eb5b8ba559c1f18a6e7631d7800e294849c8'/>
<id>4de6eb5b8ba559c1f18a6e7631d7800e294849c8</id>
<content type='text'>
Ignore: only treat one leading slash as a root identifier</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ignore: only treat one leading slash as a root identifier</pre>
</div>
</content>
</entry>
<entry>
<title>ignore: handle escaped trailing whitespace</title>
<updated>2019-06-06T12:44:43+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2019-06-06T12:11:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=d81e7866aba52625aa3100764d77c73adba58c8e'/>
<id>d81e7866aba52625aa3100764d77c73adba58c8e</id>
<content type='text'>
The gitignore's pattern format specifies that "Trailing spaces
are ignored unless they are quoted with backslash ("\")". We do
not honor this currently and will treat a pattern "foo\ " as if
it was "foo\" only and a pattern "foo\ \ " as "foo\ \".

Fix our code to handle those special cases and add tests to avoid
regressions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The gitignore's pattern format specifies that "Trailing spaces
are ignored unless they are quoted with backslash ("\")". We do
not honor this currently and will treat a pattern "foo\ " as if
it was "foo\" only and a pattern "foo\ \ " as "foo\ \".

Fix our code to handle those special cases and add tests to avoid
regressions.
</pre>
</div>
</content>
</entry>
<entry>
<title>attr_file: refactor stripping of trailing spaces</title>
<updated>2019-06-06T12:15:36+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2019-06-06T12:02:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=b6967c393aaa9bc8fcb1f248f94a4deb897248cb'/>
<id>b6967c393aaa9bc8fcb1f248f94a4deb897248cb</id>
<content type='text'>
The stripping of trailing spaces currently happens as part of
`git_attr_fnmatch__parse`. As we aren't currently parsing
trailing whitespaces correct in case they're escaped, we'll have
to change that code, though. To make actual behavioural change
easier to review, refactor the code up-front by pulling it out
into its own function that is expected to retain the exact same
functionality as before. Like this, the fix will be trivial to
apply.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The stripping of trailing spaces currently happens as part of
`git_attr_fnmatch__parse`. As we aren't currently parsing
trailing whitespaces correct in case they're escaped, we'll have
to change that code, though. To make actual behavioural change
easier to review, refactor the code up-front by pulling it out
into its own function that is expected to retain the exact same
functionality as before. Like this, the fix will be trivial to
apply.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5094 from libgit2/ethomson/auth_failure</title>
<updated>2019-06-05T19:02:33+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-05T19:02:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=b1795e0da2c5c1f9429fedd2fa0b679ccca0f586'/>
<id>b1795e0da2c5c1f9429fedd2fa0b679ccca0f586</id>
<content type='text'>
online tests: use gitlab for auth failures</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
online tests: use gitlab for auth failures</pre>
</div>
</content>
</entry>
<entry>
<title>online tests: use gitlab for auth failures</title>
<updated>2019-06-05T18:19:14+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-05T18:19:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=e66a4eb37cf3d8c369e662c60fdb0b3cfc459d8e'/>
<id>e66a4eb37cf3d8c369e662c60fdb0b3cfc459d8e</id>
<content type='text'>
GitHub recently changed their behavior from returning 401s for private
or nonexistent repositories on a clone to returning 404s.  For our tests
that require an auth failure (and 401), move to GitLab to request a
missing repository.  This lets us continue to test our auth failure
case, at least until they decide to mimic that decision.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
GitHub recently changed their behavior from returning 401s for private
or nonexistent repositories on a clone to returning 404s.  For our tests
that require an auth failure (and 401), move to GitLab to request a
missing repository.  This lets us continue to test our auth failure
case, at least until they decide to mimic that decision.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #5076 from libgit2/ethomson/ignore_spaces</title>
<updated>2019-06-05T17:04:25+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-06-05T17:04:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=e2d4f09da1a9ae08b8942e8d4e20d831aab4ec7b'/>
<id>e2d4f09da1a9ae08b8942e8d4e20d831aab4ec7b</id>
<content type='text'>
Ignore files: don't ignore whitespace</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Ignore files: don't ignore whitespace</pre>
</div>
</content>
</entry>
<entry>
<title>attr: ensure regular attr files can have whitespace</title>
<updated>2019-05-24T14:16:43+00:00</updated>
<author>
<name>Edward Thomson</name>
<email>ethomson@edwardthomson.com</email>
</author>
<published>2019-05-19T14:34:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/libgit2.git/commit/?id=4bcebe2c92d52739e2ea7a92abb26df32ffc2423'/>
<id>4bcebe2c92d52739e2ea7a92abb26df32ffc2423</id>
<content type='text'>
Unlike ignore files, gitattribute files can have flexible whitespace at
the beginning of the line.  Ensure that by adding new ignore rules that
we have not impeded correct parsing of attribute files.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Unlike ignore files, gitattribute files can have flexible whitespace at
the beginning of the line.  Ensure that by adding new ignore rules that
we have not impeded correct parsing of attribute files.
</pre>
</div>
</content>
</entry>
</feed>
