From 3bcc92cf59cf9bd20d54f13d3a5f0fe51d029e81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C5=93ur?= Date: Thu, 2 Mar 2023 13:59:32 +0800 Subject: Fix the value is never actually read from 'argument' in evhttp_parse_query_impl() Although the value stored to 'argument' is used in the enclosing expression, the value is never actually read from 'argument' --- http.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/http.c b/http.c index aeeab4ac..43879f39 100644 --- a/http.c +++ b/http.c @@ -3555,7 +3555,6 @@ evhttp_parse_query_impl(const char *str, struct evkeyvalq *headers, int is_whole_uri, unsigned flags) { char *line=NULL; - char *argument; char *p; const char *query_part; int result = -1; @@ -3583,13 +3582,12 @@ evhttp_parse_query_impl(const char *str, struct evkeyvalq *headers, goto error; } - p = argument = line; + p = line; while (p != NULL && *p != '\0') { char *key, *value, *decoded_value; int err; - argument = strsep(&p, "&"); - value = argument; + value = strsep(&p, "&"); key = strsep(&value, "="); if (flags & EVHTTP_URI_QUERY_NONCONFORMANT) { if (value == NULL) -- cgit v1.2.1