delta/libevdev.git/libevdev/libevdev.c, branch libevdev-1.8.0

Initialize the slots correctly when enabling ABS_MT_SLOT

2019-06-17T23:31:41+00:00

Previously, enabling or disabling ABS_MT_SLOT would not change the actual
slots, it was treated as a normal bitflag. This means we couldn't initialize a
libevdev context from scratch and have it behave like a correct MT context.

Fixes #4

Signed-off-by: Peter Hutterer

Don't read events unless required

2019-03-19T01:02:52+00:00

With the previous approach, every libevdev_next_event() invocation triggered a
read() on the device fd. This is not efficient, the kernel provides whole
event frames at a time so we're guaranteed to have more events waiting unless
the current event is a SYN_REPORT.

Assuming a fast-enough client and e.g. a touchpad device with multiple axes
per frame, we'd thus trigger several unnecessary read() calls per event frame.

Drop this behavior, instead only trigger the read when our internal queue is
empty and we need more events.

Fallout:
- we don't have any warning about a too-slow sync, i.e. if a SYN_DROPPED
  arrives while we're syncing, we don't get a warning in the log anymore.
  the test for this was removed.
- the tests that required the specific behavior were rewritten accordingly
- a revoke on a kernel device doesn't return ENODEV until already-received
  events have been processed

The above shouldn't be an issue for existing real-world clients.

Signed-off-by: Peter Hutterer

Replace ABS_MT_SLOT - 1 with the v4.20 ABS_RESERVED define

2019-01-16T03:17:33+00:00

ABS_RESERVED was added to 4.20 for that reason, to keep that event code
reserved so we can't use it for anything else (and thus mess up the fake MT
detection).

Signed-off-by: Peter Hutterer

Add libevdev_event_value_get_name() to resolve ABS_MT_TOOL_TYPE values

2018-07-09T01:57:57+00:00

ABS_MT_TOOL_TYPE values are an enum, not a numerical value like all other
axes. So let's allow converting those values to string.

Fixes https://gitlab.freedesktop.org/libevdev/libevdev/issues/1

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

Update struct input_event

2018-04-12T05:23:22+00:00

The struct input_event is not y2038 safe.
Update the struct according to the kernel patch:
https://lkml.org/lkml/2018/1/6/324

Signed-off-by: Deepa Dinamani 
Reviewed-by: Peter Hutterer 
Signed-off-by: Peter Hutterer

When changing the fd, reset our grab state to ungrabbed

2017-12-13T00:01:58+00:00

Previously, calling grabbing a device after changing the fd was a no-op
because libevdev's grab state didn't match the fd:

libevdev_grab(LIBEVDEV_GRAB);
  .. fd is grabbed
  .. internal state is 'grabbed'
libevdev_change_fd();
  .. new fd is ungrabbed
  .. internal state is 'grabbed'
libevdev_grab(LIBEVDEV_GRAB);
  .. argument matches internal state and we exit without grabbing the device

Signed-off-by: Peter Hutterer

Fix an indentation issues

2017-04-24T23:27:16+00:00

Signed-off-by: Peter Hutterer

Don't bother sanitizing disabled event codes

2016-08-17T07:43:32+00:00

Filter them immediately instead of passing them on and relying on the actual
event handling code to filter them.

Reproducer: if EV_ABS is disabled on an Apple MagicMouse we still get events
passed into sanitize_event(). But the code handling EV_ABS events doesn't
update the state, so we end up complaining about double tracking IDs, even
though that is not actually correct.

https://bugzilla.redhat.com/show_bug.cgi?id=1361325

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

Fix invalid absinfo range values reported by certain mtk soc

2015-08-24T06:26:00+00:00

This change will only affect certain touch screens, for which the driver
integration code does not provide meaningful values for the allowed range
of ABS_MT_TRACKING_IDs. The reported range [0, 0] will be overwritten with
[-1, 0xFFFF]

Signed-off-by: Andreas Pokorny 

[Changed from INT_MAX to 0xFFFF to match the kernel, add device name to log
message]

Signed-off-by: Peter Hutterer

Accept LIBEVDEV_READ_FLAG_BLOCKING as valid flag

2015-04-08T02:48:43+00:00

https://bugs.freedesktop.org/show_bug.cgi?id=89798

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires