delta/libevdev.git/libevdev/libevdev-uinput.c, branch libevdev-1.5.4

uinput: support the new UI_DEV_SETUP/UI_ABS_SETUP ioctls

2016-04-07T01:06:19+00:00

Available in kernel 4.5 and later (uinput version 5), these ioctls allow us to
set the absinfo correctly, i.e. including the resolution.

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

uinput: split uinput device creation into a helper function

2016-04-07T01:05:00+00:00

No functional changes. This is prep work for supporting the new
UIDEV_DEV_SETUP ioctl.

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

uinput: drop an unused argument

2016-04-07T01:04:59+00:00

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

uinput: fix race condition in uinput syspath check

2016-01-03T21:39:24+00:00

In theory, the device could change between stat() call and open(), resulting
in us opening the new device. Change to open() first, then fstat() on the fd.

Signed-off-by: Peter Hutterer 
Reviewed-by: David Herrmann

cosmetic: fix a couple of duplicate/missing empty lines

2015-03-03T22:41:33+00:00

Signed-off-by: Peter Hutterer

libevdev_uinput_destroy: don't close non-open FD

2015-01-20T22:48:50+00:00

The returned errno from libevdev_input_create_from_device was returned
incorrectly because libevdev_uinput_destroy() would try to close the
unset value of ->fd, overwriting errno.

That was fixed in debe9b030c8069cdf78307888ef3b65830b25122, this patch avoids
the ioctl/close calls if the fd isn't set.

Signed-off-by: Peter Hutterer

uinput: explicitly ignore the UI_DEV_DESTROY return value

2014-08-24T23:54:28+00:00

This can't fail in the kernel anyway, so cast it to shut up Coverity.
Error message:
"Calling function "ioctl(int, unsigned long, ...)" without checking return
 value (as is done elsewhere 35 out of 36 times)."

Signed-off-by: Peter Hutterer

uinput: close the managed fd on error

2014-08-22T01:50:13+00:00

Using LIBEVDEV_UINPUT_OPEN_MANAGED can leak the fd if an error occurs after
opening it.

Found by Coverity.

Signed-off-by: Peter Hutterer

uinput: preserve the errno before cleaning up

2014-08-14T22:37:30+00:00

libevdev_uinput_destroy() may/will botch the errno, make sure we save it
before use.

Signed-off-by: Peter Hutterer

uinput: check errno against the positive value

2014-08-14T22:37:26+00:00

We use the negative errno internally, but the proper errno is always positive.

Fixes device creation failures on kernels that don't support UI_SET_PROPBIT.

Signed-off-by: Peter Hutterer 
Reviewed-by: David Herrmann