delta/libevdev.git/libevdev/libevdev-uinput.c, branch libevdev-1.3

uinput: explicitly ignore the UI_DEV_DESTROY return value

2014-08-24T23:54:28+00:00

This can't fail in the kernel anyway, so cast it to shut up Coverity.
Error message:
"Calling function "ioctl(int, unsigned long, ...)" without checking return
 value (as is done elsewhere 35 out of 36 times)."

Signed-off-by: Peter Hutterer

uinput: close the managed fd on error

2014-08-22T01:50:13+00:00

Using LIBEVDEV_UINPUT_OPEN_MANAGED can leak the fd if an error occurs after
opening it.

Found by Coverity.

Signed-off-by: Peter Hutterer

uinput: preserve the errno before cleaning up

2014-08-14T22:37:30+00:00

libevdev_uinput_destroy() may/will botch the errno, make sure we save it
before use.

Signed-off-by: Peter Hutterer

uinput: check errno against the positive value

2014-08-14T22:37:26+00:00

We use the negative errno internally, but the proper errno is always positive.

Fixes device creation failures on kernels that don't support UI_SET_PROPBIT.

Signed-off-by: Peter Hutterer 
Reviewed-by: David Herrmann

uinput: change strcpy/strcat usage for snprintf

2014-06-20T01:00:16+00:00

Better protection against buffer overflow, though by the time someone
is manipulating your sysfs, libevdev is unlikely to be the biggest worry.

Slight change in functionality: before we checked the timestamp of
/sys/devices/virtual/input/inputXYZ before looking at /inputXYZ/name, now we
just check the name file for the timestamp.

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

uinput: use the UI_GET_SYSNAME ioctl if available

2014-06-20T00:58:46+00:00

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

Add per-device log handlers

2014-06-05T05:16:06+00:00

The global log handler isn't a good choice for a low-level library. In the
caser of the X server, both evdev and synaptics are now using the libevdev but
are loaded from the same server process. Thus, there's only one log handler,
but evdev and synaptics don't talk to each other (a bit childish, I know).

Add a per-device log handler that overrides the global log handler, and fall
back to the global log handler if no device log handler is set. The log
macros take care of that automatically, especially as we can't do per-device
log handlers for the uinput code.

Note that we use the same struct for the global and device logging, so in each
instance one of the two function pointers is NULL. Suicide triggers are in
place in case we mess that up.

This also makes libevdev_new_from_fd() a bit less useful since we can't set
the log handler beforehand.

Signed-off-by: Peter Hutterer 
Reviewed-by: David Herrmann

Ignore NULL as argument in libevdev_uinput_destroy()

2014-05-07T08:52:17+00:00

Triggered by the tests when run as non-root. Simply ignore any attempt to
destroy a NULL device, which also matches the behaviour of libevdev_free().

Reported-by: Andreas Radke 
Reviewed-by: Daniel Martin 
Tested-by: Daniel Martin 
Reviewed-by: David Herrmann 
Signed-off-by: Peter Hutterer

uinput: check for asprintf failure

2014-03-18T23:36:41+00:00

This doesn't really do much here, but strictly speaking: if asprintf returns
-1, devnode is undefined. So reset it to NULL to avoid weird pointers. And
also free the rest of the names if we ever have more than one device - which
also shouldn't happen.

Signed-off-by: Peter Hutterer 
Reviewed-by: Benjamin Tissoires

Fix memory leaks when failing to create a uinput device

2014-02-27T03:22:50+00:00

For an invalid fd, or a failure to open the device, the pre-allocated uinput
device struct would leak.

We can drop the open_uinput() function now, since skipping to the error
handling means we'll return -errno anyway.

Signed-off-by: Peter Hutterer