From aa126532877acb3bf3d44ca4898e6f7a6fb6bd5f Mon Sep 17 00:00:00 2001 From: ivan Date: Fri, 20 Sep 2019 13:24:56 +0000 Subject: Remove the APR_SENDFILE_DISCONNECT_SOCKET flag. There are several problems with this flag: 1. The TCP socket may be subject to the TCP TIME_WAIT state. That means apr_sock_sendfile() could occupy worker thread for significant time (30 seconds) 2. With this flag specified, the socket descriptor is removed from the apr_socket_t and the caller caller is expected to maintain the descriptor and release it manually, which is particularly error-prone. See also: https://lists.apache.org/thread.html/a3c4a03961a4b5842e7f657a15fe777edf5949b768a2807619a104b1@%3Cdev.apr.apache.org%3E git-svn-id: http://svn.apache.org/repos/asf/apr/apr/trunk@1867226 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES | 2 ++ 1 file changed, 2 insertions(+) (limited to 'CHANGES') diff --git a/CHANGES b/CHANGES index 07f7d9ee1..ab9efd560 100644 --- a/CHANGES +++ b/CHANGES @@ -224,6 +224,8 @@ Changes for APR 2.0.0 *) apr_socket_listen: Allow larger listen backlog values on Windows 8+. [Evgeny Kotkov ] + *) Remove the APR_SENDFILE_DISCONNECT_SOCKET flag. [Ivan Zhakov] + Changes for APR and APR-util 1.6.x and later: *) http://svn.apache.org/viewvc/apr/apr/branches/1.6.x/CHANGES?view=markup -- cgit v1.2.1