From 9b0842fafa3bf3afe11438b6349ed55173cf4327 Mon Sep 17 00:00:00 2001 From: Tony Gravagno Date: Sun, 12 Jan 2020 19:16:19 -0800 Subject: Fix space issue in AntStructure.DTDPrinter Task AntStructure renders a project DTD. In AntStructure class DTDPrinter, line 327, a single statement is used to concatenate a list of enumerated values which are valid for an attribute. The list is enclosed in parentheses. At line 348 the string "#IMPLIED" is appended to all attribute definitions regardless of type. For other types like Boolean and CDATA, a space is appended. Not for these enumerations. This results in a DTD validation error. Ref [XERCES definition](https://xerces.apache.org/xerces-j/apiDocs/org/apache/xerces/utils/XMLMessages.html#MSG_SPACE_REQUIRED_BEFORE_DEFAULTDECL_IN_ATTDEF) The full message displayed in VSCode may be different from elsewhere: White space is required before the attribute default in the declaration of attribute "x" for element "y". xml(MSG_SPACE_REQUIRED_BEFORE_DEFAULTDECL_IN_ATTDEF) This simple one-line change appends the space character required to avoid that error. **Note:** This should not be modified into a change on the `joinAlts` Collector which surrounds values in parentheses. That Collector is used elsewhere where regex syntax is applied immediately after. See line 298. That asterisk cannot be separated from the values with a space. The space must only be applied to line 327. --- CONTRIBUTORS | 1 + 1 file changed, 1 insertion(+) (limited to 'CONTRIBUTORS') diff --git a/CONTRIBUTORS b/CONTRIBUTORS index a831e8fe9..4b21cf7ea 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -433,6 +433,7 @@ Tom Eugelink Tom May Tomasz Bech Tomáš Zezula +Tony Gravagno Trejkaz Xaoza Ulrich Schmidt Uwe Schindler -- cgit v1.2.1