<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/ipmitool.git, branch codefactor</title>
<subtitle>github.com: ipmitool/ipmitool.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/'/>
<entry>
<title>fru: Reduce duplicate code</title>
<updated>2019-03-07T16:44:54+00:00</updated>
<author>
<name>Alexander Amelkin</name>
<email>mocbuhtig@amelkin.msk.ru</email>
</author>
<published>2018-05-30T21:19:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=57dc21a4864d2dd4759eb9669e2f3b6721b744bf'/>
<id>57dc21a4864d2dd4759eb9669e2f3b6721b744bf</id>
<content type='text'>
Signed-off-by: Alexander Amelkin &lt;alexander@amelkin.msk.ru&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Alexander Amelkin &lt;alexander@amelkin.msk.ru&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused include</title>
<updated>2019-03-04T09:22:23+00:00</updated>
<author>
<name>Alexander Amelkin</name>
<email>alexander@amelkin.msk.ru</email>
</author>
<published>2019-03-04T09:20:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=55ec2df41ff44c3035fb2833aeaf59b52aa6523c'/>
<id>55ec2df41ff44c3035fb2833aeaf59b52aa6523c</id>
<content type='text'>
The endian.h header is not used for anything and was earlier
added by mistake. It however hampers building on some systems
where it doesn't exist.

Resolves ipmitool/ipmitool#101
Signed-off-by: Alexander Amelkin &lt;alexander@amelkin.msk.ru&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The endian.h header is not used for anything and was earlier
added by mistake. It however hampers building on some systems
where it doesn't exist.

Resolves ipmitool/ipmitool#101
Signed-off-by: Alexander Amelkin &lt;alexander@amelkin.msk.ru&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix IPMI DCMI message typo</title>
<updated>2019-02-21T10:58:18+00:00</updated>
<author>
<name>George Keishing</name>
<email>gkeishin@in.ibm.com</email>
</author>
<published>2019-02-21T08:46:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=48f4fba39a70fbc2055feaeed500cd27174c0724'/>
<id>48f4fba39a70fbc2055feaeed500cd27174c0724</id>
<content type='text'>
Signed-off-by: George Keishing &lt;gkeishin@in.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: George Keishing &lt;gkeishin@in.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>open: swap free() calls for free_n()</title>
<updated>2019-02-20T15:29:09+00:00</updated>
<author>
<name>Patrick Venture</name>
<email>venture@google.com</email>
</author>
<published>2018-12-25T14:55:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=df076b9547d1fabe8fa2cee14af6cf8ff8726dff'/>
<id>df076b9547d1fabe8fa2cee14af6cf8ff8726dff</id>
<content type='text'>
Swap calls to free() with calls to free_n() to leverage helper method
and handle clearing pointers after freeing in one step.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Swap calls to free() with calls to free_n() to leverage helper method
and handle clearing pointers after freeing in one step.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>open: checking received msg id against expectation</title>
<updated>2019-02-20T15:29:09+00:00</updated>
<author>
<name>Patrick Venture</name>
<email>venture@google.com</email>
</author>
<published>2018-12-05T00:47:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=51634fd77c836e3cb5acd9b9b72e7ede20321d56'/>
<id>51634fd77c836e3cb5acd9b9b72e7ede20321d56</id>
<content type='text'>
Check the received IPMI response message id against
the id expected given the IPMI request.  They need to
match.  It is possible that request A times out,
request B is sent, and then request A responds to the
request B.  The value for request B may be behind it
in the queue.

Note: This may only be possible if the file is kept
open between multiple IPMI messages (a common
occurrence).

Resolves: #82

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Check the received IPMI response message id against
the id expected given the IPMI request.  They need to
match.  It is possible that request A times out,
request B is sent, and then request A responds to the
request B.  The value for request B may be behind it
in the queue.

Note: This may only be possible if the file is kept
open between multiple IPMI messages (a common
occurrence).

Resolves: #82

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>open: fix whitespace</title>
<updated>2019-02-20T15:29:09+00:00</updated>
<author>
<name>Patrick Venture</name>
<email>venture@google.com</email>
</author>
<published>2018-11-26T18:26:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=3bfa1da201997efb5d728b6d1bcbc0825175b5b2'/>
<id>3bfa1da201997efb5d728b6d1bcbc0825175b5b2</id>
<content type='text'>
Apply whitespace fixes via clang-format-6.0 to src/plugins/open/open.c
to cleanup spaces and fixup line lengths, etc.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Apply whitespace fixes via clang-format-6.0 to src/plugins/open/open.c
to cleanup spaces and fixup line lengths, etc.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor free_n() function</title>
<updated>2019-02-20T11:56:37+00:00</updated>
<author>
<name>Alexander Amelkin</name>
<email>alexander@amelkin.msk.ru</email>
</author>
<published>2019-02-20T11:56:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=08348f1b72de27681549894f7a506674fba19ff2'/>
<id>08348f1b72de27681549894f7a506674fba19ff2</id>
<content type='text'>
Make the argument to free_n() compatible with any pointers,
thus reducing the number of compilation warnings.

End-user-impact: None
Signed-off-by: Alexander Amelkin &lt;alexander@amelkin.msk.ru&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make the argument to free_n() compatible with any pointers,
thus reducing the number of compilation warnings.

End-user-impact: None
Signed-off-by: Alexander Amelkin &lt;alexander@amelkin.msk.ru&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fru: swap free() calls for free_n()</title>
<updated>2019-02-13T18:28:14+00:00</updated>
<author>
<name>Patrick Venture</name>
<email>venture@google.com</email>
</author>
<published>2018-12-25T14:12:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=a8b3b6282b3d2bb7fa0e54ce47b06302a96439d7'/>
<id>a8b3b6282b3d2bb7fa0e54ce47b06302a96439d7</id>
<content type='text'>
Swap calls to free() with calls to free_n() to leverage helper method
and handle clearing pointers after freeing in one step.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Swap calls to free() with calls to free_n() to leverage helper method
and handle clearing pointers after freeing in one step.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fru: Fix write chunk reduction code</title>
<updated>2019-02-13T18:28:14+00:00</updated>
<author>
<name>Patrick Venture</name>
<email>venture@google.com</email>
</author>
<published>2018-12-28T15:32:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=eb5f26060a306d4efc44dd6e603f2ccb88c78f91'/>
<id>eb5f26060a306d4efc44dd6e603f2ccb88c78f91</id>
<content type='text'>
Check against FRU_AREA_MAXIMUM_BLOCK_SZ instead of FRU_BLOCK_SZ
when checking if the write chunk needs to be reduced.
Apparently, that was the original intention, and then there
was just a typo. In other places the same check is done properly.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Check against FRU_AREA_MAXIMUM_BLOCK_SZ instead of FRU_BLOCK_SZ
when checking if the write chunk needs to be reduced.
Apparently, that was the original intention, and then there
was just a typo. In other places the same check is done properly.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>fru: add macro FRU_AREA macros</title>
<updated>2019-02-13T18:28:14+00:00</updated>
<author>
<name>Patrick Venture</name>
<email>venture@google.com</email>
</author>
<published>2018-12-05T15:43:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/ipmitool.git/commit/?id=feecd2bbf40c8c78cfce88ac2966e926b60362c4'/>
<id>feecd2bbf40c8c78cfce88ac2966e926b60362c4</id>
<content type='text'>
Use two macros defining the FRU block sizes instead of hard-coded magic
values.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use two macros defining the FRU block sizes instead of hard-coded magic
values.

Signed-off-by: Patrick Venture &lt;venture@google.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
