From 7c0b595e55d31f9f89e6dede11981e942c5bb32f Mon Sep 17 00:00:00 2001 From: Takano Akio Date: Thu, 12 May 2016 15:45:44 +0200 Subject: Fix comments about scavenging WEAK objects This is a follow-up of D2189. If fixes some comments, deletes a section in the User's Guide about the bug, and updates .mailmap as suggested on the WorkinConventions wiki page. Test Plan: It compiles. Reviewers: austin, simonmar, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2202 GHC Trac Issues: #11108 --- rts/sm/Scav.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'rts/sm/Scav.c') diff --git a/rts/sm/Scav.c b/rts/sm/Scav.c index b046f39ad5..7a799d6be6 100644 --- a/rts/sm/Scav.c +++ b/rts/sm/Scav.c @@ -1300,6 +1300,10 @@ scavenge_one(StgPtr p) } case WEAK: + // This WEAK object will not be considered by tidyWeakList during this + // collection because it is in a generation >= N, but it is on the + // mutable list so we must evacuate all of its pointers because some + // of them may point into a younger generation. scavengeLiveWeak((StgWeak *)p); break; -- cgit v1.2.1