When digging into suspected memory leaks, it's cumbersome to count the number of allocations and free calls. Here we're adding a summary at the end of the sum of allocs minus the sum of frees, excluding realloc since we can't know how much it releases upon each call. This means that when doing many realloc+free the count may be negative but in practice there are very few reallocs so that's not a problem. Also the size/call is signed and corresponds to the average size allocated (e.g. leaked) per call. It seems to work reasonably well for now: > debug dev memstats match buf quic_conn.c:2978 P_FREE size: 1239547904 calls: 75656 size/call: 16384 buffer quic_conn.c:2960 P_ALLOC size: 1239547904 calls: 75656 size/call: 16384 buffer mux_quic.c:393 P_ALLOC size: 9112780800 calls: 556200 size/call: 16384 buffer mux_quic.c:383 P_ALLOC size: 17783193600 calls: 1085400 size/call: 16384 buffer mux_quic.c:159 P_FREE size: 8935833600 calls: 545400 size/call: 16384 buffer mux_quic.c:142 P_FREE size: 9112780800 calls: 556200 size/call: 16384 buffer h3.c:776 P_ALLOC size: 8935833600 calls: 545400 size/call: 16384 buffer quic_stream.c:166 P_FREE size: 975241216 calls: 59524 size/call: 16384 buffer quic_stream.c:127 P_FREE size: 7960592384 calls: 485876 size/call: 16384 buffer stream.c:772 P_FREE size: 8798208 calls: 537 size/call: 16384 buffer stream.c:768 P_FREE size: 2424832 calls: 148 size/call: 16384 buffer stream.c:751 P_ALLOC size: 8852062208 calls: 540287 size/call: 16384 buffer stream.c:641 P_FREE size: 8849162240 calls: 540110 size/call: 16384 buffer stream.c:640 P_FREE size: 8847360000 calls: 540000 size/call: 16384 buffer channel.h:850 P_ALLOC size: 2441216 calls: 149 size/call: 16384 buffer channel.h:850 P_ALLOC size: 5914624 calls: 361 size/call: 16384 buffer dynbuf.c:55 P_FREE size: 32768 calls: 2 size/call: 16384 buffer Total BALANCE size: 0 calls: 5606906 size/call: 0 (excl. realloc) Let's see how useful this becomes over time.
Sometimes when debugging it's convenient to be able to focus only on certain pools. Just like we did for "show pools", let's add a filter based on a prefix on "debug dev memstats match <prefix>".
This patch also adds a set of new global options:
- 51degrees-use-performance-graph { on | off }
- 51degrees-use-predictive-graph { on | off }
- 51degrees-drift <number>
- 51degrees-difference <number>
- 51degrees-allow-unmatched { on | off }
To build using the latest 51Degrees V4 engine with Hash algorithm, set
USE_51DEGREES_V4=1.
Other supported build options are 51DEGREES_INC, 51DEGREES_LIB and
51DEGREES_SRC which needs to be set to the directory that contains
headers and C files. For example:
make TARGET=<target> USE_51DEGREES_V4=1 51DEGREES_SRC='51D_REPO_PATH'/src
It happens from time to time while switching between branches and/or updating after someone else's changes that regtests are run by accident on the wrong binary, typically the one the tests were run on during development and not with the latest adaptations. And obviously it's when this happens that we break the CI. There are various causes to this but they all come down to humans context-switching a lot, and there's no real fix for this that doesn't add even more burden hence increases the overhead. However we can help the human detect such mistakes very easily. This change here will compare the version of the haproxy binary to the version of the tree, and will emit a warning in the regtest output if they do not match, regardless of the outcome of the test. This is sufficient in case of failures because these are quickly glanced over, and is sufficient as well in case of accidental success because the warning is the last message. E.g: ########################## Starting vtest ########################## Testing with haproxy version: 2.7-dev10-cfcdbc-38 Warning: version does not match the current tree (2.7-dev10-111c78-39) 0 tests failed, 0 tests skipped, 182 tests passed This should not affect builds made out of a git tree because the version is retrieved using "make version", or exactly the same way as it's passd to the haproxy binary. We just need to know what "make" command to run, so $MAKE is used primarily, falling back to "make" then to "gmake". In case all of these fail, we just ignore the version check. This should be sufficient to catch human mistakes without affecting the CI.
These two have absolutely zero impact on the process and do not need to be restricted to the expert mode. The first one calculates a string hash that can be used by anyone when checking a dump; the second one may be used by anyone tracking a memory leak, and is cumbersome to use due to the "expert-mode on" that needs to be prepended. In addition this gives bad habits to users and needlessly taints the process. So let's drop this restriction for these two commands.
This command is used to hash a section name using the current anon key,
it was brought in 2.7 by commit 54966dffd ("MINOR: anon: store the
anonymizing key in the CLI's appctx"). However the help message only
says "return msg hashed" which is misleading because if anon mode is
not enabled, it returns the string as-is. Let's just mention this
condition in the help message, and also fix the alphabetical ordering
and alignment on the line.
WolfSSL does not implement the TLS1_3_CK_AES_128_CCM_SHA256 cipher as well as the SSL_ERROR_WANT_ASYNC, SSL_ERROR_WANT_ASYNC_JOB and SSL_ERROR_WANT_CLIENT_HELLO_CB error codes. This patch disables them for WolfSSL. Signed-off-by: William Lallemand <wlallemand@haproxy.org>
"debug dev memstats" supports various options but silently ignores the unknown ones. Let's make sure it returns indications about what it expects, as the help message is quite limited otherwise.
Just like for the H2 multiplexer, info about the H1 connection task is now displayed in "show fd" output. The task pointer is displayed and, if not null, its expiration date. It may be useful to backport it.
This is 33rd iteration of typo fixes