From 888dfe499d92a434c3ce703df7057c4703a6c75e Mon Sep 17 00:00:00 2001 From: Emmanuele Bassi Date: Fri, 2 Feb 2018 16:34:40 +0100 Subject: Drop the Big GDK Lock MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GDK has a lock to mark critical sections inside the backends. Additionally, code that would re-enter into the GTK main loop was supposed to hold the lock. Back in the Good Old Days™ this was guaranteed to kind of work only on the X11 backend, and would cause a neat explosion on any other GDK backend. During GTK+ 3.x we deprecated the API to enter and leave the critical sections, and now we can remove all the internal uses of the lock, since external API that uses GTK+ 4.x won't be able to hold the GDK lock. https://bugzilla.gnome.org/show_bug.cgi?id=793124 --- gtk/gtkprinter.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'gtk/gtkprinter.c') diff --git a/gtk/gtkprinter.c b/gtk/gtkprinter.c index 5e145ddd69..fe012bb40e 100644 --- a/gtk/gtkprinter.c +++ b/gtk/gtkprinter.c @@ -1267,10 +1267,7 @@ gtk_enumerate_printers (GtkPrinterFunc func, if (wait && printer_list->backends) { printer_list->loop = g_main_loop_new (NULL, FALSE); - - gdk_threads_leave (); g_main_loop_run (printer_list->loop); - gdk_threads_enter (); } } -- cgit v1.2.1