From 70b341139b48a7ee2bbb5bf6ba133fbe673fd2e5 Mon Sep 17 00:00:00 2001
From: Benjamin Otte <otte@redhat.com>
Date: Sat, 2 Mar 2019 11:46:07 +0100
Subject: transform: Remove gsk_transform_identity()

This used to be a good idea back when GskTransform was intended to be
used for transitions, but without it, it's not anymore.
---
 gsk/gsktransform.c | 27 +--------------------------
 gsk/gsktransform.h |  2 --
 2 files changed, 1 insertion(+), 28 deletions(-)

(limited to 'gsk')

diff --git a/gsk/gsktransform.c b/gsk/gsktransform.c
index f6c4b4a1ab..a1e6da676e 100644
--- a/gsk/gsktransform.c
+++ b/gsk/gsktransform.c
@@ -178,7 +178,7 @@ static GskTransform *
 gsk_identity_transform_apply (GskTransform *transform,
                               GskTransform *apply_to)
 {
-  return gsk_transform_identity (apply_to);
+  return apply_to;
 }
 
 static gboolean
@@ -223,28 +223,6 @@ gsk_transform_is_identity (GskTransform *self)
          (self->transform_class == &GSK_IDENTITY_TRANSFORM_CLASS && gsk_transform_is_identity (self->next));
 }
 
-/**
- * gsk_transform_identity:
- * @next: (allow-none): the next transform operation or %NULL
- *
- * Adds an identity multiplication into the list of matrix operations.
- *
- * This operation is generally useless, but may be useful when interpolating
- * matrices, because the identity matrix can be interpolated to and from
- * everything, so an identity matrix can be used as a keyframe between two
- * different types of matrices.
- *
- * Returns: The new matrix
- **/
-GskTransform *
-gsk_transform_identity (GskTransform *next)
-{
-  if (gsk_transform_is_identity (next))
-    return next;
-
-  return gsk_transform_alloc (&GSK_IDENTITY_TRANSFORM_CLASS, next);
-}
-
 /*** MATRIX ***/
 
 typedef struct _GskMatrixTransform GskMatrixTransform;
@@ -1470,9 +1448,6 @@ gsk_transform_get_category (GskTransform *self)
  * Creates a new identity matrix. This function is meant to be used by language
  * bindings. For C code, this equivalent to using %NULL.
  *
- * See also gsk_transform_identity() for inserting identity matrix operations
- * when constructing matrices.
- *
  * Returns: A new identity matrix
  **/
 GskTransform *
diff --git a/gsk/gsktransform.h b/gsk/gsktransform.h
index c38955fa26..3696f6fab2 100644
--- a/gsk/gsktransform.h
+++ b/gsk/gsktransform.h
@@ -76,8 +76,6 @@ gboolean                gsk_transform_equal                     (GskTransform
 GDK_AVAILABLE_IN_ALL
 GskTransform *          gsk_transform_new                       (void);
 GDK_AVAILABLE_IN_ALL
-GskTransform *          gsk_transform_identity                  (GskTransform                   *next);
-GDK_AVAILABLE_IN_ALL
 GskTransform *          gsk_transform_transform                 (GskTransform                   *next,
                                                                  GskTransform                   *other);
 GDK_AVAILABLE_IN_ALL
-- 
cgit v1.2.1