From ca3d87ce70e1a9c00a37d40eb0d8039d92368a1d Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Fri, 26 Feb 2016 15:50:31 -0500 Subject: Avoid an out-of-bounds access When the offset gets smaller than min_offset, we can't access the array at that position. --- gtk/gtktextiter.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gtk/gtktextiter.c b/gtk/gtktextiter.c index dc3891a1b4..3e2e5f5300 100644 --- a/gtk/gtktextiter.c +++ b/gtk/gtktextiter.c @@ -3073,9 +3073,12 @@ inside_sentence_func (const PangoLogAttr *attrs, gint len) { /* Find next sentence start or end */ - while (offset >= min_offset && - !(attrs[offset].is_sentence_start || attrs[offset].is_sentence_end)) - --offset; + while (!(attrs[offset].is_sentence_start || attrs[offset].is_sentence_end)) + { + --offset; + if (offset < min_offset) + return FALSE; + } return attrs[offset].is_sentence_start; } -- cgit v1.2.1