| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_widget_set_parent() will map the widget if the parent is mapped
and the widget is both visible and child-visible. As we currently
only set the child visibility after adding the child, we immediately
map all children that are added to a mapped stack, even when they
are not actually shown. Avoid this by setting the child visibility
before adding the child, so widgets are only mapped when shown.
https://bugzilla.gnome.org/show_bug.cgi?id=766737
|
|
|
|
|
|
|
|
| |
When starting a rubberband selection from an empty area, we could run
into crashes if the selection moves over the rows and then back out
to unpopulated area. Handle this case without crashing.
https://bugzilla.gnome.org/show_bug.cgi?id=766336
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the popover's relative-to widget is unparented/reparented, we end
up unparenting/reparenting the popover as well. In that case, at the
moment of reparenting, the widget might have been visible (and is
thus mapped again), but priv->window hasn't been set yet.
We must first set priv->window, and then call gtk_window_add_popover(),
that way gtk_popover_map() has its prerequisites straight.
https://bugzilla.gnome.org/show_bug.cgi?id=766323
|
| |
|
|
|
|
| |
See https://bugzilla.gnome.org/show_bug.cgi?id=766642
|
|
|
|
| |
make the switch height and width 1px smaller.
|
|
|
|
|
|
|
|
| |
This reverts commit dcb4b48b29559ca632bb020a3b8eb2b9188b02e7.
This was causing crashes in the filechooser in some applications.
https://bugzilla.gnome.org/show_bug.cgi?id=766694
|
|
|
|
| |
This was causing problems with the gtk# scanner
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
This only used by luck before. We are changing a property from the
::notify handler for that property. Now that GtkRevealer is notifying
the property when it stops animations on unmap, we end up in a life
lock situation where we never make it out of the notify queue.
Fix this by not restarting the animation if the widget is unmapped.
|
|
|
|
| |
The style classes are reflected in the output here.
|
|
|
|
|
|
| |
This can be made to happen eg by setting XDG_DATA_DIRS and
XDG_DATA_HOME to /. Not a useful value, but not a good reason
to crash either.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is required for proper integration with any other library/application that
may perform wayland API calls and poll() the wayland fd from multiple threads.
Using wl_display_dispatch{_queue}() is thread-safe if not mixed with custom
poll() usage, which GSource/GMainContext does.
Essentially, the problem is that multiple threads polling and reading
the same fd is extremely racy. Use the wayland provided API for allowing
concurrent access to the wayland display fd.
See the wayland man pages for wl_display_prepare_read(),
wl_display_cancel_read() and wl_display_read_events() for more details.
https://bugzilla.gnome.org/show_bug.cgi?id=763852
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we are beginning to calculate the height, if the vscrollbar_policy
is not GTK_POLICY_NEVER, and there is no min-content-height, then we
need some small non-zero value to get started. The idea is to always
ask for at least enough to fit the horizontal scrollbar.
Simply put, this should be the mirror image of the corresponding width
calculation code.
Those who got used to the buggy behaviour might notice that their
GtkScrolledWindows are not as tall as they used to be.
Fall out from 55196a705f00564a44647bfc97981db0a783369a
https://bugzilla.gnome.org/show_bug.cgi?id=766530
|
|
|
|
|
|
|
| |
Warn about the situation when we've found a resource or file path,
but gdk-pixbuf fails to give us a pixbuf. This generally means that
either pixbuf loaders are not found or the shared-mime database
is missing.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
At one point, the sidebar was using gtk_treeview_set_tooltip_column,
which expects tooltips to be markup. With the listbox-based sidebar,
we don't do that anymore. So don't escape the tooltip text.
https://bugzilla.gnome.org/show_bug.cgi?id=766175
|
|
|
|
|
|
|
| |
XIGetClientPointer can generate X errors (e.g. when the X server
does not support XI2. Trap them and carry on.
https://bugzilla.gnome.org/show_bug.cgi?id=766233
|
|
|
|
|
| |
Being both (allow-none) and (nullable) at the same time is a bit much.
Was from 591e7f5ef8538982e227b2c2cefc536a33cafa6c.
|
| |
|
|
|
|
|
|
| |
Children tend to call back into the scrolled window while being removed
and that doesn't work too well if the scrolled window is destroyed
already as Christian Hergert found out.
|
|
|
|
| |
... below 7px of size.
|
| |
|
|
|
|
| |
I forgot to clear the buffer before inserting the new markup. Oops.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depending of float rounding during target calculation, the size of the
GtkRevealer can be set to zero will the animation is not finished.
If the GtkRevealer is in a GtkPaned, it will be hidden and so the animation
will be stopped before it is finished.
In this case, force the emission of the child-revealed signal to let
client code know the animation is finished.
https://bugzilla.gnome.org/show_bug.cgi?id=765973
|
|
|
|
| |
Style class names are prefixed with a '.'
|
|
|
|
|
|
| |
rely on toplevel styleclass for scale with marks.
See https://bugzilla.gnome.org/show_bug.cgi?id=766440
|
|
|
|
| |
sync the alpha scale styleclass too.
|
|
|
|
|
| |
We should use the same style classes here, to avoid theme
confusion.
|
|
|
|
| |
This seems to make some issue with the gtk# scanner.
|
|
|
|
|
|
|
|
|
| |
Use .marks-before/after to indicate the presence of marks.
As Lapo points out, compatibility with the previous names
is not really that important, since everything else changed
around it.
https://bugzilla.gnome.org/show_bug.cgi?id=766440
|
|
|
|
|
|
|
|
|
|
| |
It turns out that it is too hard (and in some cases, impossible)
to get this information from node positioning, so bring back the
.scale-has-marks-above/below style classes on the main node.
This should allow us to fix the 'pointy sliders'.
https://bugzilla.gnome.org/show_bug.cgi?id=766440
|
|
|
|
|
|
|
|
|
| |
The GdkDragContext should only listen to GDK_GRAB_BROKEN events sent to
its own pointer device. It turns out that the passive key grabs mistake
GDK into sending a GdkEventGrabBroken on the master keyboard, which the
DnD machinery mistakes as a signal to cancel the operation.
https://bugzilla.gnome.org/show_bug.cgi?id=766442
|
| |
|
|
|
|
|
|
|
| |
gtk_gesture_get_last_event() wasn't very clear about how long
it is safe to use the returned pointer.
(cherry picked from commit c891ceb31df1fb16c7727be46cee4d8a9fc0b447)
|
|
|
|
|
|
|
|
| |
Cancelling the gesture causes the last_event pointer to become
invalid. Make a copy of the event so we can keep using it
regardless of the gesture state.
(cherry picked from commit 358eec297204b438809692a24cc3649658dbab5a)
|
| |
|
| |
|
|
|
|
|
|
| |
Split out the part where we generate/update the caches for the GSchemas
and the icons, so that it is easier to ensure that things continue to
function correctly when we have GlibEtcInstallRoot != CopyDir.
|
| |
|
| |
|
|
|
|
|
|
| |
The selector for matching GtkEntry has changed to `entry` after 3.20.
https://bugzilla.gnome.org/show_bug.cgi?id=766166
|
| |
|
|
|
|
|
| |
relocate treview acceleditor > label in the treeview section and
add a comment for a testcase.
|
|
|
|
| |
...removing a double definition in the process.
|
|
|
|
|
|
|
| |
We were failing to take the widget allocation.x/y into account
when deciding whether we need to push in the mark.
https://bugzilla.gnome.org/show_bug.cgi?id=765922
|
|
|
|
|
|
| |
The active keyboard grab can be spared then. This way the passive
key grabs allow other key combinations (eg. alt-tab) that are not
mandatory to grab here.
|