From 5d8e7598acb9cb4c1bb7da3b951be8763720b17c Mon Sep 17 00:00:00 2001 From: Vivia Nikolaidou Date: Thu, 17 Mar 2016 20:53:27 +0200 Subject: deinterlace: Fix typo to not change the input caps but our filtered caps Changing the input caps and not using them anymore afterwards is useless, and it breaks negotiation in pipelines like: gst-launch-1.0 videotestsrc ! "video/x-raw,framerate=25/1,interlace-mode=interleaved" ! deinterlace fields=all ! "video/x-raw,framerate=50/1,interlace-mode=progressive" ! fakesink --- gst/deinterlace/gstdeinterlace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/deinterlace/gstdeinterlace.c b/gst/deinterlace/gstdeinterlace.c index 8bf824780..644a75aee 100644 --- a/gst/deinterlace/gstdeinterlace.c +++ b/gst/deinterlace/gstdeinterlace.c @@ -2347,8 +2347,8 @@ gst_deinterlace_getcaps (GstDeinterlace * self, GstPad * pad, GstCaps * filter) gst_caps_unref (tmp); tmp = NULL; - for (len = gst_caps_get_size (caps); len > 0; len--) { - GstStructure *s = gst_caps_get_structure (caps, len - 1); + for (len = gst_caps_get_size (tmp2); len > 0; len--) { + GstStructure *s = gst_caps_get_structure (tmp2, len - 1); if (pad == self->sinkpad) gst_structure_remove_field (s, "interlace-mode"); -- cgit v1.2.1