diff options
| author | Sebastian Dröge <sebastian@centricular.com> | 2016-03-13 10:33:13 +0200 |
|---|---|---|
| committer | Sebastian Dröge <sebastian@centricular.com> | 2016-03-13 10:33:13 +0200 |
| commit | 66e9e4c20291b91038a4dc2a112ca04fd6533192 (patch) | |
| tree | e6f81937024b52cd677f897ceb11c47f319674f1 | |
| parent | bbde949e8eb89586f2a3fd2e788133340750cb42 (diff) | |
| download | gstreamer-plugins-good-66e9e4c20291b91038a4dc2a112ca04fd6533192.tar.gz | |
Revert "flacparse: push tags in pre_push_frame"
This reverts commit 4065fcb80a49924b70f0c8fc159dec0ff47943a1.
flacparse should not push tags by itself, the base class is going to do that
while properly merging in upstream tags. It just didn't because of a bug in
the base class, which was hidden by this commit.
https://bugzilla.gnome.org/show_bug.cgi?id=763553
| -rw-r--r-- | gst/audioparsers/gstflacparse.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/gst/audioparsers/gstflacparse.c b/gst/audioparsers/gstflacparse.c index d523c2dcf..34e1e5e66 100644 --- a/gst/audioparsers/gstflacparse.c +++ b/gst/audioparsers/gstflacparse.c @@ -1714,12 +1714,6 @@ gst_flac_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame) flacparse->sent_codec_tag = TRUE; } - /* Push tags */ - if (flacparse->tags) { - gst_pad_push_event (GST_BASE_PARSE_SRC_PAD (flacparse), - gst_event_new_tag (flacparse->tags)); - flacparse->tags = NULL; - } /* Push toc */ if (flacparse->toc) { gst_pad_push_event (GST_BASE_PARSE_SRC_PAD (flacparse), |