* bootstrap.conf: Add "stdint" module to ensure that the `uintptr_t`
  type is available.

* src/include/symbol.h: Include <stdint.h> for `uintptr_t`.

  (class symbol):
  (symbol::hash): Change return type from `unsigned long`, which causes
  build failures on 64-bit MinGW, to `uintptr_t`.

  (symbol::hash): Use a C++ type cast, not a C-style one.

Thanks to Bruno Haible for reporting the build failure in the 64-bit
MinGW environment, and for suggesting a remedy.

Also update editor aid comments; drop old style Emacs file-local
variable setting.

Any day you get to use the foot-Howitzer reinterpret_cast is a good one.

Commits since 0221b657fe tested on:
  Debian bullseye
  Debian sid 2023-03-06 chroot
  macOS 12
  OpenBSD 7.2
  Solaris 10
  Solaris 11

Inclusion order is not supposed to matter for standard C header files,
so treating this as a code style issue.

* src/devices/grodvi/dvi.cpp:
* src/devices/grolj4/lj4.cpp:
* src/include/stringclass.h:
* src/libs/libbib/linear.cpp:
* src/libs/libbib/search.cpp:
* src/libs/libdriver/printer.cpp:
* src/libs/libgroff/assert.cpp:
* src/libs/libgroff/color.cpp:
* src/libs/libgroff/errarg.cpp:
* src/libs/libgroff/font.cpp:
* src/libs/libgroff/nametoindex.cpp:
* src/libs/libgroff/prime.cpp:
* src/libs/libgroff/relocate.cpp:
* src/libs/libgroff/searchpath.cpp:
* src/preproc/eqn/box.cpp:
* src/preproc/eqn/delim.cpp:
* src/preproc/eqn/pile.cpp:
* src/preproc/eqn/script.cpp:
* src/preproc/html/pre-html.cpp:
* src/preproc/pic/pic.h:
* src/preproc/preconv/preconv.cpp:
* src/preproc/soelim/soelim.cpp:
* src/roff/groff/groff.cpp:
* src/roff/troff/troff.h:
* src/utils/hpftodit/hpftodit.cpp:
* src/utils/indxbib/indxbib.cpp:
* src/utils/lkbib/lkbib.cpp:
* src/utils/lookbib/lookbib.cpp:
* src/utils/tfmtodit/tfmtodit.cpp: Do it.

Switch to using system's assert.h header file.  It is futile to attempt
to preserve compatibility with ISO C90 systems by providing a bespoke
predicate-reporting assert() (a C99 feature) when gnulib, which we
require, itself demands C99.  This ensures that `static_assert` remains
defined so that gnulib can use it.  Thanks to Bruno Haible for the
consultation.

<https://lists.gnu.org/archive/html/groff/2023-02/msg00034.html>

* src/include/assert.h: Delete.

* src/devices/grodvi/dvi.cpp:
* src/devices/grolbp/lbp.cpp:
* src/devices/grolj4/lj4.cpp:
* src/include/itable.h:
* src/include/stringclass.h:
* src/libs/libbib/linear.cpp:
* src/libs/libbib/search.cpp:
* src/libs/libdriver/printer.cpp:
* src/libs/libgroff/assert.cpp:
* src/libs/libgroff/color.cpp:
* src/libs/libgroff/errarg.cpp:
* src/libs/libgroff/font.cpp:
* src/libs/libgroff/nametoindex.cpp:
* src/libs/libgroff/prime.cpp:
* src/libs/libgroff/relocate.cpp:
* src/libs/libgroff/searchpath.cpp:
* src/preproc/eqn/box.cpp:
* src/preproc/eqn/delim.cpp:
* src/preproc/eqn/pile.cpp:
* src/preproc/eqn/script.cpp:
* src/preproc/html/pre-html.cpp:
* src/preproc/pic/pic.h:
* src/preproc/preconv/preconv.cpp:
* src/preproc/soelim/soelim.cpp:
* src/roff/groff/groff.cpp:
* src/roff/troff/troff.h:
* src/utils/hpftodit/hpftodit.cpp:
* src/utils/indxbib/indxbib.cpp:
* src/utils/lkbib/lkbib.cpp:
* src/utils/lookbib/lookbib.cpp:
* src/utils/tfmtodit/tfmtodit.cpp: Respell "assert.h" inclusion with
  angle brackets instead of quotation marks.

Fixes <https://savannah.gnu.org/bugs/?63078>.

* ANNOUNCE: Update bug counts.

Tidy up #includes of the "assert.h" header, which we locally provide to
ensure a C99-conformant implementation.  Drop inclusion of header from
files that don't directly need it, add it where they do, and spell the
inclusion consistently with double quotes to cue the reader of its local
status.

* src/devices/grodvi/dvi.cpp:
* src/devices/grolj4/lj4.cpp:
* src/libs/libdriver/printer.cpp:
* src/preproc/eqn/box.cpp:
* src/preproc/eqn/delim.cpp:
* src/preproc/eqn/pile.cpp:
* src/preproc/eqn/script.cpp: Add inclusion.

* src/include/driver.h:
* src/libs/libgroff/fontfile.cpp:
* src/preproc/eqn/eqn.h:
* src/preproc/html/pushback.cpp:
* src/preproc/refer/refer.h:
* src/preproc/tbl/table.h:
* src/utils/addftinfo/addftinfo.cpp: Drop inclusion.

* src/include/itable.h:
* src/include/stringclass.h:
* src/libs/libbib/linear.cpp:
* src/libs/libbib/search.cpp:
* src/libs/libgroff/color.cpp:
* src/libs/libgroff/font.cpp:
* src/libs/libgroff/nametoindex.cpp:
* src/libs/libgroff/prime.cpp:
* src/libs/libgroff/searchpath.cpp:
* src/preproc/html/pre-html.cpp:
* src/preproc/preconv/preconv.cpp:
* src/preproc/soelim/soelim.cpp:
* src/utils/indxbib/indxbib.cpp:
* src/utils/lkbib/lkbib.cpp:
* src/utils/lookbib/lookbib.cpp: Respell inclusion.

Fixes <https://savannah.gnu.org/bugs/?63079>.  Thanks to Bjarni Ingi
Gislason for the report.

Also annotate our assert.h to indicate why it's there.

Also update editor aid comments and drop old style Emacs file-local
variable setting.

Boolify and rename internal library function from `invalid_input_char`
to `is_invalid_input_char`.

* src/include/lib.h: Do it.

* src/libs/libgroff/font.cpp (text_file::next_line):
* src/preproc/eqn/lex.cpp (file_input::read_line):
* src/preproc/eqn/main.cpp (read_line, main):
* src/preproc/pic/lex.cpp (file_input::read_line,
  simple_file_input::get, simple_file_input::peek):
* src/preproc/pic/main.cpp (top_input::get, top_input::peek, do_file):
* src/preproc/refer/command.cpp (input_stack::push_file):
* src/preproc/refer/refer.cpp (do_file, do_bib):
* src/roff/troff/env.cpp (environment::make_tag):
* src/roff/troff/input.cpp (file_iterator::fill, file_iterator::peek)
  (get_char_for_escape_parameter, transparent_translate, read_request)
  (asciify, input_char_description, read_string, transparent_file)
  (set_string): Update call sites.

[libgroff]: Update return type of `font::load_desc` function to enable
more informative diagnostics from callers.

* src/include/font.h (font::load_desc): Change return type from `bool`
  to `const char` pointer.
* src/libs/libgroff/font.cpp (font::load_desc): Return null pointer
  literal on failed `open()` or validation failures.  Return filespec on
  success.

* src/libs/libdriver/input.cpp (do_file):
* src/preproc/grn/main.cpp (getres):
* src/roff/groff/groff.cpp (main):
* src/roff/troff/input.cpp (main): Compare `font::load_desc()` return
  value to null pointer literal instead of treating it as a Boolean.

* src/roff/groff/groff.cpp (main): Report full filespec of troublesome
  "DESC" file when complainiing of missing "postpro" directive.

Migrate from "base line" to "baseline".  Also drop "baseline" from
injection in the midst of the "vertical spacing" term (which is defined
in terms of the baseline).

Add "baseline" and "vertical spacing" as terms in the at present
notional "Concepts" section of roff(7), which the page has long promised
but not yet delivered.

Also, it's silly to test even numbers > 2 for primality.  Stop.

* src/include/lib.h: Include `stdbool.h` since this header file is used
  for both C and C++ code.

* src/include/lib.h (is_prime):
* src/libs/libgroff/prime.cpp (is_prime): Boolify.  Return Boolean
  instead of integer literals and demote return type to `bool`.  Include
  `assert.h` and add assertion to reject mathematically offensive input.

* src/libs/libbib/index.cpp (index_search_item::read_common_words_file):
  Test only odd numbers for primality.
* src/utils/indxbib/indxbib.cpp (main): Same.  Since the number comes
  from user input, make it (a potential hash table size) odd first.

Also add editor aid comments.

* src/include/error.h: Drop parameter names from prototypes, in keeping
  with the Stroustrup-style C++ used in most of groff.

* src/include/error.h: Drop `extern` storage class from diagnostic
  function prototypes.

Also update editor aid comments; drop old style Emacs file-local
variable setting.