From 5e372b6ca2bc25c5c60027da6ddbe74e537887cb Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 6 Nov 2014 14:37:39 -0500 Subject: [dev.power64] gc: fix etype of strings The etype of references to strings was being incorrectly set to TINT32 on all platforms. Change it to TSTRING. It seems this doesn't matter for compilation, since x86 uses LEA instructions to load string addresses and arm and power64 disassemble the string into its constituent pieces (with the correct types), but it helps when debugging. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/170100043 --- src/cmd/5g/gobj.c | 2 +- src/cmd/6g/gobj.c | 2 +- src/cmd/8g/gobj.c | 2 +- src/cmd/9g/gobj.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cmd/5g/gobj.c b/src/cmd/5g/gobj.c index 5e988878f..65f731685 100644 --- a/src/cmd/5g/gobj.c +++ b/src/cmd/5g/gobj.c @@ -86,7 +86,7 @@ datagostring(Strlit *sval, Addr *a) sym = stringsym(sval->s, sval->len); a->type = D_OREG; a->name = D_EXTERN; - a->etype = TINT32; + a->etype = TSTRING; a->offset = 0; // header a->reg = NREG; a->sym = linksym(sym); diff --git a/src/cmd/6g/gobj.c b/src/cmd/6g/gobj.c index 04e837b13..dbb4ff62c 100644 --- a/src/cmd/6g/gobj.c +++ b/src/cmd/6g/gobj.c @@ -81,7 +81,7 @@ datagostring(Strlit *sval, Addr *a) a->sym = linksym(sym); a->node = sym->def; a->offset = 0; // header - a->etype = TINT32; + a->etype = TSTRING; } void diff --git a/src/cmd/8g/gobj.c b/src/cmd/8g/gobj.c index fa0605e6c..af287f702 100644 --- a/src/cmd/8g/gobj.c +++ b/src/cmd/8g/gobj.c @@ -81,7 +81,7 @@ datagostring(Strlit *sval, Addr *a) a->sym = linksym(sym); a->node = sym->def; a->offset = 0; // header - a->etype = TINT32; + a->etype = TSTRING; } void diff --git a/src/cmd/9g/gobj.c b/src/cmd/9g/gobj.c index fdd7606bc..3da55878a 100644 --- a/src/cmd/9g/gobj.c +++ b/src/cmd/9g/gobj.c @@ -89,7 +89,7 @@ datagostring(Strlit *sval, Addr *a) a->reg = NREG; a->node = sym->def; a->offset = 0; // header - a->etype = TINT32; + a->etype = TSTRING; } void -- cgit v1.2.1