<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/go.git/test, branch dev.garbage</title>
<subtitle>code.google.com: Obsolete (use go-git)
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/'/>
<entry>
<title>[dev.garbage] runtime: raise StackGuard limit for Windows (again)</title>
<updated>2014-12-06T00:50:09+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-12-06T00:50:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=f83565bc02ff8dbf9bb7d72a863f63c18361665d'/>
<id>f83565bc02ff8dbf9bb7d72a863f63c18361665d</id>
<content type='text'>
640 bytes ought to be enough for anybody.

We'll bring this back down before Go 1.5. That's issue 9214.

TBR=rlh
CC=golang-codereviews
https://codereview.appspot.com/188730043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
640 bytes ought to be enough for anybody.

We'll bring this back down before Go 1.5. That's issue 9214.

TBR=rlh
CC=golang-codereviews
https://codereview.appspot.com/188730043
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.garbage] all: merge dev.cc (493ad916c3b1) into dev.garbage</title>
<updated>2014-11-24T17:07:11+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-24T17:07:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=e5fc9ffb729e31c4eb0a6518e819e9fc70f14818'/>
<id>e5fc9ffb729e31c4eb0a6518e819e9fc70f14818</id>
<content type='text'>
TBR=austin
CC=golang-codereviews
https://codereview.appspot.com/179290043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
TBR=austin
CC=golang-codereviews
https://codereview.appspot.com/179290043
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.cc] all: merge default (e4ab8f908aac) into dev.cc</title>
<updated>2014-11-20T16:48:08+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-20T16:48:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=4a674f45d109048fcef7cd9f2b876e270625c8ed'/>
<id>4a674f45d109048fcef7cd9f2b876e270625c8ed</id>
<content type='text'>
TBR=austin
CC=golang-codereviews
https://codereview.appspot.com/179040044
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
TBR=austin
CC=golang-codereviews
https://codereview.appspot.com/179040044
</pre>
</div>
</content>
</entry>
<entry>
<title>runtime: fix sudog leak</title>
<updated>2014-11-16T21:44:45+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-16T21:44:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=ca1e131f589cad741fda16c17155e9225ec9ec04'/>
<id>ca1e131f589cad741fda16c17155e9225ec9ec04</id>
<content type='text'>
The SudoG used to sit on the stack, so it was cheap to allocated
and didn't need to be cleaned up when finished.

For the conversion to Go, we had to move sudog off the stack
for a few reasons, so we added a cache of recently used sudogs
to keep allocation cheap. But we didn't add any of the necessary
cleanup before adding a SudoG to the new cache, and so the cached
SudoGs had stale pointers inside them that have caused all sorts
of awful, hard to debug problems.

CL 155760043 made sure SudoG.elem is cleaned up.
CL 150520043 made sure SudoG.selectdone is cleaned up.

This CL makes sure SudoG.next, SudoG.prev, and SudoG.waitlink
are cleaned up. I should have done this when I did the other two
fields; instead I wasted a week tracking down a leak they caused.

A dangling SudoG.waitlink can point into a sudogcache list that
has been "forgotten" in order to let the GC collect it, but that
dangling .waitlink keeps the list from being collected.
And then the list holding the SudoG with the dangling waitlink
can find itself in the same situation, and so on. We end up
with lists of lists of unusable SudoGs that are still linked into
the object graph and never collected (given the right mix of
non-trivial selects and non-channel synchronization).

More details in golang.org/issue/9110.

Fixes issue 9110.

LGTM=r
R=r
CC=dvyukov, golang-codereviews, iant, khr
https://codereview.appspot.com/177870043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The SudoG used to sit on the stack, so it was cheap to allocated
and didn't need to be cleaned up when finished.

For the conversion to Go, we had to move sudog off the stack
for a few reasons, so we added a cache of recently used sudogs
to keep allocation cheap. But we didn't add any of the necessary
cleanup before adding a SudoG to the new cache, and so the cached
SudoGs had stale pointers inside them that have caused all sorts
of awful, hard to debug problems.

CL 155760043 made sure SudoG.elem is cleaned up.
CL 150520043 made sure SudoG.selectdone is cleaned up.

This CL makes sure SudoG.next, SudoG.prev, and SudoG.waitlink
are cleaned up. I should have done this when I did the other two
fields; instead I wasted a week tracking down a leak they caused.

A dangling SudoG.waitlink can point into a sudogcache list that
has been "forgotten" in order to let the GC collect it, but that
dangling .waitlink keeps the list from being collected.
And then the list holding the SudoG with the dangling waitlink
can find itself in the same situation, and so on. We end up
with lists of lists of unusable SudoGs that are still linked into
the object graph and never collected (given the right mix of
non-trivial selects and non-channel synchronization).

More details in golang.org/issue/9110.

Fixes issue 9110.

LGTM=r
R=r
CC=dvyukov, golang-codereviews, iant, khr
https://codereview.appspot.com/177870043
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.cc] all: merge dev.power64 (7667e41f3ced) into dev.cc</title>
<updated>2014-11-14T17:10:52+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-14T17:10:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=6b31cfd20257f4d7226d5c4e95c67ed9b48ab58c'/>
<id>6b31cfd20257f4d7226d5c4e95c67ed9b48ab58c</id>
<content type='text'>
This is to reduce the delta between dev.cc and dev.garbage to just garbage collector changes.

These are the files that had merge conflicts and have been edited by hand:
        malloc.go
        mem_linux.go
        mgc.go
        os1_linux.go
        proc1.go
        panic1.go
        runtime1.go

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/174180043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is to reduce the delta between dev.cc and dev.garbage to just garbage collector changes.

These are the files that had merge conflicts and have been edited by hand:
        malloc.go
        mem_linux.go
        mgc.go
        os1_linux.go
        proc1.go
        panic1.go
        runtime1.go

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/174180043
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.garbage] all: merge dev.power64 (7667e41f3ced) into dev.garbage</title>
<updated>2014-11-14T17:09:42+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-14T17:09:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=66fbfa707147ff58e13beed2d4a957a06bede869'/>
<id>66fbfa707147ff58e13beed2d4a957a06bede869</id>
<content type='text'>
Now the only difference between dev.cc and dev.garbage
is the runtime conversion on the one side and the
garbage collection on the other. They both have the
same set of changes from default and dev.power64.

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/172570043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now the only difference between dev.cc and dev.garbage
is the runtime conversion on the one side and the
garbage collection on the other. They both have the
same set of changes from default and dev.power64.

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/172570043
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.garbage] all: merge default (f38460037b72) into dev.garbage</title>
<updated>2014-11-14T16:37:54+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-14T16:37:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=f4110c2e9cc8f316e14f3a4a35789bc821b326bf'/>
<id>f4110c2e9cc8f316e14f3a4a35789bc821b326bf</id>
<content type='text'>
This is the revision that dev.cc is branched from.

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/169590043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is the revision that dev.cc is branched from.

LGTM=austin
R=austin
CC=golang-codereviews
https://codereview.appspot.com/169590043
</pre>
</div>
</content>
</entry>
<entry>
<title>test: fix nacl build</title>
<updated>2014-11-10T02:10:49+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-10T02:10:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=78d351d121615f1101f28f88920029f20884c689'/>
<id>78d351d121615f1101f28f88920029f20884c689</id>
<content type='text'>
Disable linkx_run.go and sinit_run.go, because they
exec subprocesses, which NaCl cannot.

TBR=r
CC=golang-codereviews
https://codereview.appspot.com/171350043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Disable linkx_run.go and sinit_run.go, because they
exec subprocesses, which NaCl cannot.

TBR=r
CC=golang-codereviews
https://codereview.appspot.com/171350043
</pre>
</div>
</content>
</entry>
<entry>
<title>test: move linkx and sinit to run.go</title>
<updated>2014-11-06T20:14:08+00:00</updated>
<author>
<name>Josh Bleecher Snyder</name>
<email>josharian@gmail.com</email>
</author>
<published>2014-11-06T20:14:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=352fa16f7b273709aa31813cc85a191e5dae560e'/>
<id>352fa16f7b273709aa31813cc85a191e5dae560e</id>
<content type='text'>
The remaining run-only tests will be migrated to run.go in another CL.

This CL will break the build due to issues 8746 and 8806.

Update issue 4139
Update issue 8746
Update issue 8806

LGTM=rsc
R=rsc, bradfitz, iant
CC=golang-codereviews
https://codereview.appspot.com/144630044

Committer: Russ Cox &lt;rsc@golang.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The remaining run-only tests will be migrated to run.go in another CL.

This CL will break the build due to issues 8746 and 8806.

Update issue 4139
Update issue 8746
Update issue 8806

LGTM=rsc
R=rsc, bradfitz, iant
CC=golang-codereviews
https://codereview.appspot.com/144630044

Committer: Russ Cox &lt;rsc@golang.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.garbage] cmd/gc, runtime: add locks around print statements</title>
<updated>2014-11-05T19:42:54+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-11-05T19:42:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=aefaeb75f3eff323f212c5309d8ae65768ad9809'/>
<id>aefaeb75f3eff323f212c5309d8ae65768ad9809</id>
<content type='text'>
Now each C printf, Go print, or Go println is guaranteed
not to be interleaved with other calls of those functions.
This should help when debugging concurrent failures.

LGTM=rlh
R=rlh
CC=golang-codereviews
https://codereview.appspot.com/169120043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Now each C printf, Go print, or Go println is guaranteed
not to be interleaved with other calls of those functions.
This should help when debugging concurrent failures.

LGTM=rlh
R=rlh
CC=golang-codereviews
https://codereview.appspot.com/169120043
</pre>
</div>
</content>
</entry>
</feed>
