delta/go.git/test/stringrange.go, branch dev.garbage code.google.com: Obsolete (use go-git) all: make Unicode surrogate halves illegal as UTF-8 2012-08-08T21:01:23+00:00 Rob Pike r@golang.org 2012-08-08T21:01:23+00:00 22a47ed4d57e86ffa664ecb5a8d3af2f817ac806 Surrogate halves are part of UTF-16 and should never appear in UTF-8. (The rune that two combined halves represent in UTF-16 should be encoded directly.) Encoding: encode as RuneError. Decoding: convert to RuneError, consume one byte. This requires changing: package unicode/utf8 runtime for range over string Also added utf8.ValidRune and fixed bug in utf.RuneLen. Fixes issue 3927. R=golang-dev, rsc, bsiegert CC=golang-dev http://codereview.appspot.com/6458099 
Surrogate halves are part of UTF-16 and should never appear in UTF-8.
(The rune that two combined halves represent in UTF-16 should
be encoded directly.)

Encoding: encode as RuneError.
Decoding: convert to RuneError, consume one byte.

This requires changing:
        package unicode/utf8
        runtime for range over string
Also added utf8.ValidRune and fixed bug in utf.RuneLen.

Fixes issue 3927.

R=golang-dev, rsc, bsiegert
CC=golang-dev
http://codereview.appspot.com/6458099
test/[n-z]*.go: add documentation 2012-02-24T00:48:19+00:00 Rob Pike r@golang.org 2012-02-24T00:48:19+00:00 2b2a8fe77447a7549a4114f2071032e1987a49a3 R=golang-dev, bradfitz, r CC=golang-dev http://codereview.appspot.com/5700056 
R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5700056
test: use testlib (final 61) 2012-02-17T04:51:04+00:00 Russ Cox rsc@golang.org 2012-02-17T04:51:04+00:00 7021b86f26b27de2f15519ccf60becfed8599a03 X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5671080 
X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5671080
renaming_4: gofix -r everything/but/src/pkg 2011-11-08T23:43:02+00:00 Rob Pike r@golang.org 2011-11-08T23:43:02+00:00 0f11cfc61b07dc4959bacf613ddfc4704d8c75f0 R=rsc CC=golang-dev http://codereview.appspot.com/5338043 
R=rsc
CC=golang-dev
http://codereview.appspot.com/5338043
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune 2011-10-26T05:20:02+00:00 Russ Cox rsc@golang.org 2011-10-26T05:20:02+00:00 a2a0c70a8b83096f346908dc85e6f269def667ac Nothing terribly interesting here. R=golang-dev, bradfitz, gri, r CC=golang-dev http://codereview.appspot.com/5300043 
Nothing terribly interesting here.

R=golang-dev, bradfitz, gri, r
CC=golang-dev
http://codereview.appspot.com/5300043
test: remove semiocolons. 2010-09-04T00:36:13+00:00 Rob Pike r@golang.org 2010-09-04T00:36:13+00:00 7c2e17b3e6e4c36a3713e272653dcfc9c2056cfd The ken directory is untouched so we have some examples with explicit semis. R=gri CC=golang-dev http://codereview.appspot.com/2157041 
The ken directory is untouched so we have some examples with explicit semis.

R=gri
CC=golang-dev
http://codereview.appspot.com/2157041
fix "declared and not used" in tests; 2009-09-15T04:03:53+00:00 Russ Cox rsc@golang.org 2009-09-15T04:03:53+00:00 298e8e3680bee2280342a991cf8d71cb3df8ef59 also template/template.go, missed last time. R=r DELTA=116 (61 added, 10 deleted, 45 changed) OCL=34620 CL=34622 
also template/template.go, missed last time.

R=r
DELTA=116  (61 added, 10 deleted, 45 changed)
OCL=34620
CL=34622
fix up some irregular indentation 2009-08-17T20:30:22+00:00 Rob Pike r@golang.org 2009-08-17T20:30:22+00:00 dc7bf11e534b92ce21630d07d0dc88096d7fb6f7 R=rsc OCL=33382 CL=33391 
R=rsc
OCL=33382
CL=33391
change utf8.FullRuneInString and utf8.DecodeRuneInString 2009-05-11T21:10:34+00:00 Russ Cox rsc@golang.org 2009-05-11T21:10:34+00:00 31d0bd55451bc4b242e5c58886605eee1de8680d to use single string argument instead of string, index. R=r DELTA=136 (9 added, 7 deleted, 120 changed) OCL=28642 CL=28644 
to use single string argument instead of string, index.

R=r
DELTA=136  (9 added, 7 deleted, 120 changed)
OCL=28642
CL=28644
move things out of sys into os and runtime 2009-05-08T22:21:41+00:00 Russ Cox rsc@golang.org 2009-05-08T22:21:41+00:00 dfa70aacecca54bcd2d60156f99dc7b4f20fdd8a R=r OCL=28569 CL=28573 
R=r
OCL=28569
CL=28573