delta/go.git/test/interface/explicit.go, branch dev.garbage code.google.com: Obsolete (use go-git) cmd/gc: blank methods are not permitted in interface types 2014-10-15T16:55:13+00:00 Chris Manghane cmang@golang.org 2014-10-15T16:55:13+00:00 a5906fdac49996df7009c1ab4c60683df9e1469f Fixes issue 6606. LGTM=rsc R=rsc CC=golang-codereviews, gri https://codereview.appspot.com/156210044 
Fixes issue 6606.

LGTM=rsc
R=rsc
CC=golang-codereviews, gri
https://codereview.appspot.com/156210044
cmd/gc: don't attempt to generate wrappers for blank interface methods 2013-08-19T01:53:34+00:00 Anthony Martin ality@pbrane.org 2013-08-19T01:53:34+00:00 4ee13979d7c6235a71d84d88494f24a83e3a90e9 Fixes issue 5691. R=golang-dev, bradfitz, daniel.morsing, rsc CC=golang-dev https://codereview.appspot.com/10255047 Committer: Rob Pike <r@golang.org> 
Fixes issue 5691.

R=golang-dev, bradfitz, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/10255047

Committer: Rob Pike <r@golang.org>
cmd/gc: Suggest *T in error for x.(T) if it would work. 2012-09-01T17:52:55+00:00 Daniel Morsing daniel.morsing@gmail.com 2012-09-01T17:52:55+00:00 45d9d257565d4f4324a460941cf8d43f1c9244a7 Accomplished by synchronizing the formatting of conversion errors between typecheck.c and subr.c Fixes issue 3984. R=golang-dev, remyoudompheng, rsc CC=golang-dev http://codereview.appspot.com/6500064 Committer: Russ Cox <rsc@golang.org> 
Accomplished by synchronizing the formatting of conversion errors between typecheck.c and subr.c

Fixes issue 3984.

R=golang-dev, remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6500064

Committer: Russ Cox <rsc@golang.org>
cmd/gc: Don't claim type assertion would help when it wont. 2012-08-15T23:53:06+00:00 Daniel Morsing daniel.morsing@gmail.com 2012-08-15T23:53:06+00:00 dfb074d49212b4d0ccbe27afc59355873a401bd1 Fixes issue 3465. R=golang-dev, rsc, remyoudompheng, iant CC=golang-dev http://codereview.appspot.com/6448097 Committer: Ian Lance Taylor <iant@golang.org> 
Fixes issue 3465.

R=golang-dev, rsc, remyoudompheng, iant
CC=golang-dev
http://codereview.appspot.com/6448097

Committer: Ian Lance Taylor <iant@golang.org>
test/interface: document tests 2012-02-19T06:33:41+00:00 Rob Pike r@golang.org 2012-02-19T06:33:41+00:00 7daf4ad9d1df5ba715f327270b6ed7f0ce339bdb Most already had comments (yay); adjusted for consistency. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5676102 
Most already had comments (yay); adjusted for consistency.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5676102
test: use testlib (fourth 100) 2012-02-17T04:50:37+00:00 Russ Cox rsc@golang.org 2012-02-17T04:50:37+00:00 919bacb81724be250e3841d23e0cfce20c9c5429 X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5673079 
X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5673079
errchk: allow multiple patterns 2011-08-16T15:14:26+00:00 Russ Cox rsc@golang.org 2011-08-16T15:14:26+00:00 7a251687c029ee915573f767f57ab17372b3c134 // ERROR "pattern1" "pattern2" means that there has to be one or more lines matching pattern1 and then excluding those, there have to be one or more lines matching pattern2. So if you expect two different error messages from a particular line, writing two separate patterns checks that both errors are produced. Also, errchk now flags lines that produce more errors than expected. Before, as long as at least one error matched the pattern, all the others were ignored. Revise tests to expect or silence these additional errors. R=lvd, r, iant CC=golang-dev http://codereview.appspot.com/4869044 
// ERROR "pattern1" "pattern2"

means that there has to be one or more
lines matching pattern1 and then excluding
those, there have to be one or more lines
matching pattern2.  So if you expect two
different error messages from a particular
line, writing two separate patterns checks
that both errors are produced.

Also, errchk now flags lines that produce
more errors than expected.  Before, as long as
at least one error matched the pattern, all the
others were ignored.

Revise tests to expect or silence these
additional errors.

R=lvd, r, iant
CC=golang-dev
http://codereview.appspot.com/4869044
delete float, complex - code changes 2011-01-20T04:09:00+00:00 Russ Cox rsc@golang.org 2011-01-20T04:09:00+00:00 ed3592f95664c555d787d87b28ff783b846257e6 also: cmplx -> complex float64(1.0) -> 1.0 float64(1) -> 1.0 R=gri, r, gri1, r2 CC=golang-dev http://codereview.appspot.com/3991043 
also:
	cmplx -> complex
	float64(1.0) -> 1.0
	float64(1) -> 1.0

R=gri, r, gri1, r2
CC=golang-dev
http://codereview.appspot.com/3991043
test: Match gccgo error messages. 2010-09-09T04:03:24+00:00 Ian Lance Taylor iant@golang.org 2010-09-09T04:03:24+00:00 19c1be2efb7c2f055033192c18ba3f3d8e33d09c explicit.go:36:4: error: incompatible types in assignment (need explicit conversion) explicit.go:41:4: error: incompatible types in assignment (type has no methods) explicit.go:42:4: error: incompatible types in assignment (need explicit conversion) explicit.go:45:5: error: incompatible types in assignment (need explicit conversion; missing method ?N?) explicit.go:48:9: error: invalid type conversion (need explicit conversion; missing method ?N?) explicit.go:51:4: error: incompatible types in assignment explicit.go:51:7: error: invalid type conversion (need explicit conversion) explicit.go:57:10: error: impossible type assertion: type does not implement interface (type has no methods) explicit.go:62:10: error: impossible type assertion: type does not implement interface (incompatible type for method ?M? (different number of parameters)) explicit.go:67:5: error: incompatible type in initialization (type has no methods) explicit.go:68:5: error: incompatible type in initialization (incompatible type for method ?M? (different number of parameters)) explicit.go:70:11: error: invalid type conversion (type has no methods) explicit.go:71:11: error: invalid type conversion (incompatible type for method ?M? (different number of parameters)) R=rsc CC=golang-dev http://codereview.appspot.com/2139044 
explicit.go:36:4: error: incompatible types in assignment (need explicit conversion)
explicit.go:41:4: error: incompatible types in assignment (type has no methods)
explicit.go:42:4: error: incompatible types in assignment (need explicit conversion)
explicit.go:45:5: error: incompatible types in assignment (need explicit conversion; missing method ?N?)
explicit.go:48:9: error: invalid type conversion (need explicit conversion; missing method ?N?)
explicit.go:51:4: error: incompatible types in assignment
explicit.go:51:7: error: invalid type conversion (need explicit conversion)
explicit.go:57:10: error: impossible type assertion: type does not implement interface (type has no methods)
explicit.go:62:10: error: impossible type assertion: type does not implement interface (incompatible type for method ?M? (different number of parameters))
explicit.go:67:5: error: incompatible type in initialization (type has no methods)
explicit.go:68:5: error: incompatible type in initialization (incompatible type for method ?M? (different number of parameters))
explicit.go:70:11: error: invalid type conversion (type has no methods)
explicit.go:71:11: error: invalid type conversion (incompatible type for method ?M? (different number of parameters))

R=rsc
CC=golang-dev
http://codereview.appspot.com/2139044
gc: more cleanup 2010-06-09T18:00:55+00:00 Russ Cox rsc@golang.org 2010-06-09T18:00:55+00:00 590369866a6d10e4ed036dcb256cbac90faefff7 * disallow surrogate pair runes. * diagnose impossible type assertions * eliminate another static buffer. * do not overflow lexbuf. * add -u flag to disable package unsafe. R=ken2 CC=golang-dev http://codereview.appspot.com/1619042 
 * disallow surrogate pair runes.
 * diagnose impossible type assertions
 * eliminate another static buffer.
 * do not overflow lexbuf.
 * add -u flag to disable package unsafe.

R=ken2
CC=golang-dev
http://codereview.appspot.com/1619042