<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/go.git, branch dev.cc</title>
<subtitle>code.google.com: Obsolete (use go-git)
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/'/>
<entry>
<title>[dev.cc] all: merge default (8d42099cdc23) into dev.cc</title>
<updated>2014-12-05T16:18:10+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-12-05T16:18:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=6d3ba1914e289ed223f7bb69f34604c0e2ae5384'/>
<id>6d3ba1914e289ed223f7bb69f34604c0e2ae5384</id>
<content type='text'>
TBR=austin
CC=golang-codereviews
https://codereview.appspot.com/178700044
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
TBR=austin
CC=golang-codereviews
https://codereview.appspot.com/178700044
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.cc] liblink: don't patch jumps to jumps to symbols</title>
<updated>2014-12-05T14:24:01+00:00</updated>
<author>
<name>Austin Clements</name>
<email>austin@google.com</email>
</author>
<published>2014-12-05T14:24:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=d39e7f8f9d8d330acbcfeba7e8e254b131b05f39'/>
<id>d39e7f8f9d8d330acbcfeba7e8e254b131b05f39</id>
<content type='text'>
When liblink sees something like

       JMP x
       ...
    x: JMP y

it rewrites the first jump to jump directly to y.  This is
fine if y is a resolved label.  However, it *also* does this
if y is a function symbol, but fails to carry over the
relocation that would later patch in that symbol's value.  As
a result, the original jump becomes either a self-jump (if
relative) or a jump to PC 0 (if absolute).

Fix this by disabling this optimization if the jump being
patched in is a jump to a symbol.

LGTM=minux
R=rsc, minux
CC=golang-codereviews
https://codereview.appspot.com/185890044
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When liblink sees something like

       JMP x
       ...
    x: JMP y

it rewrites the first jump to jump directly to y.  This is
fine if y is a resolved label.  However, it *also* does this
if y is a function symbol, but fails to carry over the
relocation that would later patch in that symbol's value.  As
a result, the original jump becomes either a self-jump (if
relative) or a jump to PC 0 (if absolute).

Fix this by disabling this optimization if the jump being
patched in is a jump to a symbol.

LGTM=minux
R=rsc, minux
CC=golang-codereviews
https://codereview.appspot.com/185890044
</pre>
</div>
</content>
</entry>
<entry>
<title>[dev.cc] cmd/ld: finalize linkmode before determining whether to import runtime/cgo</title>
<updated>2014-12-05T07:22:20+00:00</updated>
<author>
<name>Shenghou Ma</name>
<email>minux@golang.org</email>
</author>
<published>2014-12-05T07:22:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=57231fa56130b0863b592dc8fda71cf87c947c74'/>
<id>57231fa56130b0863b592dc8fda71cf87c947c74</id>
<content type='text'>
Frankly, I don't understand how the current code could possibly work except
when every android program is using cgo. Discovered this while working on
the iOS port.

LGTM=crawshaw, rsc
R=rsc, crawshaw
CC=golang-codereviews
https://codereview.appspot.com/177470043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Frankly, I don't understand how the current code could possibly work except
when every android program is using cgo. Discovered this while working on
the iOS port.

LGTM=crawshaw, rsc
R=rsc, crawshaw
CC=golang-codereviews
https://codereview.appspot.com/177470043
</pre>
</div>
</content>
</entry>
<entry>
<title>cmd/go: fix build</title>
<updated>2014-12-05T00:37:56+00:00</updated>
<author>
<name>Rob Pike</name>
<email>r@golang.org</email>
</author>
<published>2014-12-05T00:37:56+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=3ebebda3a7495402239db4369d59d73749c1bfa2'/>
<id>3ebebda3a7495402239db4369d59d73749c1bfa2</id>
<content type='text'>
The new semantics of split require the newline be present.
The test was stale.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://codereview.appspot.com/182480043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The new semantics of split require the newline be present.
The test was stale.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://codereview.appspot.com/182480043
</pre>
</div>
</content>
</entry>
<entry>
<title>cmd/go: avoid use of bufio.Scanner in generate</title>
<updated>2014-12-05T00:15:38+00:00</updated>
<author>
<name>Rob Pike</name>
<email>r@golang.org</email>
</author>
<published>2014-12-05T00:15:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=5223a2c9fbc6a2633a77586dbfec379e584c779e'/>
<id>5223a2c9fbc6a2633a77586dbfec379e584c779e</id>
<content type='text'>
Scanner can't handle stupid long lines and there are
reports of stupid long lines in production.

Note the issue isn't long "//go:generate" lines, but
any long line in any Go source file.

To be fair, if you're going to have a stupid long line
it's not a bad bet you'll want to run it through go
generate, because it's some embeddable asset that
has been machine generated. (One could ask why
that generation process didn't add a newline or two,
but we should cope anyway.)

Rewrite the file scanner in "go generate" so it can
handle arbitrarily long lines, and only stores in memory
those lines that start "//go:generate".

Also: Adjust the documentation to make clear that it
does not parse the file.

Fixes issue 9143.
Fixes issue 9196.

LGTM=rsc, dominik.honnef
R=rsc, cespare, minux, dominik.honnef
CC=golang-codereviews
https://codereview.appspot.com/182970043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Scanner can't handle stupid long lines and there are
reports of stupid long lines in production.

Note the issue isn't long "//go:generate" lines, but
any long line in any Go source file.

To be fair, if you're going to have a stupid long line
it's not a bad bet you'll want to run it through go
generate, because it's some embeddable asset that
has been machine generated. (One could ask why
that generation process didn't add a newline or two,
but we should cope anyway.)

Rewrite the file scanner in "go generate" so it can
handle arbitrarily long lines, and only stores in memory
those lines that start "//go:generate".

Also: Adjust the documentation to make clear that it
does not parse the file.

Fixes issue 9143.
Fixes issue 9196.

LGTM=rsc, dominik.honnef
R=rsc, cespare, minux, dominik.honnef
CC=golang-codereviews
https://codereview.appspot.com/182970043
</pre>
</div>
</content>
</entry>
<entry>
<title>cmd/pprof/internal/commands: add command to open browser on windows</title>
<updated>2014-12-04T16:24:23+00:00</updated>
<author>
<name>Shenghou Ma</name>
<email>minux@golang.org</email>
</author>
<published>2014-12-04T16:24:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=8208a8b2f9a29cabb4dff8aff17fbb739b6e8471'/>
<id>8208a8b2f9a29cabb4dff8aff17fbb739b6e8471</id>
<content type='text'>
While we're at there, also add a message to prompt the user to install
Graphviz if "dot" command is not found.

Fixes issue 9178.

LGTM=adg, alex.brainman, cookieo9, rsc
R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman
CC=golang-codereviews
https://codereview.appspot.com/180380043

Committer: Russ Cox &lt;rsc@golang.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
While we're at there, also add a message to prompt the user to install
Graphviz if "dot" command is not found.

Fixes issue 9178.

LGTM=adg, alex.brainman, cookieo9, rsc
R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman
CC=golang-codereviews
https://codereview.appspot.com/180380043

Committer: Russ Cox &lt;rsc@golang.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib/time: update to ICANN time zone database 2014j</title>
<updated>2014-12-04T04:07:48+00:00</updated>
<author>
<name>Rob Pike</name>
<email>r@golang.org</email>
</author>
<published>2014-12-04T04:07:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=00e1a8acf51edb67cd3abc678f4b0bb6b5fe7fd5'/>
<id>00e1a8acf51edb67cd3abc678f4b0bb6b5fe7fd5</id>
<content type='text'>
Fixes issue 9189.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/178660043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes issue 9189.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/178660043
</pre>
</div>
</content>
</entry>
<entry>
<title>spec: add comment marker for consistency.</title>
<updated>2014-12-03T22:29:29+00:00</updated>
<author>
<name>David Symonds</name>
<email>dsymonds@golang.org</email>
</author>
<published>2014-12-03T22:29:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=8f0f9d447fd3028e4f4cf890a577c00eaaacdc65'/>
<id>8f0f9d447fd3028e4f4cf890a577c00eaaacdc65</id>
<content type='text'>
LGTM=r
R=gri, r
CC=golang-codereviews
https://codereview.appspot.com/185830043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
LGTM=r
R=gri, r
CC=golang-codereviews
https://codereview.appspot.com/185830043
</pre>
</div>
</content>
</entry>
<entry>
<title>cmd/pprof: fix symbol resolution for remote profiles</title>
<updated>2014-12-03T19:14:00+00:00</updated>
<author>
<name>Russ Cox</name>
<email>rsc@golang.org</email>
</author>
<published>2014-12-03T19:14:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=18b416bab75c23aa867bee5a31075d78bb428502'/>
<id>18b416bab75c23aa867bee5a31075d78bb428502</id>
<content type='text'>
Fixes issue 9199.

LGTM=iant
R=golang-codereviews, iant
CC=austin, golang-codereviews, minux
https://codereview.appspot.com/183080043
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes issue 9199.

LGTM=iant
R=golang-codereviews, iant
CC=austin, golang-codereviews, minux
https://codereview.appspot.com/183080043
</pre>
</div>
</content>
</entry>
<entry>
<title>cmd/go: regenerate doc.go</title>
<updated>2014-12-02T23:28:54+00:00</updated>
<author>
<name>Dominik Honnef</name>
<email>dominik.honnef@gmail.com</email>
</author>
<published>2014-12-02T23:28:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/go.git/commit/?id=3b2bc49486d98ef1eb104dfbc2f82dd20f05f7b3'/>
<id>3b2bc49486d98ef1eb104dfbc2f82dd20f05f7b3</id>
<content type='text'>
Move change from CL 170770043 to correct file and regenerate docs
for changes from CL 164120043.

LGTM=adg
R=golang-codereviews, adg, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/183000043

Committer: Andrew Gerrand &lt;adg@golang.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move change from CL 170770043 to correct file and regenerate docs
for changes from CL 164120043.

LGTM=adg
R=golang-codereviews, adg, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/183000043

Committer: Andrew Gerrand &lt;adg@golang.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
