From 71ab9fa312f8266379dbb358b9ee9303cde7bd6b Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Mon, 11 Jul 2016 16:05:57 -0700 Subject: all: fix assembly vet issues Add missing function prototypes. Fix function prototypes. Use FP references instead of SP references. Fix variable names. Update comments. Clean up whitespace. (Not for vet.) All fairly minor fixes to make vet happy. Updates #11041 Change-Id: Ifab2cdf235ff61cdc226ab1d84b8467b5ac9446c Reviewed-on: https://go-review.googlesource.com/27713 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/runtime/asm_arm.s | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'src/runtime/asm_arm.s') diff --git a/src/runtime/asm_arm.s b/src/runtime/asm_arm.s index f02297e8f0..59a0e75734 100644 --- a/src/runtime/asm_arm.s +++ b/src/runtime/asm_arm.s @@ -855,13 +855,13 @@ samebytes: // See runtime_test.go:eqstring_generic for // equivalent Go code. TEXT runtime·eqstring(SB),NOSPLIT,$-4-17 - MOVW s1str+0(FP), R2 - MOVW s2str+8(FP), R3 + MOVW s1_base+0(FP), R2 + MOVW s2_base+8(FP), R3 MOVW $1, R8 - MOVB R8, v+16(FP) + MOVB R8, ret+16(FP) CMP R2, R3 RET.EQ - MOVW s1len+4(FP), R0 + MOVW s1_len+4(FP), R0 ADD R2, R0, R6 loop: CMP R2, R6 @@ -871,7 +871,7 @@ loop: CMP R4, R5 BEQ loop MOVW $0, R8 - MOVB R8, v+16(FP) + MOVB R8, ret+16(FP) RET // TODO: share code with memequal? @@ -1033,8 +1033,8 @@ TEXT runtime·usplitR0(SB),NOSPLIT,$0 SUB R1, R3, R1 RET -TEXT runtime·sigreturn(SB),NOSPLIT,$0-4 - RET +TEXT runtime·sigreturn(SB),NOSPLIT,$0-0 + RET #ifndef GOOS_nacl // This is called from .init_array and follows the platform, not Go, ABI. -- cgit v1.2.1