From d96e584773bf0577a4da2ffc9543111ddd80627c Mon Sep 17 00:00:00 2001 From: Michael Anthony Knyszek Date: Fri, 11 Nov 2022 17:26:45 +0000 Subject: [release-branch.go1.18] net: disable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV These tests fail consistently due to a DNS change causing widespread trybot outages. For #56707. Fixes #56709. Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7 Reviewed-on: https://go-review.googlesource.com/c/go/+/449640 Reviewed-by: Carlos Amedee Reviewed-by: Bryan Mills Run-TryBot: Michael Knyszek TryBot-Result: Gopher Robot Reviewed-by: Damien Neil (cherry picked from commit 97765249082b6835c77517a4e63bb38cfd6db97b) Reviewed-on: https://go-review.googlesource.com/c/go/+/449505 Reviewed-by: Ian Lance Taylor --- src/net/lookup_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go index 3a31f56bea..655543c7d2 100644 --- a/src/net/lookup_test.go +++ b/src/net/lookup_test.go @@ -71,6 +71,10 @@ var lookupGoogleSRVTests = []struct { var backoffDuration = [...]time.Duration{time.Second, 5 * time.Second, 30 * time.Second} func TestLookupGoogleSRV(t *testing.T) { + // TODO(mknyszek): Figure out next steps for this test. This is just + // a quick fix. + t.Skip("fails consistently due to an upstream DNS change; see #56707.") + t.Parallel() mustHaveExternalNetwork(t) @@ -631,6 +635,10 @@ func TestLookupDotsWithLocalSource(t *testing.T) { } func TestLookupDotsWithRemoteSource(t *testing.T) { + // TODO(mknyszek): Figure out next steps for this test. This is just + // a quick fix. + t.Skip("fails consistently due to an upstream DNS change; see #56707.") + if runtime.GOOS == "darwin" || runtime.GOOS == "ios" { testenv.SkipFlaky(t, 27992) } -- cgit v1.2.1