delta/go-git.git/test/cmp.go, branch dev.typeparams github.com: golang/go Fix several out of date references to 4g/5g/6g/8g/9g. 2015-06-26T03:38:21+00:00 Aaron Jacobs jacobsa@google.com 2015-06-23T23:50:12+00:00 86286883047d75df7769bff42ba2364b9bcee6fd Change-Id: Ifb8e4e13c7778a7c0113190051415e096f5db94f Reviewed-on: https://go-review.googlesource.com/11390 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org> 
Change-Id: Ifb8e4e13c7778a7c0113190051415e096f5db94f
Reviewed-on: https://go-review.googlesource.com/11390
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Andrew Gerrand <adg@golang.org>
cmd/gc: do not nop-convert equivalent but different interface types. 2014-02-27T07:07:50+00:00 Rémy Oudompheng oudomphe@phare.normalesup.org 2014-02-27T07:07:50+00:00 e5f01aee04dc6313c85dab78305adf499e1f7bfa The cached computed interface tables are indexed by the interface types, not by the unnamed underlying interfaces To preserve the invariants expected by interface comparison, an itab generated for an interface type must not be used for a value of a different interface type even if the representation is identical. Fixes #7207. LGTM=rsc R=rsc, iant, khr CC=golang-codereviews https://golang.org/cl/69210044 
The cached computed interface tables are indexed by the interface
types, not by the unnamed underlying interfaces

To preserve the invariants expected by interface comparison, an
itab generated for an interface type must not be used for a value
of a different interface type even if the representation is identical.

Fixes #7207.

LGTM=rsc
R=rsc, iant, khr
CC=golang-codereviews
https://golang.org/cl/69210044
cmd/gc: fix walkcompare bugs. 2014-02-24T18:51:59+00:00 Rémy Oudompheng oudomphe@phare.normalesup.org 2014-02-24T18:51:59+00:00 14b0af4272aa6c638e97cb3364a81962d69dbfc6 Revision c0e0467635ec (cmd/gc: return canonical Node* from temp) exposed original nodes of temporaries, allowing callers to mutate their types. In walkcompare a temporary could be typed as ideal because of this. Additionnally, assignment of a comparison result to a custom boolean type was broken. Fixes #7366. LGTM=rsc R=rsc, iant, khr CC=golang-codereviews https://golang.org/cl/66930044 
Revision c0e0467635ec (cmd/gc: return canonical Node* from temp)
exposed original nodes of temporaries, allowing callers to mutate
their types.

In walkcompare a temporary could be typed as ideal because of
this. Additionnally, assignment of a comparison result to
a custom boolean type was broken.

Fixes #7366.

LGTM=rsc
R=rsc, iant, khr
CC=golang-codereviews
https://golang.org/cl/66930044
test: invert incorrect condition. 2013-07-16T16:18:00+00:00 Alan Donovan adonovan@google.com 2013-07-16T16:18:00+00:00 8fb6c3ac25f077f5207215dc4868014a29e61759 R=gri CC=golang-dev https://golang.org/cl/11359043 
R=gri
CC=golang-dev
https://golang.org/cl/11359043
cmd/gc: fix computation of equality class of types. 2013-07-02T07:08:43+00:00 Rémy Oudompheng oudomphe@phare.normalesup.org 2013-07-02T07:08:43+00:00 428ea6865c7eff6d8632faa18335c64d4ae9f422 A struct with a single field was considered as equivalent to the field type, which is incorrect is the field is blank. Fields with padding could make the compiler think some types are comparable when they are not. Fixes #5698. R=rsc, golang-dev, daniel.morsing, bradfitz, gri, r CC=golang-dev https://golang.org/cl/10271046 
A struct with a single field was considered as equivalent to the
field type, which is incorrect is the field is blank.

Fields with padding could make the compiler think some
types are comparable when they are not.

Fixes #5698.

R=rsc, golang-dev, daniel.morsing, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/10271046
exp/ssa/interp: (#6 of 5): test interpretation of SSA form of $GOROOT/test/*.go. 2013-02-21T17:48:38+00:00 Alan Donovan adonovan@google.com 2013-02-21T17:48:38+00:00 aa5aaabb0d18d21d97e9c98d7dfde4899a498335 The interpreter's os.Exit now triggers a special panic rather than kill the test process. (It's semantically dubious, since it will run deferred routines.) Interpret now returns its exit code rather than calling os.Exit. Also: - disabled parts of a few $GOROOT/tests via os.Getenv("GOSSAINTERP"). - remove unnecessary 'slots' param to external functions; they are never closures. Most of the tests are disabled until go/types supports shifts. They can be reenabled if you patch this workaround: https://golang.org/cl/7312068 R=iant, bradfitz CC=golang-dev, gri https://golang.org/cl/7313062 
The interpreter's os.Exit now triggers a special panic rather
than kill the test process.  (It's semantically dubious, since
it will run deferred routines.)  Interpret now returns its
exit code rather than calling os.Exit.

Also:
- disabled parts of a few $GOROOT/tests via os.Getenv("GOSSAINTERP").
- remove unnecessary 'slots' param to external functions; they
  are never closures.

Most of the tests are disabled until go/types supports shifts.
They can be reenabled if you patch this workaround:
https://golang.org/cl/7312068

R=iant, bradfitz
CC=golang-dev, gri
https://golang.org/cl/7313062
test: [a-c]: add introductory comments to tests 2012-02-19T02:19:43+00:00 Rob Pike r@golang.org 2012-02-19T02:19:43+00:00 fc0dc040954b7a8479c978ff06fe6ea4219d1542 Very few of the compiler regression tests include a comment saying waht they do. Many are obvious, some are anything but. I've started with a-c in the top directory. More will follow once we agree on the approach, correctness, and thoroughness here. zerodivide.go sneaked in too. R=rsc, r CC=golang-dev https://golang.org/cl/5656100 
Very few of the compiler regression tests include a comment
saying waht they do. Many are obvious, some are anything but.
I've started with a-c in the top directory. More will follow once
we agree on the approach, correctness, and thoroughness here.
zerodivide.go sneaked in too.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5656100
cmd/gc: fix comparison of struct with _ field 2012-02-17T19:45:29+00:00 Russ Cox rsc@golang.org 2012-02-17T19:45:29+00:00 c4c92ebeb656d059f88a2164f6ca9b136ce9fbf9 Fixes #2989. R=ken2 CC=golang-dev https://golang.org/cl/5674091 
Fixes #2989.

R=ken2
CC=golang-dev
https://golang.org/cl/5674091
test: use testlib (first 100) 2012-02-17T04:48:57+00:00 Russ Cox rsc@golang.org 2012-02-17T04:48:57+00:00 0b477ef17e184117922428a5a5ef15ffab12590a X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5656082 
X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5656082
gc: inlining, allow empty bodies, fix _ arguments. 2011-12-15T16:50:59+00:00 Luuk van Dijk lvd@golang.org 2011-12-15T16:50:59+00:00 7e6890a670e676f8040e690c7dc1409d0972bf22 R=rsc CC=golang-dev https://golang.org/cl/5487077 
R=rsc
CC=golang-dev
https://golang.org/cl/5487077