delta/go-git.git/src, branch dev.types

[dev.types] all: merge master into dev.types

2020-09-11T18:23:34+00:00

Change-Id: Ia6964cb4e09153c15cc9c5b441373d1b3cb8f757

cmd/go: move repository resolution from internal/get to internal/vcs

2020-09-11T18:14:49+00:00

This is a refactoring intended to break the dependency from
internal/modfetch to internal/get. No change in functionality is intended.

Change-Id: If51aba7139cc0b62ecc9ba454c055c99e8f36f0f
Reviewed-on: https://go-review.googlesource.com/c/go/+/254364
Run-TryBot: Jay Conrod 
Reviewed-by: Bryan C. Mills 
Reviewed-by: Michael Matloob 
TryBot-Result: Gobot Gobot

cmd/go: move get.Insecure to cfg.Insecure to break dependency cycle

2020-09-11T18:14:42+00:00

Change-Id: If9c73ff5adc7e080a48ecc6b35ce40822193d66f
Reviewed-on: https://go-review.googlesource.com/c/go/+/254363
Run-TryBot: Jay Conrod 
Reviewed-by: Bryan C. Mills 
Reviewed-by: Michael Matloob 
TryBot-Result: Gobot Gobot

cmd/go: make 'go mod download' update go.sum after downloads are complete

2020-09-11T15:53:52+00:00

'go mod download' calls WriteGoMod once via modload.ListModules when
it loads the build list. This saves sums for go.mod files needed by
MVS, but the write occurs before any zip files are downloaded.

With this change, 'go mod download' calls WriteGoMod again (and thus,
modfetch.WriteGoSum) after downloading and verifying module zip files,
so the sums of the zip files will be saved, too.

Fixes #41341

Change-Id: I7d56754aa255256ed45fd93cb154c2e6ea5f45a9
Reviewed-on: https://go-review.googlesource.com/c/go/+/254357
Run-TryBot: Jay Conrod 
TryBot-Result: Gobot Gobot 
Reviewed-by: Bryan C. Mills

cmd/link: add a test to test RODATA is indeed read-only

2020-09-11T15:41:20+00:00

Updates #38830.

Change-Id: Ie1f6ccef40a773f038aac587dfc26bf70a1a8536
Reviewed-on: https://go-review.googlesource.com/c/go/+/253921
Run-TryBot: Cherry Zhang 
Reviewed-by: Than McIntosh 
TryBot-Result: Gobot Gobot

cmd/link: put read-only data in __DATA_CONST segment

2020-09-11T15:07:26+00:00

On darwin, we put read-only data in __TEXT segment on AMD64 in
exe (non-PIE) buildmode, and in __DATA on everywhere else. This
is not ideal: things in __DATA segment are not read-only, and
being mapped R/W may use more run-time resources.

In fact, newer darwin systems support a __DATA_CONST segment,
which the dynamic linker will map it read-only after applying
relocations. Use that.

Fixes #38830.

Change-Id: Ic281e6c6ca8ef5fec4bb7c5b71c50dd5393e78ae
Reviewed-on: https://go-review.googlesource.com/c/go/+/253919
Reviewed-by: Than McIntosh

cmd/internal/objfile: recognize Mach-O __DATA_CONST segment as read-only data

2020-09-11T15:07:03+00:00

Updates #38830.

Change-Id: I826c6b0a42bc8e48fcda556250ca4a95c73987eb
Reviewed-on: https://go-review.googlesource.com/c/go/+/253918
Run-TryBot: Cherry Zhang 
TryBot-Result: Gobot Gobot 
Reviewed-by: Than McIntosh

cmd/go: refactor modload.Import for better -mod=readonly errors

2020-09-11T14:22:26+00:00

When -mod=readonly is set, Import will now allow imports from
replacements without explicit requirements. With -mod=mod, this would
add a new requirement but does not trigger a module lookup, so it's
determinisitic.

Before reporting an error for an unknown import with -mod=readonly,
check whether the import is valid. If there's a typo in the import,
that's more relevant.

For #40728

Change-Id: I05e138ff76ba3d0eb2e3010c15589fa363deb8d3
Reviewed-on: https://go-review.googlesource.com/c/go/+/253745
Run-TryBot: Jay Conrod 
TryBot-Result: Gobot Gobot 
Reviewed-by: Michael Matloob 
Reviewed-by: Bryan C. Mills

cmd/go: refactor -mod flag parsing

2020-09-11T14:22:17+00:00

Keep track of whether the -mod flag was set explicitly. When
-mod=readonly is the default, we'll want to adjust our error messages
if it's set explicitly.

Also, register the -mod, -modcacherw, and -modfile flags in functions
in internal/base instead of internal/work. 'go mod' commands that
don't load packages shouldn't depend on internal/work.

For #40728

Change-Id: I272aea9e19908ba37e151baac4ea8630e90f241f
Reviewed-on: https://go-review.googlesource.com/c/go/+/253744
Run-TryBot: Jay Conrod 
TryBot-Result: Gobot Gobot 
Reviewed-by: Michael Matloob 
Reviewed-by: Bryan C. Mills

cmd/link: record only the first occurance in Reachparent graph

2020-09-11T13:53:03+00:00

In the deadcode pass, a type symbol may be marked twice, one
without UsedInIface, one with. For the second time, don't
update the Reachparent graph, so it only records the path of
the first time the symbol is reached. This ensures the
Reachparent graph is acyclic.

TODO: add a test. (This only affects GOEXPERIMENT=fieldtrack)

Change-Id: I68e8a1a69c3830bc8aee5df946151dc22dcb2b29
Reviewed-on: https://go-review.googlesource.com/c/go/+/254297
Run-TryBot: Cherry Zhang 
TryBot-Result: Gobot Gobot 
Reviewed-by: Than McIntosh