delta/go-git.git/src/runtime/pprof, branch master

runtime, runtime/pprof: record instantiated symbol name in CPU profile

2023-05-05T19:53:39+00:00

For generic functions, the previous CL makes it record the full
instantiated symbol name in the runtime func table. This CL
changes the pprof package to use that name in CPU profile. This
way, it matches the symbol name the compiler sees, so it can apply
PGO.

TODO: add a test.

Fixes #58712.

Change-Id: If40db01cbef5f73c279adcc9c290a757ef6955b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/491678
Reviewed-by: Michael Pratt 
TryBot-Result: Gopher Robot 
Run-TryBot: Cherry Mui

runtime: add remaining wasip1 files

2023-04-06T17:48:24+00:00

Implements OS interactions and memory management.

For #58141

Co-authored-by: Richard Musiol 
Co-authored-by: Achille Roussel 
Co-authored-by: Julien Fabre 
Co-authored-by: Evan Phoenix 
Change-Id: I876e7b033090c2fe2d76d2535bb63d52efa36185
Reviewed-on: https://go-review.googlesource.com/c/go/+/479618
TryBot-Result: Gopher Robot 
Reviewed-by: Cherry Mui 
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Cherry Mui 
Auto-Submit: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor

runtime: skip trailing wrappers in runtime_expandFinalInlineFrame

2023-02-09T20:43:56+00:00

The existing runtime_expandFinalInlineFrame implementation doesn't skip trailing wrappers, but
gentraceback does skip wrapper functions.
This change makes runtime_expandFinalInlineFrame handling wrapper functions consistent to gentraceback.

Fixes #58288

Change-Id: I1b0e2c10b0a89bcb1e787b98d27730cb40a34406
Reviewed-on: https://go-review.googlesource.com/c/go/+/465097
Reviewed-by: Michael Pratt 
TryBot-Result: Gopher Robot 
Auto-Submit: Michael Pratt 
Run-TryBot: Michael Pratt 
Reviewed-by: David Chase

runtime: correct typos

2023-02-08T14:52:12+00:00

- Fix typo in throw error message for arena.
- Correct typos in assembly and Go comments.
- Fix log message in TestTraceCPUProfile.

Change-Id: I874c9e8cd46394448b6717bc6021aa3ecf319d16
GitHub-Last-Rev: d27fad4d3cea81cc7a4ca6917985bcf5fa49b0e0
GitHub-Pull-Request: golang/go#58375
Reviewed-on: https://go-review.googlesource.com/c/go/+/465975
Reviewed-by: David Chase 
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor 
Auto-Submit: Ian Lance Taylor 
TryBot-Result: Gopher Robot

runtime/pprof: document possibility of empty stacks

2023-01-09T20:25:19+00:00

I spent quite a while determining the cause of empty stacks in
profiles and reasoning out why this is okay. There isn't a great place
to record this knowledge, but a documentation comment on
appendLocsForStack is better than nothing.

Updates #51550.

Change-Id: I2eefc6ea31f1af885885c3d96199319f45edb4ce
Reviewed-on: https://go-review.googlesource.com/c/go/+/460695
Reviewed-by: Felix Geisendörfer 
Run-TryBot: Austin Clements 
TryBot-Result: Gopher Robot 
Reviewed-by: Michael Pratt

runtime/pprof: improve output of TestLabelSystemstack

2023-01-09T20:25:17+00:00

The current output of TestLabelSystemstack is a bit cryptic. This CL
improves various messages and hopefully simplifies the logic in the
test.

Simplifying the logic leads to three changes in possible outcomes,
which I verified by running the logic before and after this change
through all 2^4 possibilities (https://go.dev/play/p/bnfb-OQCT4j):

1. If a sample both must be labeled and must not be labeled, the test
now reports that explicitly rather than giving other confusing output.

2. If a sample must not be labeled but is, the current logic will
print two identical error messages. The new logic prints only one.

3. If the test finds no frames at all that it recognizes, but the
sample is labeled, it will currently print a confusing "Sample labeled
got true want false" message. The new logic prints nothing. We've seen
this triggered by empty stacks in profiles.

Fixes #51550. This bug was caused by case 3 above, where it was
triggered by a profile label on an empty stack. It's valid for empty
stacks to appear in a profile if we sample a goroutine just as it's
exiting (and that goroutine may have a profile label), so the test
shouldn't fail in this case.

Change-Id: I1593ec4ac33eced5bb89572a3ba7623e56f2fb3d
Reviewed-on: https://go-review.googlesource.com/c/go/+/460516
Run-TryBot: Austin Clements 
Reviewed-by: Felix Geisendörfer 
Reviewed-by: Michael Pratt 
TryBot-Result: Gopher Robot

Revert "runtime/pprof: unskip TestTimeVDSO on Android"

2022-12-06T22:07:25+00:00

This reverts CL 455358, commit 98da0fb43fb481a25b3b4399cd9f517fe94d9f3f.

Reason for revert: still failing https://build.golang.org/log/c9f13a76069f523b5b4a37a75ec52b30a1f3427a

Change-Id: I8246d233c4fb86781b882f19dea82065cc21bc26
Reviewed-on: https://go-review.googlesource.com/c/go/+/455696
Run-TryBot: Cherry Mui 
TryBot-Result: Gopher Robot 
Reviewed-by: Michael Pratt

runtime/pprof: unskip TestTimeVDSO on Android

2022-12-06T18:11:17+00:00

It is possible that CL 455166 fixes this. Try unskipping the test
and see. If it fails again we can skip it again.

Fixes #48655.

Change-Id: Ia81b06cb7608f74adb276bc018e8fc840285bc11
Reviewed-on: https://go-review.googlesource.com/c/go/+/455358
Reviewed-by: Michael Pratt 
Run-TryBot: Cherry Mui 
TryBot-Result: Gopher Robot

all: add missing periods in comments

2022-11-18T17:59:44+00:00

Change-Id: I69065f8adf101fdb28682c55997f503013a50e29
Reviewed-on: https://go-review.googlesource.com/c/go/+/449757
Auto-Submit: Ian Lance Taylor 
Reviewed-by: Joedian Reid 
Reviewed-by: Keith Randall 
Reviewed-by: Keith Randall 
TryBot-Result: Gopher Robot 
Run-TryBot: Joedian Reid 
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Ian Lance Taylor

runtime/pprof: scale mutex profile samples when they are recorded

2022-11-15T17:33:07+00:00

Samples in the mutex profile have their count and duration scaled
according to the probability they were sampled. This is done when the
profile is actually requested. The adjustment is done using to the
current configured sampling rate. However, if the sample rate is changed
after a specific sample is recorded, then the sample will be scaled
incorrectly. In particular, if the sampling rate is changed to 0, all of
the samples in the encoded profile will have 0 count and duration. This
means the profile will be "empty", even if it should have had samples.

This CL scales the samples in the profile when they are recorded, rather
than when the profile is requested. This matches what is currently done
for the block profile.

With this change, neither the block profile nor mutex profile are scaled
when they are encoded, so the logic for scaling the samples can be
removed.

Change-Id: If228cf39284385aa8fb9a2d62492d839e02f027f
Reviewed-on: https://go-review.googlesource.com/c/go/+/443056
Auto-Submit: Michael Knyszek 
TryBot-Result: Gopher Robot 
Run-TryBot: Michael Knyszek 
Reviewed-by: Joedian Reid 
Reviewed-by: Michael Knyszek