delta/go-git.git/src/plugin, branch dev.boringcrypto.go1.12

plugin: fix build constraint to disable test on linux/arm64

2018-11-28T18:14:20+00:00

CL 151478 was suppose to fix the build failure on linux/arm64 but the
build constraint didn't exclude linux/arm64 properly.

Fixes #28982

Change-Id: Ia80265b0adba0384cd28bc2deb1726418664975a
Reviewed-on: https://go-review.googlesource.com/c/151303
Run-TryBot: Tobias Klauser 
TryBot-Result: Gobot Gobot 
Reviewed-by: Andrew Bonventre

plugin: skip building tests on linux/arm64

2018-11-28T08:33:05+00:00

It appears that linux/arm64

https://build.golang.org/log/6808dbded6aebadf68cb65a0e30e4d1a62cd687b

fails with

/workdir/go/pkg/tool/linux_arm64/link: running gcc failed: exit status 1
/usr/bin/ld.gold: internal error in global, at ../../gold/aarch64.cc:4973
collect2: error: ld returned 1 exit status
FAIL plugin [build failed]

error. So stop building these tests on linux/arm64.

Fixes linux/arm64 build

Change-Id: I41eb3d9659f7967d80136513899a5203bbf03fb1
Reviewed-on: https://go-review.googlesource.com/c/151478
Run-TryBot: Alex Brainman 
TryBot-Result: Gobot Gobot 
Reviewed-by: Cherry Zhang

cmd/link: do not use _GLOBAL_OFFSET_TABLE_ on windows/386

2018-11-27T08:52:43+00:00

When building windows/386 executable that imports "plugin" package,
cmd/link adds reference to DLL with blank name. Running

objdump -x a.exe

reports

...
The Import Tables (interpreted .idata section contents)
...
DLL Name:
vma:  Hint/Ord Member-Name Bound-To
25308a     0  _GLOBAL_OFFSET_TABLE_
...

So, obviously, executable cannot run, because Windows complains
that it cannot find DLL when trying to run it.

Stop using _GLOBAL_OFFSET_TABLE_ on windows/386.

Fixes #28789

Change-Id: Idd489eafd998f6e329f40c5d90a2a8965ab1d873
Reviewed-on: https://go-review.googlesource.com/c/151139
Run-TryBot: Alex Brainman 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor

plugin: remove unused func

2018-08-22T16:29:03+00:00

Change-Id: Ife29464d581f00940af7ef9251bf99661c1350b6
GitHub-Last-Rev: d7747706584b06b619fc78a85b6b9bfe619467c8
GitHub-Pull-Request: golang/go#26740
Reviewed-on: https://go-review.googlesource.com/127195
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Brad Fitzpatrick 
TryBot-Result: Gobot Gobot

plugin: make stub lookup signature match dlopen version

2018-05-08T17:09:05+00:00

Change-Id: I64958f8f1a935adc07868362975447d0c0033084
Reviewed-on: https://go-review.googlesource.com/111716
Reviewed-by: Ian Lance Taylor

plugin: document support for macOS

2017-12-12T00:59:50+00:00

All plugins issues I would call bugs now closed, so
(with some amount of optimism) update the plugin documentation.

Change-Id: Ia421c18a166d7cdf599ac86f2336541c1ef42a0d
Reviewed-on: https://go-review.googlesource.com/65670
Reviewed-by: Ian Lance Taylor

cmd/link, plugin: always encode path

2017-10-26T15:08:37+00:00

Both the linker and the plugin package were inconsistent
about when they applied the path encoding defined in
objabi.PathToPrefix. As a result, only some symbols from
a package path that required encoding were being found.

So always encoding the path.

Fixes #22295

Change-Id: Ife86c79ca20b2e9307008ed83885e193d32b7dc4
Reviewed-on: https://go-review.googlesource.com/72390
Run-TryBot: David Crawshaw 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor

runtime, plugin: error not throw on duplicate open

2017-09-09T16:26:33+00:00

Along the way, track bad modules. Make sure they don't end up on
the active modules list, and aren't accidentally reprocessed as
new plugins.

Fixes #19004

Change-Id: I8a5e7bb11f572f7b657a97d521a7f84822a35c07
Reviewed-on: https://go-review.googlesource.com/61171
Run-TryBot: David Crawshaw 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor

{net,os/user,plugin}: eliminate unnecessary C round-trips

2017-08-17T18:14:16+00:00

We're making two extra round-trips to C to malloc and free strings
that originate in Go and don't escape. Skip those round-trips by
allocating null-terminated slices in Go memory instead.

Change-Id: I9e4c5ad999a7924ba50b82293c52073ec75518be
Reviewed-on: https://go-review.googlesource.com/56530
Run-TryBot: Bryan Mills 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor

plugin: mention that there are known bugs with plugins

2017-07-28T00:29:08+00:00

Change-Id: I9e63661cac2bebc41d7aa3cd80e1920eec22b894
Reviewed-on: https://go-review.googlesource.com/51250
Reviewed-by: Brad Fitzpatrick 
Reviewed-by: David Crawshaw