delta/go-git.git/src/path, branch dev.debug

path/filepath: fix TestGlobError

2017-06-15T21:53:23+00:00

Change-Id: I7776547332066e1d7651e9aa06eec301dfaf38bc
Reviewed-on: https://go-review.googlesource.com/45892
Reviewed-by: Rob Pike 
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot

path, path/filepath: clarify and cross-reference packages

2017-06-14T02:54:44+00:00

The path package has a reference to the path/filepath package, so add
a reverse reference.

And clarify the path package doesn't do Windows paths.

Fixes #20117

Change-Id: I65c5ce24e600b32ea20c5821b744bd89f6aff98c
Reviewed-on: https://go-review.googlesource.com/45653
Reviewed-by: Jaana Burcu Dogan 
Reviewed-by: Ian Lance Taylor

path: add examples

2017-05-16T15:44:29+00:00

This change adds several examples, with emphasis on special or edge
cases such as a directory parameter consisting of an empty string.

Change-Id: Ib4ac3d0f6d503493eeed0c4fda7c12acf782e9e2
Reviewed-on: https://go-review.googlesource.com/43010
Reviewed-by: Steve Francia 
Run-TryBot: Jaana Burcu Dogan 
TryBot-Result: Gobot Gobot

os: do not report ModeDir for symlinks on windows

2017-04-26T23:17:23+00:00

When using Lstat against symlinks that point to a directory,
the function returns FileInfo with both ModeDir and ModeSymlink set.
Change that to never set ModeDir if ModeSymlink is set.

Fixes #10424
Fixes #17540
Fixes #17541

Change-Id: Iba280888aad108360b8c1f18180a24493fe7ad2b
Reviewed-on: https://go-review.googlesource.com/41830
Reviewed-by: Daniel Martí 
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Daniel Martí 
TryBot-Result: Gobot Gobot

all: remove some unused parameters in test code

2017-04-25T14:38:10+00:00

Mostly unnecessary *testing.T arguments.

Found with github.com/mvdan/unparam.

Change-Id: Ifb955cb88f2ce8784ee4172f4f94d860fa36ae9a
Reviewed-on: https://go-review.googlesource.com/41691
Run-TryBot: Daniel Martí 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor

path/filepath: add test to walk symlink

2017-04-05T02:31:45+00:00

For #17540.

Change-Id: Ie01f39797526934fa553f4279cbde6c7cbf14154
Reviewed-on: https://go-review.googlesource.com/36854
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot

path/filepath: add test for directory junction walk

2017-02-12T23:33:01+00:00

For #10424.

Change-Id: Ie4e87503b0ed04f65d2444652bd1db647d3529f4
Reviewed-on: https://go-review.googlesource.com/36851
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Brad Fitzpatrick 
TryBot-Result: Gobot Gobot

path/filepath: fix TestWinSplitListTestsAreValid on some systems

2017-02-11T19:53:56+00:00

The environment variables used in those tests override the default
OS ones. However, one of them (SystemRoot) seems to be required on
some Windows systems for invoking cmd.exe properly.

This fixes #4930 and #6568.

Change-Id: I23dfb67c1de86020711a3b59513f6adcbba12561
Reviewed-on: https://go-review.googlesource.com/36873
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Brad Fitzpatrick 
TryBot-Result: Gobot Gobot

path/filepath: ignore dot for Dir(`\\server\share`)

2017-02-04T07:24:20+00:00

Dir(`\\server\share`) returns `\\server\share.`. Change Dir so it
returns `\\server\share` instead.

Fixes #18783

Change-Id: I9e0dd71ea6aea85e6c6114aaa4bb3bea3270d818
Reviewed-on: https://go-review.googlesource.com/35690
Reviewed-by: Alex Brainman 
Run-TryBot: Alex Brainman 
TryBot-Result: Gobot Gobot

all: fix misspellings

2017-01-07T16:53:25+00:00

Change-Id: I429637ca91f7db4144f17621de851a548dc1ce76
Reviewed-on: https://go-review.googlesource.com/34923
Reviewed-by: Ian Lance Taylor 
Reviewed-by: Daniel Martí 
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot