delta/go-git.git/src/os, branch dev.boringcrypto.go1.12

[release-branch.go1.12] os: enable the close-on-exec flag for openFdAt

2019-08-02T04:53:33+00:00

There's a race here with fork/exec, enable the close-on-exec flag
for the new file descriptor.

Updates #33405
Fixes #33424

Change-Id: Ib1e405c3b48b11c867f183fd13eff8b73d95e3b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/188537
Run-TryBot: Baokun Lee 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor 
(cherry picked from commit 2d6ee6e89a4b30c7528d2977df4e1aa86651e4e4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/188538
Run-TryBot: Ian Lance Taylor

[release-branch.go1.12] os: pass correct environment when creating Windows processes

2019-05-17T14:26:32+00:00

This is CVE-2019-11888.

Previously, passing a nil environment but a non-nil token would result
in the new potentially unprivileged process inheriting the parent
potentially privileged environment, or would result in the new
potentially privileged process inheriting the parent potentially
unprivileged environment. Either way, it's bad. In the former case, it's
an infoleak. In the latter case, it's a possible EoP, since things like
PATH could be overwritten.

Not specifying an environment currently means, "use the existing
environment". This commit amends the behavior to be, "use the existing
environment of the token the process is being created for." The behavior
therefore stays the same when creating processes without specifying a
token. And it does the correct thing when creating processes when
specifying a token.

Updates #32000
Fixes #32081

Change-Id: Ib4a90cfffb6ba866c855f66f1313372fdd34ce41
Reviewed-on: https://go-review.googlesource.com/c/go/+/177538
Run-TryBot: Jason Donenfeld 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor

[release-branch.go1.12] os: don't treat RemoveAll("/x") as RemoveAll("x")

2019-04-15T22:12:05+00:00

Updates #31468
Fixes #31474

Change-Id: I5c4e61631b8af35bfc14b0cb9bc77feec100e340
Reviewed-on: https://go-review.googlesource.com/c/go/+/172058
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Brad Fitzpatrick 
TryBot-Result: Gobot Gobot 
(cherry picked from commit 3ebd9523bb0dcb975a34ec402f23eee07e81562f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/172080

Revert "[release-branch.go1.12] syscall: avoid _getdirentries64 on darwin"

2019-04-05T18:15:47+00:00

This reverts commit 731ebf4d87dbe349e2eb60233c3965ee62a32690.

Reason for revert: It's not working for large directories.

Change-Id: Ie0f88e0ed1d36c4ea4f32d2acd4e223bd8229ca0
Reviewed-on: https://go-review.googlesource.com/c/go/+/170882
Reviewed-by: Emmanuel Odeke 
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Andrew Bonventre

[release-branch.go1.12] syscall: avoid _getdirentries64 on darwin

2019-04-05T16:59:48+00:00

Getdirentries is implemented with the __getdirentries64 function
in libSystem.dylib. That function works, but it's on Apple's
can't-be-used-in-an-app-store-application list.

Implement Getdirentries using the underlying fdopendir/readdir_r/closedir.
The simulation isn't faithful, and could be slow, but it should handle
common cases.

Don't use Getdirentries in the stdlib, use fdopendir/readdir_r/closedir
instead (via (*os.File).readdirnames).

(Incorporates CL 170837 and CL 170698, which were small fixes to the
original tip CL.)

Fixes #31244

Update #28984

RELNOTE=yes

Change-Id: Ia6b5d003e5bfe43ba54b1e1d9cfa792cc6511717
Reviewed-on: https://go-review.googlesource.com/c/go/+/168479
Reviewed-by: Emmanuel Odeke 
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Emmanuel Odeke 
TryBot-Result: Gobot Gobot 
(cherry picked from commit 9da6530faab0a58c4c4e02b2f3f4a5c754dcbd4e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/170640
Run-TryBot: Brad Fitzpatrick

[release-branch.go1.12] os: consistently return PathError from RemoveAll

2019-03-15T16:32:03+00:00

Fixes #30859
Updates #30491

Change-Id: If4070e5d39d8649643d7e90f6f3eb499642e25ab
Reviewed-on: https://go-review.googlesource.com/c/go/+/164720
Run-TryBot: Baokun Lee 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor 
Reviewed-by: Emmanuel Odeke 
(cherry picked from commit d039e12b54a73796caa913994597a9f3a73e8e87)
Reviewed-on: https://go-review.googlesource.com/c/go/+/167739
Run-TryBot: Brad Fitzpatrick 
Reviewed-by: Baokun Lee

[release-branch.go1.12] os: remove unreadable directories in RemoveAll

2019-03-05T01:16:23+00:00

Updates #30555
Fixes #30579

Change-Id: Ib894b4f3cdba23a18a69c9470cf69ceb83591a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/165057
Run-TryBot: Baokun Lee 
TryBot-Result: Gobot Gobot 
Reviewed-by: Ian Lance Taylor 
(cherry picked from commit c74659290a473cf932ec6bc96bfa7e96a930676e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/165058
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Brad Fitzpatrick

[release-branch.go1.12] os: don't return ENOENT if directory removed before Fstatat

2019-02-13T23:50:05+00:00

Updates #30197

Change-Id: I08b592fbd477d6879eb5d3b7fcbbc8322ea90103
Reviewed-on: https://go-review.googlesource.com/c/162078
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot 
Reviewed-by: Brad Fitzpatrick 
(cherry picked from commit cf4dc25503e6fb630280f8de0f11112aecb94b57)
Reviewed-on: https://go-review.googlesource.com/c/162197

os: treat EACCES as a permission error in RemoveAll

2019-01-30T01:56:14+00:00

Fixes #29983

Change-Id: I24077bde991e621c23d00973b2a77bb3a18e4ae7
Reviewed-on: https://go-review.googlesource.com/c/160180
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Damien Neil 
TryBot-Result: Gobot Gobot

os: restore RemoveAll docs by making a single copy

2019-01-30T01:39:37+00:00

Updates #29983

Change-Id: Ifdf8aa9c92e053374e301a4268d85e277c15f0b5
Reviewed-on: https://go-review.googlesource.com/c/160182
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gobot Gobot 
Reviewed-by: Brad Fitzpatrick