delta/go-git.git/src/os/exec, branch master

os, syscall: support ill-formed UTF-16 strings on Windows

2023-05-15T09:26:16+00:00

Windows UTF-16 strings can contain unpaired surrogates, which can't be
decoded into a valid UTF-8 string. This file defines a set of functions
that can be used to encode and decode potentially ill-formed UTF-16
strings by using the
[the WTF-8 encoding](https://simonsapin.github.io/wtf-8/).

WTF-8 is a strict superset of UTF-8, i.e. any string that is
well-formed in UTF-8 is also well-formed in WTF-8 and the content
is unchanged. Also, the conversion never fails and is lossless.

The benefit of using WTF-8 instead of UTF-8 when decoding a UTF-16
string is that the conversion is lossless even for ill-formed
UTF-16 strings. This property allows to read an ill-formed UTF-16
string, convert it to a Go string, and convert it back to the same
original UTF-16 string.

Fixes #59971

Change-Id: Id6007f6e537844913402b233e73d698688cd5ba6
Reviewed-on: https://go-review.googlesource.com/c/go/+/493036
TryBot-Result: Gopher Robot 
Reviewed-by: Bryan Mills 
Run-TryBot: Quim Muntal 
Reviewed-by: Cherry Mui 
Reviewed-by: Paul Hampson

cmd/go: add check for unknown godebug setting

2023-04-18T13:19:19+00:00

A //go:debug line mentioning an unknown or retired setting
should be diagnosed as making the program invalid. Do that.
We agreed on this in the proposal but I forgot to implement it.

Change-Id: Ie69072a1682d4eeb6866c02adbbb426f608567c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/476280
Run-TryBot: Russ Cox 
Reviewed-by: Bryan Mills 
TryBot-Result: Gopher Robot

os: add wasip1 support

2023-04-07T23:34:21+00:00

For #58141

Co-authored-by: Richard Musiol 
Co-authored-by: Achille Roussel 
Co-authored-by: Julien Fabre 
Co-authored-by: Evan Phoenix 
Change-Id: I52e3e161f81dcbe8605570e47d732992979c4d34
Reviewed-on: https://go-review.googlesource.com/c/go/+/479623
Run-TryBot: Johan Brandhorst-Satzkorn 
TryBot-Result: Gopher Robot 
Reviewed-by: Ian Lance Taylor 
Auto-Submit: Ian Lance Taylor 
Reviewed-by: Cherry Mui 
Run-TryBot: Ian Lance Taylor

os/exec: skip remount in TestFindExecutableVsNoexec on EROFS

2023-04-04T21:20:20+00:00

To allow using testenv.SyscallIsNotSupported, rewrite the test to use
the exported API only. Given that path is an absolute path,
exec.LookPath is equivalent to exec.findExecutable on linux.

Fixes #59087

Change-Id: Ia01b84d4e9d5a65a88dd995f9e3c8a81c4ccd19f
Reviewed-on: https://go-review.googlesource.com/c/go/+/481620
Reviewed-by: Bryan Mills 
Run-TryBot: Tobias Klauser 
TryBot-Bypass: Bryan Mills 
Reviewed-by: Ian Lance Taylor

cmd/link/internal/ld: move more of mustLinkExternal into internal/platform

2023-03-02T16:34:21+00:00

internal/platform.MustLinkExternal is used in various places to
determine whether external linking is required. It should always
match what the linker actually requires, but today does not match
because the linker imposes additional constraints.

Updates #31544.

Change-Id: I0cc6ad587e95c607329dea5d60d29a5fb2a9e722
Reviewed-on: https://go-review.googlesource.com/c/go/+/472515
Run-TryBot: Bryan Mills 
TryBot-Result: Gopher Robot 
Reviewed-by: Ian Lance Taylor

all: fix typos

2023-02-28T03:43:42+00:00

Change-Id: Ica8d5e5799a4de532764ae86cdb623508d3a8e18
GitHub-Last-Rev: 3e97cca9de3885f2fe0d7deb776e59cc1c73146d
GitHub-Pull-Request: golang/go#58689
Reviewed-on: https://go-review.googlesource.com/c/go/+/471021
Auto-Submit: Ian Lance Taylor 
Reviewed-by: Ian Lance Taylor 
TryBot-Result: Gopher Robot 
Reviewed-by: Dmitri Shuralyov 
Run-TryBot: Ian Lance Taylor

os: use testenv.Command instead of exec.Command in tests

2023-02-21T23:07:55+00:00

testenv.Command sets a default timeout based on the test's deadline
and sends SIGQUIT (where supported) in case of a hang.

Change-Id: I84d469d12ca1f39175b713ca41e7cd2202d11d96
Reviewed-on: https://go-review.googlesource.com/c/go/+/451895
Auto-Submit: Bryan Mills 
TryBot-Result: Gopher Robot 
Run-TryBot: Bryan Mills 
Reviewed-by: Bryan Mills 
Reviewed-by: Ian Lance Taylor

internal/godebug: export non-default-behavior counters in runtime/metrics

2023-01-19T22:26:43+00:00

Allow GODEBUG users to report how many times a setting
resulted in non-default behavior.

Record non-default-behaviors for all existing GODEBUGs.

Also rework tests to ensure that runtime is in sync with runtime/metrics.All,
and generate docs mechanically from metrics.All.

For #56986.

Change-Id: Iefa1213e2a5c3f19ea16cd53298c487952ef05a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/453618
TryBot-Result: Gopher Robot 
Auto-Submit: Russ Cox 
Run-TryBot: Russ Cox 
Reviewed-by: Michael Knyszek

os/exec: avoid leaking an exec.Cmd in TestWaitInterrupt

2023-01-10T17:59:34+00:00

In CL 436655 I added a GODEBUG setting to this test process to verify
that Wait is eventually called for every exec.Cmd before it becomes
unreachable. However, the cmdHang test helpers in
TestWaitInterrupt/Exit-hang and TestWaitInterrupt/SIGKILL-hang
intentially leak a subprocess in order to simulate a leaky third-party
program, as Go users might encounter in practical use.

To avoid tripping over the leak check, we call Wait on the leaked
subprocess in a background goroutine. Since we expect the process
running cmdHang to exit before its subprocess does, the call to Wait
should have no effect beyond suppressing the leak check.

Fixes #57596.
Updates #52580.
Updates #50436.

Change-Id: Ia4b88ea47fc6b605c27ca6d9d7669c874867a900
Reviewed-on: https://go-review.googlesource.com/c/go/+/460998
Run-TryBot: Bryan Mills 
Auto-Submit: Bryan Mills 
Reviewed-by: Ian Lance Taylor 
TryBot-Result: Gopher Robot

os/exec: retry ETXTBSY errors in TestFindExecutableVsNoexec

2022-12-16T03:04:44+00:00

I made this test parallel in CL 439196, which exposed it to the
fork/exec race condition described in #22315. The ETXTBSY errors from
that race should resolve on their own, so we can simply retry the call
to get past them.

Fixes #56811.
Updates #22315.

Change-Id: I2c6aa405bf3a1769d69cf08bf661a9e7f86440b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/458016
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Bryan Mills 
Auto-Submit: Bryan Mills 
TryBot-Result: Gopher Robot