delta/go-git.git/src/os/exec, branch dev.unified

os/exec: add GODEBUG setting to opt out of ErrDot changes

2022-07-28T19:12:40+00:00

The changes are likely to break users, and we need
to make it easy to unbreak without code changes.

For #43724.
Fixes #53962.

Change-Id: I105c5d6c801d354467e0cefd268189c18846858e
Reviewed-on: https://go-review.googlesource.com/c/go/+/419794
Reviewed-by: Bryan Mills 
Reviewed-by: Ian Lance Taylor 
TryBot-Result: Gopher Robot 
Run-TryBot: Russ Cox

os/exec: clarify that Wait must be called

2022-07-06T16:51:00+00:00

Fixes #52580

Change-Id: Ib2dd8a793b9c6fcb083abb3f7c346f6279adefc9
Reviewed-on: https://go-review.googlesource.com/c/go/+/414056
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gopher Robot 
Reviewed-by: Alan Donovan 
Reviewed-by: Cherry Mui

os/exec: on Windows, suppress ErrDot if the implicit path matches the explicit one

2022-06-28T19:29:51+00:00

If the current directory is also listed explicitly in %PATH%,
this changes the behavior of LookPath to prefer the explicit name for it
(and thereby avoid ErrDot).

However, in order to avoid running a different executable from what
would have been run by previous Go versions, we still return the
implicit path (and ErrDot) if it refers to a different file entirely.

Fixes #53536.
Updates #43724.

Change-Id: I7ab01074e21a0e8b07a176e3bc6d3b8cf0c873cd
Reviewed-on: https://go-review.googlesource.com/c/go/+/414054
Reviewed-by: Russ Cox 
Run-TryBot: Bryan Mills 
Reviewed-by: Ian Lance Taylor 
Reviewed-by: Alex Brainman 
TryBot-Result: Gopher Robot

os/exec: eliminate some arbitrary short timeouts

2022-05-10T22:12:11+00:00

These tests appear to be using timeouts to check for deadlocks or to
cause the test to fail earlier. However, on slower machines these
short timeouts can cause spurious failures, and even on faster
machines if the test locks up we usually want a goroutine dump instead
of a short failure message anyway.

Fixes #52818 (maybe).

Change-Id: Ib8f18d679f9443721e8a924caef6dc8d214fca1b
Reviewed-on: https://go-review.googlesource.com/c/go/+/405434
TryBot-Result: Gopher Robot 
Auto-Submit: Bryan Mills 
Run-TryBot: Bryan Mills 
Reviewed-by: Ian Lance Taylor

os/exec: return clear error for missing cmd.Path

2022-05-10T17:29:08+00:00

Following up on CL 403694, there is a bit of confusion about
when Path is and isn't set, along with now the exported Err field.
Catch the case where Path and Err (and lookPathErr) are all unset
and give a helpful error.

Fixes #52574
Followup after #43724.

Change-Id: I03205172aef3801c3194f5098bdb93290c02b1b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/403759
Reviewed-by: Bryan Mills 
Reviewed-by: Roland Shoemaker

os/exec: refactor goroutine communication in Wait

2022-05-06T22:04:35+00:00

This provides clearer synchronization invariants: if it occurs at all,
the call to c.Process.Kill always occurs before Wait returns. It also
allows any unexpected errors from the goroutine to be propagated back
to Wait.

For #50436.

Change-Id: I7ddadc73e6e67399596e35393f5845646f6111ab
Reviewed-on: https://go-review.googlesource.com/c/go/+/401896
TryBot-Result: Gopher Robot 
Reviewed-by: Ian Lance Taylor 
Auto-Submit: Bryan Mills 
Run-TryBot: Bryan Mills 
Reviewed-by: Ian Lance Taylor

os/exec: in Command, update cmd.Path even if LookPath returns an error

2022-05-03T16:29:56+00:00

Fixes #52666.
Updates #43724.
Updates #43947.

Change-Id: I72cb585036b7e93cd7adbff318b400586ea97bd5
Reviewed-on: https://go-review.googlesource.com/c/go/+/403694
Reviewed-by: Russ Cox 
Run-TryBot: Bryan Mills 
TryBot-Result: Gopher Robot 
Auto-Submit: Bryan Mills

os/exec: return error when PATH lookup would use current directory

2022-05-02T14:54:05+00:00

CL 381374 was reverted because x/sys/execabs broke.

This CL reapplies CL 381374, but adding a lookPathErr error
field back, for execabs to manipulate with reflect.
That field will just be a bit of scar tissue in this package forever,
to keep old code working with new toolchains.

CL 403256 fixes x/sys/execabs's test to be ready for the change.
Older versions of x/sys/execabs will keep working
(that is, will keep rejecting what they should reject),
but they will return a slightly different error from LookPath
without that CL, and the test fails because of the different
error text.

For #43724.

This reverts commit f2b674756b3b684118e4245627d4ed8c07e518e7.

Change-Id: Iee55f8cd9939e1bd31e5cbdada50681cdc505117
Reviewed-on: https://go-review.googlesource.com/c/go/+/403274
Auto-Submit: Russ Cox 
Run-TryBot: Russ Cox 
TryBot-Result: Gopher Robot 
Reviewed-by: Ian Lance Taylor

Revert "os/exec: return error when PATH lookup would use current directory"

2022-04-29T23:04:17+00:00

This reverts CL 381374.

Reason for revert: broke tests for x/sys/execabs.

Updates #43724.
Updates #43947.

Change-Id: I9eb3adb5728dead66dbd20f6afe1e7a77e2a26f1
Reviewed-on: https://go-review.googlesource.com/c/go/+/403058
Reviewed-by: Dmitri Shuralyov 
Run-TryBot: Dmitri Shuralyov 
Reviewed-by: Dmitri Shuralyov 
Auto-Submit: Dmitri Shuralyov 
TryBot-Result: Gopher Robot 
Auto-Submit: Bryan Mills

os/exec: return error when PATH lookup would use current directory

2022-04-29T20:16:31+00:00

Following discussion on #43724, change os/exec to take the
approach of golang.org/x/sys/execabs, refusing to respect
path entries mentioning relative paths by default.

Code that insists on being able to find executables in relative
directories in the path will need to add a couple lines to override the error.

See the updated package docs in exec.go for more details.

Fixes #43724.
Fixes #43947.

Change-Id: I73c1214f322b60b4167a23e956e933d50470fe13
Reviewed-on: https://go-review.googlesource.com/c/go/+/381374
Reviewed-by: Bryan Mills 
TryBot-Result: Gopher Robot 
Run-TryBot: Bryan Mills