delta/go-git.git/src/internal, branch master

os: if descriptor is non-blocking, retain that in Fd method

2023-05-17T21:12:04+00:00

For #58408
Fixes #60211

Change-Id: I30f5678b46e15121865b19d1c0f82698493fad4e
Reviewed-on: https://go-review.googlesource.com/c/go/+/495079
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Ian Lance Taylor 
TryBot-Result: Gopher Robot 
Reviewed-by: Bryan Mills 
Auto-Submit: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor

cmd/link, internal/abi: minor follow-up cleanups

2023-05-17T18:24:13+00:00

these address comments on CLs in the large refactoring stack
recently submitted.

Change-Id: Ic9023c32aafe4dda953b42c9a36834d3ab3432eb
Reviewed-on: https://go-review.googlesource.com/c/go/+/495835
Reviewed-by: Than McIntosh 
TryBot-Result: Gopher Robot 
Run-TryBot: David Chase 
Reviewed-by: Cherry Mui

internal/abi: update type name in comment

2023-05-17T13:57:49+00:00

method -> Method

For #59670

Change-Id: I78e0410f3d5094aa12b2f3ccd6735fec0d696190
Reviewed-on: https://go-review.googlesource.com/c/go/+/494795
Reviewed-by: Ian Lance Taylor 
Auto-Submit: Ian Lance Taylor 
Reviewed-by: David Chase 
TryBot-Result: Gopher Robot 
Run-TryBot: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor

go/types, types2: permit partially instantiated functions as function arguments

2023-05-16T23:01:33+00:00

This CL changes Checker.genericExprList such that it collects partially
instantiated generic functions together with their (partial) type
argument (and corresponding) expression lists, instead of trying to
infer the missing type arguments in place or to report an error.
Special care is being taken to explictly record expression types where
needed (because we can't use one of the usual expr evaluators which
takes care of that), or to track the correct instance expression for
later recording with Checker.arguments.

The resulting generic expression list is passed to Checker.arguments
which is changed to accept explicit partial type argument (and
corresponding) expression lists. The provided type arguments are fed
into type inference, matching up with their respective type parameters
(which were collected already, before this CL). If type inference is
successful, the instantiated functions are recorded as needed.

For now, the type argument expression lists are collected and passed
along but not yet used. We may use them eventually for better error
reporting.

Fixes #59958.
For #59338.

Change-Id: I26db47ef3546e64553da49d62b23cd3ef9e2b549
Reviewed-on: https://go-review.googlesource.com/c/go/+/494116
Reviewed-by: Robert Findley 
Auto-Submit: Robert Griesemer 
Reviewed-by: Robert Griesemer 
TryBot-Result: Gopher Robot 
Run-TryBot: Robert Griesemer

go/types, types2: remove superfluous argument test in Checker.arguments

2023-05-16T22:41:49+00:00

There's only two places which call Checker.arguments: Checker.callExpr
and Checker.builtin. Both ensure that the passed argument list doesn't
contain type expressions, so we don't need that extra check at the start
of Checker.arguments.

The remaining check causes Checker.arguments to exit early if any of
the passed arguments is invalid. This reduces the number of reported
errors in rare cases but is executed all the time.
If the extra errors are a problem, it would be better to not call
Checker.arguments in the first place, or only do the extra check
before Checker.arguments reports an error.

Removing this code for now. Removes a long-standing TODO.

Change-Id: Ief654b680eb6b6a768bb1b4c621d3c8169953f17
Reviewed-on: https://go-review.googlesource.com/c/go/+/495395
Run-TryBot: Robert Griesemer 
Auto-Submit: Robert Griesemer 
Reviewed-by: Robert Griesemer 
TryBot-Result: Gopher Robot 
Reviewed-by: Robert Findley

net: use and assert correct res state size at compile time when cgo available on darwin

2023-05-16T16:01:08+00:00

Change-Id: I961bb18604dd1568ea21431545f43aa6a417b3d9
GitHub-Last-Rev: 735f3364a4f2182f3e3e1b84f39a042e86987967
GitHub-Pull-Request: golang/go#60046
Reviewed-on: https://go-review.googlesource.com/c/go/+/493415
Auto-Submit: Ian Lance Taylor 
Run-TryBot: Mateusz Poliwczak 
Reviewed-by: Ian Lance Taylor 
TryBot-Result: Gopher Robot 
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Heschi Kreinick

os, syscall: support ill-formed UTF-16 strings on Windows

2023-05-15T09:26:16+00:00

Windows UTF-16 strings can contain unpaired surrogates, which can't be
decoded into a valid UTF-8 string. This file defines a set of functions
that can be used to encode and decode potentially ill-formed UTF-16
strings by using the
[the WTF-8 encoding](https://simonsapin.github.io/wtf-8/).

WTF-8 is a strict superset of UTF-8, i.e. any string that is
well-formed in UTF-8 is also well-formed in WTF-8 and the content
is unchanged. Also, the conversion never fails and is lossless.

The benefit of using WTF-8 instead of UTF-8 when decoding a UTF-16
string is that the conversion is lossless even for ill-formed
UTF-16 strings. This property allows to read an ill-formed UTF-16
string, convert it to a Go string, and convert it back to the same
original UTF-16 string.

Fixes #59971

Change-Id: Id6007f6e537844913402b233e73d698688cd5ba6
Reviewed-on: https://go-review.googlesource.com/c/go/+/493036
TryBot-Result: Gopher Robot 
Reviewed-by: Bryan Mills 
Run-TryBot: Quim Muntal 
Reviewed-by: Cherry Mui 
Reviewed-by: Paul Hampson

internal/testdir: move to cmd/internal/testdir

2023-05-12T17:18:08+00:00

The effect and motivation is for the test to be selected when doing
'go test cmd' and not when doing 'go test std' since it's primarily
about testing the Go compiler and linker. Other than that, it's run
by all.bash and 'go test std cmd' as before.

For #56844.
Fixes #60059.

Change-Id: I2d499af013f9d9b8761fdf4573f8d27d80c1fccf
Reviewed-on: https://go-review.googlesource.com/c/go/+/493876
Run-TryBot: Dmitri Shuralyov 
Reviewed-by: Bryan Mills 
Auto-Submit: Dmitri Shuralyov 
TryBot-Result: Gopher Robot 
Reviewed-by: Dmitri Shuralyov

go/types, types2: be sure to type-check wrong methods in missingMethod

2023-05-12T14:53:44+00:00

In the case of a wrong method, we were not ensuring that it was
type-checked before passing it to funcString.

Formatting the missing method error message requires a fully set-up
signature.

Fixes #59848

Change-Id: I1467e036afbbbdd00899bfd627a945500dc709c2
Reviewed-on: https://go-review.googlesource.com/c/go/+/494615
TryBot-Result: Gopher Robot 
Run-TryBot: Robert Findley 
Reviewed-by: Alan Donovan

cmd/dist,internal/testdir: more cooperative host test mechanism

2023-05-12T12:35:01+00:00

On cross-compiling builder machines, we run internal/testdir on the
host, where it can access the Go toolchain to build binaries for the
guest and run them through an exec wrapper. Currently this uses dist
test's existing host test mechanism, which is quite complicated and we
are planning to eliminate (#59999).

Switch internal/testdir to use a more cooperative mechanism. With this
CL, dist still understands that it has to build and run the test using
the host GOOS/GOARCH, but rather than doing complicated manipulation
of environment variables itself, it passes the guest GOOS/GOARCH to
the test, which can easily inject it into its environment. This means
dist test can use "go test" directly, rather than having to split up
the build and run steps.

For #37486.

Change-Id: I556938c0b641960bb778b88b13f2b26256edc7c9
Reviewed-on: https://go-review.googlesource.com/c/go/+/492985
Reviewed-by: Dmitri Shuralyov 
Run-TryBot: Austin Clements 
Reviewed-by: Bryan Mills 
Reviewed-by: Dmitri Shuralyov 
TryBot-Result: Gopher Robot