delta/go-git.git/src/internal/xcoff, branch dev.cmdgo github.com: golang/go internal/xcoff: fix wrong bit masking comparisons 2020-03-09T18:07:53+00:00 Neven Sajko nsajko@gmail.com 2020-03-07T17:23:20+00:00 b559a173f9f187e1185f8de00a9cc1f5b05aceef I do not know much about xcoff, but this was probably the intended behavior. (The comparison is tautologically false, as is.) Also note: does any other code even depend on the changed code existing? Maybe it should just be removed, as I did not find any uses of fields that are written to if the branch condition tests true. Change-Id: I1f23d33764df40e87f3e64460d63f6efc51a2a78 GitHub-Last-Rev: 268909130fd7fb3993fcf7004143ec48dbfe5e2a GitHub-Pull-Request: golang/go#37733 Reviewed-on: https://go-review.googlesource.com/c/go/+/222478 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Clément Chigot <clement.chigot%atos.net@gtempaccount.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> 
I do not know much about xcoff, but this was probably the intended
behavior. (The comparison is tautologically false, as is.)

Also note: does any other code even depend on the changed code existing?
Maybe it should just be removed, as I did not find any uses of fields
that are written to if the branch condition tests true.

Change-Id: I1f23d33764df40e87f3e64460d63f6efc51a2a78
GitHub-Last-Rev: 268909130fd7fb3993fcf7004143ec48dbfe5e2a
GitHub-Pull-Request: golang/go#37733
Reviewed-on: https://go-review.googlesource.com/c/go/+/222478
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Clément Chigot <clement.chigot%atos.net@gtempaccount.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
all: simplify code using "gofmt -s -w" 2019-05-06T22:19:22+00:00 Shulhan m.shulhan@gmail.com 2019-03-09T04:36:37+00:00 ed7f323c8f4f6bc61a75146bf34f5b8f73063a17 Most changes are removing redundant declaration of type when direct instantiating value of map or slice, e.g. []T{T{}} become []T{{}}. Small changes are removing the high order of subslice if its value is the length of slice itself, e.g. T[:len(T)] become T[:]. The following file is excluded due to incompatibility with go1.4, - src/cmd/compile/internal/gc/ssa.go Change-Id: Id3abb09401795ce1e6da591a89749cba8502fb26 Reviewed-on: https://go-review.googlesource.com/c/go/+/166437 Run-TryBot: Dave Cheney <dave@cheney.net> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> 
Most changes are removing redundant declaration of type when direct
instantiating value of map or slice, e.g. []T{T{}} become []T{{}}.

Small changes are removing the high order of subslice if its value
is the length of slice itself, e.g. T[:len(T)] become T[:].

The following file is excluded due to incompatibility with go1.4,

- src/cmd/compile/internal/gc/ssa.go

Change-Id: Id3abb09401795ce1e6da591a89749cba8502fb26
Reviewed-on: https://go-review.googlesource.com/c/go/+/166437
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
all: fix typos as reported by 'misspell' 2019-02-26T23:02:05+00:00 Leon Klingele git@leonklingele.de 2019-02-22T15:53:52+00:00 d090429ea9af7cc2958fd95460196b02212c2b62 Change-Id: I904b8655f21743189814bccf24073b6fbb9fc56d GitHub-Last-Rev: b032c14394c949f9ad7b18d019a3979d38d4e1fb GitHub-Pull-Request: golang/go#29997 Reviewed-on: https://go-review.googlesource.com/c/160421 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> 
Change-Id: I904b8655f21743189814bccf24073b6fbb9fc56d
GitHub-Last-Rev: b032c14394c949f9ad7b18d019a3979d38d4e1fb
GitHub-Pull-Request: golang/go#29997
Reviewed-on: https://go-review.googlesource.com/c/160421
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
internal/xcoff: add big archive support 2018-12-11T16:15:10+00:00 Clément Chigot clement.chigot@atos.net 2018-12-10T09:53:39+00:00 21da8e6022d1d148741ba3c08cdc555df500520e This commit adds support to read AIX big archive inside internal/xcoff package. Change-Id: I4317b40824b24312a69c918dfc6438dc3aff7be7 Reviewed-on: https://go-review.googlesource.com/c/153398 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> 
This commit adds support to read AIX big archive inside internal/xcoff
package.

Change-Id: I4317b40824b24312a69c918dfc6438dc3aff7be7
Reviewed-on: https://go-review.googlesource.com/c/153398
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
all: move cmd/internal/xcoff to internal/xcoff 2018-12-10T18:52:31+00:00 Clément Chigot clement.chigot@atos.net 2018-12-05T16:23:25+00:00 e256afff51f49c872975f5a5f73faa46ee64c334 This commit moves cmd/internal/xcoff package to internal/xcoff because it will be needed to add XCOFF support in go/internal/gccgoimporter. Change-Id: Id12df0c438fb7db4a6a458fc1478480851bf7771 Reviewed-on: https://go-review.googlesource.com/c/152719 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> 
This commit moves cmd/internal/xcoff package to internal/xcoff because
it will be needed to add XCOFF support in go/internal/gccgoimporter.

Change-Id: Id12df0c438fb7db4a6a458fc1478480851bf7771
Reviewed-on: https://go-review.googlesource.com/c/152719
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>