delta/go-git.git/src/encoding/asn1, branch dev.debug

encoding/asn1: add NullBytes and NullRawValue for working with ASN.1 NULL

2017-04-24T22:23:56+00:00

There were a number of places in crypto/x509 that used hardcoded
representations of the ASN.1 NULL type, in both byte slice and
RawValue struct forms. This change adds two new exported vars to
the asn1 package for working with ASN.1 NULL in both its forms, and
converts all usages from the x509 package.

In addition, tests were added to exercise Marshal and Unmarshal on
both vars.

See #19446 for discussion.

Change-Id: I63dbd0835841ccbc810bd6ec794360a84e933f1e
Reviewed-on: https://go-review.googlesource.com/38660
Run-TryBot: Adam Langley 
TryBot-Result: Gobot Gobot 
Reviewed-by: Adam Langley

encoding/asn1: support 31 bit identifiers with OID

2017-04-13T00:49:49+00:00

The current implementation uses a max of 28 bits when decoding an
ObjectIdentifier.  This change makes it so that an int64 is used to
accumulate up to 35 bits.  If the resulting data would not overflow
an int32, it is used as an int.  Thus up to 31 bits may be used to
represent each subidentifier of an ObjectIdentifier.

Fixes #19933

Change-Id: I95d74b64b24cdb1339ff13421055bce61c80243c
Reviewed-on: https://go-review.googlesource.com/40436
Reviewed-by: Adam Langley 
Run-TryBot: Adam Langley

encoding/asn1: document "utc" and "generalized" tags

2017-04-11T23:24:58+00:00

Also reformat tables.

Fixes #19889

Change-Id: I05083d2bab8bca46c4e22a415eb9b73513df6994
Reviewed-on: https://go-review.googlesource.com/40071
Reviewed-by: Brad Fitzpatrick

all: make spelling consistent

2016-12-08T23:22:37+00:00

Fixes #17938

Change-Id: Iad12155f4976846bd4a9a53869f89e40e5b3deb3
Reviewed-on: https://go-review.googlesource.com/34147
Run-TryBot: Brad Fitzpatrick 
TryBot-Result: Gobot Gobot 
Reviewed-by: Joe Tsai

encoding/asn1: document that default:x tag only has meaning with optional tag

2016-11-03T16:04:55+00:00

Fixes #16712.

Change-Id: Ib216059c6c0c952162c19e080dcf3799f0652a8d
Reviewed-on: https://go-review.googlesource.com/32171
Run-TryBot: Russ Cox 
TryBot-Result: Gobot Gobot 
Reviewed-by: Quentin Smith

encoding/asn1: return error for unexported fields in Marshal, Unmarshal

2016-11-03T03:44:05+00:00

The old code cannot handle unexported fields, it panics.
The new code returns error instead.

Fixes #17462

Change-Id: I927fc46b21d60e86cb52e84c65f2122f9159b21d
Reviewed-on: https://go-review.googlesource.com/31540
Run-TryBot: Russ Cox 
Reviewed-by: Russ Cox

encoding/asn1: return error instead of dereferencing nil *big.Int in marshaling

2016-10-17T22:29:32+00:00

Fixes #17461

Change-Id: I9954f6ae46c7e15560d7460841be8f2bc37233a9
Reviewed-on: https://go-review.googlesource.com/31121
Reviewed-by: Adam Langley 
Run-TryBot: Adam Langley 
TryBot-Result: Gobot Gobot

encoding/asn1: reduce allocations in Marshal

2016-09-13T21:05:27+00:00

Current code uses trees of bytes.Buffer as data representation.
Each bytes.Buffer takes 4k bytes at least, so it's waste of memory.
The change introduces trees of lazy-encoder as
alternative one which reduce allocations.

name       old time/op    new time/op    delta
Marshal-4    64.7µs ± 2%    42.0µs ± 1%  -35.07%   (p=0.000 n=9+10)

name       old alloc/op   new alloc/op   delta
Marshal-4    35.1kB ± 0%     7.6kB ± 0%  -78.27%  (p=0.000 n=10+10)

name       old allocs/op  new allocs/op  delta
Marshal-4       503 ± 0%       293 ± 0%  -41.75%  (p=0.000 n=10+10)

Change-Id: I32b96c20b8df00414b282d69743d71a598a11336
Reviewed-on: https://go-review.googlesource.com/27030
Reviewed-by: Adam Langley 
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Adam Langley 
TryBot-Result: Gobot Gobot

all: remove unnecessary type conversions

2016-04-15T07:31:45+00:00

cmd and runtime were handled separately, and I'm intentionally skipped
syscall. This is the rest of the standard library.

CL generated mechanically with github.com/mdempsky/unconvert.

Change-Id: I9e0eff886974dedc37adb93f602064b83e469122
Reviewed-on: https://go-review.googlesource.com/22104
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Matthew Dempsky 
TryBot-Result: Gobot Gobot

all: replace magic 0x80 with named constant utf8.RuneSelf

2016-04-10T15:15:57+00:00

Change-Id: Id1c2e8e9d60588de866e8b6ca59cc83dd28f848f
Reviewed-on: https://go-review.googlesource.com/21756
Reviewed-by: Brad Fitzpatrick 
Run-TryBot: Brad Fitzpatrick 
TryBot-Result: Gobot Gobot