delta/go-git.git/src/cmd/internal/browser, branch dev.cmdgo github.com: golang/go all: introduce and use internal/execabs 2021-01-21T19:10:18+00:00 Roland Shoemaker roland@golang.org 2021-01-15T20:14:06+00:00 953d1feca9b21af075ad5fc8a3dad096d3ccc3a0 Introduces a wrapper around os/exec, internal/execabs, for use in all commands. This wrapper prevents exec.LookPath and exec.Command from running executables in the current directory. All imports of os/exec in non-test files in cmd/ are replaced with imports of internal/execabs. This issue was reported by RyotaK. Fixes CVE-2021-3115 Fixes #43783 Change-Id: I0423451a6e27ec1e1d6f3fe929ab1ef69145c08f Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/955304 Reviewed-by: Russ Cox <rsc@google.com> Reviewed-by: Katie Hockman <katiehockman@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/284783 Run-TryBot: Roland Shoemaker <roland@golang.org> Reviewed-by: Katie Hockman <katie@golang.org> Trust: Roland Shoemaker <roland@golang.org> 
Introduces a wrapper around os/exec, internal/execabs, for use in
all commands. This wrapper prevents exec.LookPath and exec.Command from
running executables in the current directory.

All imports of os/exec in non-test files in cmd/ are replaced with
imports of internal/execabs.

This issue was reported by RyotaK.

Fixes CVE-2021-3115
Fixes #43783

Change-Id: I0423451a6e27ec1e1d6f3fe929ab1ef69145c08f
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/955304
Reviewed-by: Russ Cox <rsc@google.com>
Reviewed-by: Katie Hockman <katiehockman@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/284783
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Trust: Roland Shoemaker <roland@golang.org>
cmd/internal/browser: fix typo 2017-02-24T20:49:10+00:00 Kevin Burke kev@inburke.com 2017-02-24T20:07:25+00:00 67fcd9c5d9f84e4f66df1e357ca9f76523ecff4e Change-Id: I3c31f10c1082c7bc57aac18856014c55f79e0fed Reviewed-on: https://go-review.googlesource.com/37409 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> 
Change-Id: I3c31f10c1082c7bc57aac18856014c55f79e0fed
Reviewed-on: https://go-review.googlesource.com/37409
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
cmd/internal/browser: wait 3 seconds for non-zero exit codes 2017-02-24T19:14:12+00:00 Chris Broadfoot cbro@golang.org 2017-02-22T23:50:24+00:00 2818cb5c9e183aed539d6a539a821e229671fe56 Wait a short period between trying commands. Many commands will return a non-zero exit code if the browser couldn't be launched. For example, google-chrome returns quickly with a non-zero exit code in a headless environment. Updates #19131. Change-Id: I0ae5356dd4447969d9e216615449cead7a8fd5c9 Reviewed-on: https://go-review.googlesource.com/37391 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> 
Wait a short period between trying commands. Many commands
will return a non-zero exit code if the browser couldn't be launched.

For example, google-chrome returns quickly with a non-zero
exit code in a headless environment.

Updates #19131.

Change-Id: I0ae5356dd4447969d9e216615449cead7a8fd5c9
Reviewed-on: https://go-review.googlesource.com/37391
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
cmd/internal/browser: use xdg-open only from a desktop session 2017-02-23T19:17:15+00:00 Chris Broadfoot cbro@golang.org 2017-02-22T23:48:38+00:00 d580972d5933c77d9319ec99ff1b2f111f05c727 xdg-open's man page says: > xdg-open is for use inside a desktop session only. Use the DISPLAY environment variable to detect this. Updates #19131. Change-Id: I3926b3e1042393939b2ec6aacd9b63ac8192df3b Reviewed-on: https://go-review.googlesource.com/37390 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> 
xdg-open's man page says:
> xdg-open is for use inside a desktop session only.

Use the DISPLAY environment variable to detect this.

Updates #19131.

Change-Id: I3926b3e1042393939b2ec6aacd9b63ac8192df3b
Reviewed-on: https://go-review.googlesource.com/37390
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
cmd/internal/browser: add chromium to the list of browsers 2016-11-12T00:29:12+00:00 Daniel Martí mvdan@mvdan.cc 2016-09-17T14:01:55+00:00 241dccc4fdaf32830fa32a38a9c7953584b57a17 Many linux distros distribute Chromium instead of Chrome. Change-Id: I5474d94da28a7c79bdd7181f77472d4ce73bb225 Reviewed-on: https://go-review.googlesource.com/29293 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> 
Many linux distros distribute Chromium instead of Chrome.

Change-Id: I5474d94da28a7c79bdd7181f77472d4ce73bb225
Reviewed-on: https://go-review.googlesource.com/29293
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd: add internal/browser package 2016-09-14T18:26:33+00:00 Josh Bleecher Snyder josharian@gmail.com 2016-09-14T18:16:50+00:00 33ed35647520f2162c2fed1b0e5f19cec2c65de3 cmd/cover, cmd/trace, and cmd/pprof all open browsers. 'go bug' will soon also open a browser. It is time to unify the browser-handling code. Change-Id: Iee6b443e21e938aeaaac366a1aefb1afbc7d9b2c Reviewed-on: https://go-review.googlesource.com/29160 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> 
cmd/cover, cmd/trace, and cmd/pprof all open browsers.
'go bug' will soon also open a browser.
It is time to unify the browser-handling code.

Change-Id: Iee6b443e21e938aeaaac366a1aefb1afbc7d9b2c
Reviewed-on: https://go-review.googlesource.com/29160
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>