Fix spelling of "original" and "occurred" in new gofmt docs. The same misspelling of "occurred" was also present in crypto/tls, I fixed it there as well. Change-Id: I67b4f1c09bd1a2eb1844207d5514f08a9f525ff9 Reviewed-on: https://go-review.googlesource.com/33138 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This reverts the changes from https://golang.org/cl/33018: Instead of writing the result of gofmt to a tmp file and then rename that to the original (which doesn't preserve the original file's perm bits, uid, gid, and possibly other properties because it is hard to do in a platform-independent way - see #17869), use the original code that simply overwrites the processed file if gofmt was able to create a backup first. Upon success, the backup is removed, otherwise it remains. Fixes #17873. For #8984. Change-Id: Ifcf2bf1f84f730e6060f3517d63b45eb16215ae1 Reviewed-on: https://go-review.googlesource.com/33098 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Change-Id: If697ab554e6cb5545d99c6b103ed8bc54f69ed48 Reviewed-on: https://go-review.googlesource.com/4161 Reviewed-by: Andrew Gerrand <adg@golang.org>
This CL adjusts code referring to src/pkg to refer to src. Immediately after submitting this CL, I will submit a change doing 'hg mv src/pkg/* src'. That change will be too large to review with Rietveld but will contain only the 'hg mv'. This CL will break the build. The followup 'hg mv' will fix it. For more about the move, see golang.org/s/go14nopkg. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/134570043
Having these flags misleads people into thinking they're acceptable for code that "must be gofmt'd". If an organization wishes to use gofmt internally with different settings, they can fork gofmt trivially. But "gofmt" as used by the community with open source Go code should not support these old knobs. Also removes the -comments flag. Fixes #7101 R=r, gri CC=golang-codereviews https://golang.org/cl/52170043
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/13721043
Also: - faster code for example extraction - simplify handling of command documentation: all "main" packages are treated as commands - various minor cleanups along the way For commands written in Go, any doc.go file containing documentation must now be part of package main (rather then package documentation), otherwise the documentation won't show up in godoc (it will still build, though). For commands written in C, documentation may still be in doc.go files defining package documentation, but the recommended way is to explicitly ignore those files with a +build ignore constraint to define package main. Fixes #4806. R=adg, rsc, dave, bradfitz CC=golang-dev https://golang.org/cl/7333046
-tabs replaces -tabindent -spaces has been removed R=golang-dev, adg, rsc CC=golang-dev https://golang.org/cl/5487066
This makes it possible to grab a block of code in an editor and pipe it through gofmt, instead of having to pipe in the entire file. R=gri CC=golang-dev https://golang.org/cl/4973074
Also: - Add parser.SpuriousError flag. If set, the parser reports all (including spurious) errors rather then at most one error per line. - Add -e flag to gofmt and gotype: If set, gofmt and gotype report all (including spurious) errors rather than at most one error per line. - Updated the respective documentation. Fixes #2088. R=rsc CC=golang-dev https://golang.org/cl/4803047