delta/go-git.git/src/cmd/api, branch master

cmd/api: move support checks into individual tests

2023-05-03T14:35:45+00:00

This makes 'go test -list cmd/api' work, and fixes an infinite
recursion via testenv.HasExec that would otherwise occur.
As of CL 488076, testenv.HasExec tries to re-exec the test
executable using -list to suppress running the tests, which
produces a fork bomb if TestMain itself calls HasExec.

For this test, it turns out that the HasExec check is redundant
anyway: if we can exec 'go build', we can certainly exec programs in
general too.

Change-Id: I165f98315c181098c8be8b7525b9dfa3f98e14f6
Reviewed-on: https://go-review.googlesource.com/c/go/+/491656
TryBot-Result: Gopher Robot 
Reviewed-by: Austin Clements 
Run-TryBot: Bryan Mills 
Auto-Submit: Bryan Mills

cmd/api: remove unused functionality

2023-04-27T14:07:10+00:00

We no longer use the optional parameter to compareAPI.
We now always set allowAdd to false.
(Except in tests, making them less useful than they could be.)
Flags and parsing their value are no more.

Remove all the unused functionality and update test cases so they're
closer to what the API checker does when it runs for real. Order the
features, required, exception variables and fields more consistently.

For #43956.

Change-Id: Iaa4656a89a3fca3129742165a448d385e55e4a98
Reviewed-on: https://go-review.googlesource.com/c/go/+/489436
Auto-Submit: Dmitri Shuralyov 
Reviewed-by: Bryan Mills 
Run-TryBot: Dmitri Shuralyov 
Reviewed-by: Dmitri Shuralyov 
TryBot-Result: Gopher Robot

cmd/api: make api/next/* entries required, not optional

2023-04-27T14:06:36+00:00

We want the API check to catch if some API present in api/next/*
files is no longer implemented in the tree, and report it in the
same CL that is making the change (by failing loudly). Arguably
this should've been the case since CL 315350, but I didn't notice
it at the time. Do it now.

For #43956.

Change-Id: I73330dd5fd3f5706a1fdf13b2bf8e0f24c6b48e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/488135
Reviewed-by: Dmitri Shuralyov 
Run-TryBot: Dmitri Shuralyov 
TryBot-Result: Gopher Robot 
Reviewed-by: Bryan Mills 
Auto-Submit: Dmitri Shuralyov

cmd/api: add API checks for freebsd/riscv64

2023-02-17T21:23:32+00:00

The freebsd/riscv64 port was added in go1.20, make cmd/api aware of it and
backfill API files.

For #58582

Change-Id: I242b161cdb6221c8f60a1868c6435be26fca0078
Reviewed-on: https://go-review.googlesource.com/c/go/+/469135
Run-TryBot: Dmitri Goutnik 
TryBot-Result: Gopher Robot 
Auto-Submit: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Ian Lance Taylor 
Reviewed-by: Bryan Mills

cmd/api: add API checks for freebsd/arm64

2023-02-17T20:31:46+00:00

The freebsd/arm64 port was added in go1.14, make cmd/api aware of it and
backfill API files.

For #58582

Change-Id: I8b25c6cf5a66611d90d225762b257679a4abface
Reviewed-on: https://go-review.googlesource.com/c/go/+/469115
Reviewed-by: Bryan Mills 
Auto-Submit: Ian Lance Taylor 
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Dmitri Goutnik 
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gopher Robot

cmd/api: track darwin arm64 port

2022-12-02T16:30:41+00:00

The darwin arm64 port was added in Go 1.16 and is a first-class port,
so it should be tracked by cmd/api. This CL does that, backfilling
API files as needed.

It also removes a spurious cgo.Incomplete API feature.

Change-Id: Idd995677915e81bf1c2e09be65b31e084b75f668
Reviewed-on: https://go-review.googlesource.com/c/go/+/453260
Reviewed-by: Ian Lance Taylor 
Reviewed-by: Cherry Mui 
Auto-Submit: Russ Cox 
Run-TryBot: Russ Cox 
TryBot-Result: Gopher Robot

cmd/api: track deprecations

2022-12-02T16:29:41+00:00

Deprecating an API creates notices that go out to potentially
millions of Go developers encouraging them to update their code.
The choice to deprecate an API is as important as the choice to
add a new API. We should track those and make them explicit.
This will also ensure that deprecations go through proposal review.

Change-Id: Ide9f60c32e5a88fb133e0dfedd984b8b0f70f510
Reviewed-on: https://go-review.googlesource.com/c/go/+/453259
TryBot-Result: Gopher Robot 
Run-TryBot: Russ Cox 
Auto-Submit: Russ Cox 
Reviewed-by: David Chase

cmd/api: rewrite as package test

2022-11-28T16:27:03+00:00

No one ever runs 'go tool api', because the invocation
has gotten unwieldy enough that it's not practical.
And we don't support it as a standalone tool for other
packages - it's not even in the distribution.

Making it an ordinary package test lets us invoke it
more easily from cmd/dist (as go test cmd/api -check)
and avoids the increasingly baroque code in run.go to
build a command line.

Left in cmd/api even though it's no longer a command
because (1) it uses a package from cmd/vendor and
(2) it uses internal/testenv. Otherwise it could be misc/api.

Fixes #56845.

Change-Id: I00a13d9c19b1e259fa0e6bb93d1a4dca25f0e8c1
Reviewed-on: https://go-review.googlesource.com/c/go/+/453258
Auto-Submit: Russ Cox 
TryBot-Result: Gopher Robot 
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Russ Cox

cmd/api: point to API docs in all.bash failure

2022-11-10T04:08:52+00:00

When people add new API and get an all.bash failure,
they often don't know about the API checker at all.
Point to the README in the failure message, to try to
help them find what they need to know.

Change-Id: I6b148ec414d212033b371357a5e8c6ab79bb50a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/449015
TryBot-Result: Gopher Robot 
Run-TryBot: Russ Cox 
Reviewed-by: Ian Lance Taylor 
Reviewed-by: Dmitri Shuralyov

all: add missing copyright header

2022-11-09T14:05:53+00:00

Change-Id: Ia5a090953d324f0f8aa9c1808c88125ad5eb6f98
Reviewed-on: https://go-review.googlesource.com/c/go/+/448955
TryBot-Result: Gopher Robot 
Reviewed-by: Bryan Mills 
Auto-Submit: Bryan Mills 
Reviewed-by: Michael Knyszek 
Run-TryBot: Bryan Mills