delta/go-git.git/src/archive, branch master

all: add String for fs.{FileInfo,DirEntry} implementations

2023-05-04T16:27:35+00:00

The new String methods use the new FormatFileInfo and
FormatDirEntry functions.

Fixes #54451

Change-Id: I414cdfc212ec3c316fb2734756d2117842a23631
Reviewed-on: https://go-review.googlesource.com/c/go/+/491175
Reviewed-by: Joseph Tsai 
Run-TryBot: Ian Lance Taylor 
TryBot-Result: Gopher Robot 
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor 
Auto-Submit: Ian Lance Taylor 
Reviewed-by: Bryan Mills

archive/zip: reject overflowing directorySize & directoryOffset

2023-04-24T20:28:37+00:00

We added a check for incorrect baseOffset in CL 408734, but in doing so
we introduced a panic when directoryOffset overflowed a int64. The zip
spec uses uint64, but since io.SectionReader requires int64 we convert,
and possibly introduce an overflow. If offset < 0 && size-offset < 0,
SectionReader will panic when we attempt to read from it.

Since it's extremely unlikely we're ever going to process a zip file
larger than 1<<63-1 byte, just limit directory size and offset to the
max int64.

Change-Id: I1aaa755cf4da927a6e12ef59f97dfc83a3426d86
Reviewed-on: https://go-review.googlesource.com/c/go/+/488195
Reviewed-by: Ian Lance Taylor 
Run-TryBot: Roland Shoemaker 
TryBot-Result: Gopher Robot 
Auto-Submit: Roland Shoemaker

archive/zip: return ErrInsecurePath for unsafe paths by OpenReader

2023-04-05T15:11:02+00:00

zip.NewReader was recently improved to return ErrInsecurePath when
insecure entries are encountered.
This change adopts the same logic for the OpenReader interface as well.

Fixes #58641

Change-Id: I0d8be94d073cc14cf93a914dc250f85b19cec4ab
GitHub-Last-Rev: 68391dc51562aebc893ec70fdfbdfb181955983a
GitHub-Pull-Request: golang/go#58658
Reviewed-on: https://go-review.googlesource.com/c/go/+/470735
Run-TryBot: Damien Neil 
TryBot-Result: Gopher Robot 
Reviewed-by: Damien Neil 
Reviewed-by: Dmitri Shuralyov 
Auto-Submit: Damien Neil

all: fix misuses of "a" vs "an"

2023-04-04T14:20:53+00:00

Fixes the misuse of "a" vs "an", according to English grammatical
expectations and using https://www.a-or-an.com/

Change-Id: I53ac724070e3ff3d33c304483fe72c023c7cda47
Reviewed-on: https://go-review.googlesource.com/c/go/+/480536
Run-TryBot: shuang cui 
Reviewed-by: Ian Lance Taylor 
TryBot-Result: Gopher Robot 
Auto-Submit: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor 
Reviewed-by: Michael Knyszek

archive/zip: make receiver names consistent

2023-03-02T23:34:34+00:00

Fixes revive linter receiver-naming warnings:

- receiver name f should be consistent with previous receiver name e for fileListEntry
- receiver name r should be consistent with previous receiver name z for Reader
- receiver name f should be consistent with previous receiver name h for FileHeader

Change-Id: Ibfa14b97f6ca7adc86e3a1df919c5bb5de9716dc
GitHub-Last-Rev: dd7315b09d224bb2953b82cc6bd97d81c9eaca0a
GitHub-Pull-Request: golang/go#58477
Reviewed-on: https://go-review.googlesource.com/c/go/+/467519
Run-TryBot: Ian Lance Taylor 
Auto-Submit: Ian Lance Taylor 
Reviewed-by: Joseph Tsai 
Reviewed-by: Dmitri Shuralyov 
Reviewed-by: Ian Lance Taylor 
TryBot-Bypass: Ian Lance Taylor

archive/zip: use base offset 0 if it has a valid entry

2023-01-20T01:04:11+00:00

In CL 408734 we introduced a fall back to base offset 0 if reading a
directory entry at the computed base offset failed. We have now found
a file in the wild for which the computed base offset is incorrect,
but happens to refer to a valid directory entry. In this CL, we change
the fallback such that if the first directory header relative to base
offset 0 is valid, we just use base offset 0.

Change-Id: Ia9ace20c1065d1f651035f16f7d91d741ab1dbf4
Reviewed-on: https://go-review.googlesource.com/c/go/+/461598
Reviewed-by: Cherry Mui 
TryBot-Result: Gopher Robot 
Reviewed-by: Ian Lance Taylor 
Auto-Submit: Ian Lance Taylor 
Reviewed-by: Joseph Tsai 
Run-TryBot: Ian Lance Taylor 
Run-TryBot: Ian Lance Taylor

internal/godebug: export non-default-behavior counters in runtime/metrics

2023-01-19T22:26:43+00:00

Allow GODEBUG users to report how many times a setting
resulted in non-default behavior.

Record non-default-behaviors for all existing GODEBUGs.

Also rework tests to ensure that runtime is in sync with runtime/metrics.All,
and generate docs mechanically from metrics.All.

For #56986.

Change-Id: Iefa1213e2a5c3f19ea16cd53298c487952ef05a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/453618
TryBot-Result: Gopher Robot 
Auto-Submit: Russ Cox 
Run-TryBot: Russ Cox 
Reviewed-by: Michael Knyszek

archive/tar, archive/zip: document ErrInsecurePath and GODEBUG setting

2023-01-17T14:18:16+00:00

These are mentioned in the release notes but not the actual doc comments.
Nothing should exist only in release notes.

Change-Id: I8d10f25a2c9b2677231929ba3f393af9034b777b
Reviewed-on: https://go-review.googlesource.com/c/go/+/462195
Run-TryBot: Russ Cox 
Reviewed-by: Damien Neil 
TryBot-Result: Gopher Robot

archive/tar, archive/zip: revert documentation of ErrInsecurePath

2022-12-21T18:56:55+00:00

CL 452616 disables path security checks by default, enabling them
only when GODEBUG=tarinsecurepath=0 or GODEBUG=zipinsecurepath=0
is set. Remove now-obsolete documenation of the path checks.

For #55356

Change-Id: I4ae57534efe9e27368d5e67773a502dd0e56eff4
Reviewed-on: https://go-review.googlesource.com/c/go/+/458875
Reviewed-by: Russ Cox 
TryBot-Result: Gopher Robot 
Run-TryBot: Damien Neil

archive/zip: only consider UncompressedSize when checking dirs

2022-12-06T20:19:47+00:00

CL 454475 switched from checking CompressedSize to UncompressedSize
when determining if we should consider an archive malformed because
it contains data and added a test for an example of this (a JAR). We
should also remove the hasDataDescriptor check, since that is basically
an alias for CompressedSize > 0. The test didn't catch this because we
didn't actually attempt to read from the returned reader.

Change-Id: Ibc4c1aa9c3a733f3ebf4a956d1e2f8f4900a29cd
Reviewed-on: https://go-review.googlesource.com/c/go/+/455523
Run-TryBot: Roland Shoemaker 
Reviewed-by: Julie Qiu 
Auto-Submit: Roland Shoemaker 
TryBot-Result: Gopher Robot