delta/go-git.git/misc/android, branch dev.typealias github.com: golang/go misc/android: make the exec wrapper exit code parsing more robust 2016-06-08T05:24:53+00:00 Elias Naur elias.naur@gmail.com 2016-06-03T09:41:26+00:00 09eedc32e13484d9171519e9f07f3210ba5a7afd Before, the Android exec wrapper expected the trailing exit code output on its own line, like this: PASS exitcode=0 However, some tests can sometimes squeeze in some output after the test harness outputs "PASS" and the newline. The TestWriteHeapDumpFinalizers test is particularly prone to this, since its finalizers println to standard out. When it happens, the output looks like this: PASS finalizedexitcode=0 Two recent failures caused by this race: https://build.golang.org/log/185605e1b936142c22350eef22d20e982be53c29 https://build.golang.org/log/e61cf6a050551d10360bd90be3c5f58c3eb07605 Since the "exitcode=" string is always echoed after the test output, the fix is simple: instead of looking for the last newline in the output, look for the last exitcode string instead. Change-Id: Icd6e53855eeba60b982ad3108289d92549328b86 Reviewed-on: https://go-review.googlesource.com/23750 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> 
Before, the Android exec wrapper expected the trailing exit code
output on its own line, like this:

PASS
exitcode=0

However, some tests can sometimes squeeze in some output after
the test harness outputs "PASS" and the newline. The
TestWriteHeapDumpFinalizers test is particularly prone to this,
since its finalizers println to standard out. When it happens, the
output looks like this:

PASS
finalizedexitcode=0

Two recent failures caused by this race:

https://build.golang.org/log/185605e1b936142c22350eef22d20e982be53c29
https://build.golang.org/log/e61cf6a050551d10360bd90be3c5f58c3eb07605

Since the "exitcode=" string is always echoed after the test output,
the fix is simple: instead of looking for the last newline in the
output, look for the last exitcode string instead.

Change-Id: Icd6e53855eeba60b982ad3108289d92549328b86
Reviewed-on: https://go-review.googlesource.com/23750
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
all: make copyright headers consistent with one space after period 2016-05-02T13:43:18+00:00 Emmanuel Odeke emm.odeke@gmail.com 2016-04-10T21:32:26+00:00 53fd522c0db58f3bd75d85295f46bb06e8ab1a9b Follows suit with https://go-review.googlesource.com/#/c/20111. Generated by running $ grep -R 'Go Authors. All' * | cut -d":" -f1 | while read F;do perl -pi -e 's/Go Authors. All/Go Authors. All/g' $F;done The code in cmd/internal/unvendor wasn't changed. Fixes #15213 Change-Id: I4f235cee0a62ec435f9e8540a1ec08ae03b1a75f Reviewed-on: https://go-review.googlesource.com/21819 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> 
Follows suit with https://go-review.googlesource.com/#/c/20111.

Generated by running
$ grep -R 'Go Authors.  All' * | cut -d":" -f1 | while read F;do perl -pi -e 's/Go
Authors.  All/Go Authors. All/g' $F;done

The code in cmd/internal/unvendor wasn't changed.

Fixes #15213

Change-Id: I4f235cee0a62ec435f9e8540a1ec08ae03b1a75f
Reviewed-on: https://go-review.googlesource.com/21819
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
misc/android: cleaner to remove stale GOROOT files 2015-05-25T20:52:10+00:00 David Crawshaw crawshaw@golang.org 2015-05-25T11:20:07+00:00 9c37a23bcb178351d70c2d90e8915b9e413d59b8 Updates #10806 Change-Id: I734d6db026cc7c2e3099a76dc8db8e42b2b90aa7 Reviewed-on: https://go-review.googlesource.com/10390 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> 
Updates #10806

Change-Id: I734d6db026cc7c2e3099a76dc8db8e42b2b90aa7
Reviewed-on: https://go-review.googlesource.com/10390
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
misc/android: choose the right subdirectory for bin under GOPATH. 2015-01-16T22:02:52+00:00 Hyang-Ah Hana Kim hakim@google.com 2015-01-15T21:47:41+00:00 d5d4e82fb28f506701791f622ec0b03b984e41a5 This change includes the cleanup of temporary files created during the binary execution as well. Change-Id: Ic01a0a537d1daafcaa3acda1ec344aff5dcddfc2 Reviewed-on: https://go-review.googlesource.com/2903 Reviewed-by: David Crawshaw <crawshaw@golang.org> 
This change includes the cleanup of temporary files created during
the binary execution as well.

Change-Id: Ic01a0a537d1daafcaa3acda1ec344aff5dcddfc2
Reviewed-on: https://go-review.googlesource.com/2903
Reviewed-by: David Crawshaw <crawshaw@golang.org>
build: adjustments for move from src/pkg to src 2014-09-08T04:06:45+00:00 Russ Cox rsc@golang.org 2014-09-08T04:06:45+00:00 220a6de47eced55956eb8af8d643d4f5b67fd634 This CL adjusts code referring to src/pkg to refer to src. Immediately after submitting this CL, I will submit a change doing 'hg mv src/pkg/* src'. That change will be too large to review with Rietveld but will contain only the 'hg mv'. This CL will break the build. The followup 'hg mv' will fix it. For more about the move, see golang.org/s/go14nopkg. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/134570043 
This CL adjusts code referring to src/pkg to refer to src.

Immediately after submitting this CL, I will submit
a change doing 'hg mv src/pkg/* src'.
That change will be too large to review with Rietveld
but will contain only the 'hg mv'.

This CL will break the build.
The followup 'hg mv' will fix it.

For more about the move, see golang.org/s/go14nopkg.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/134570043
androidtest.bash, misc/android: build scripts for android 2014-07-09T10:56:49+00:00 David Crawshaw david.crawshaw@zentus.com 2014-07-09T10:56:49+00:00 a5f8e8f99cbac0cfecd3baa869d111bacfbaeac4 LGTM=minux R=minux CC=golang-codereviews https://golang.org/cl/107640044 
LGTM=minux
R=minux
CC=golang-codereviews
https://golang.org/cl/107640044