delta/go-git.git, branch dev.gcfe github.com: golang/go misc/nacl: include parser.go for cmd/compile/internal/syntax tests 2016-08-16T22:42:13+00:00 Matthew Dempsky mdempsky@google.com 2016-08-16T22:25:01+00:00 e809658d77616c0af4213ae25797ea861076a484 Fix suggested by Minux. Change-Id: Ia7aa8ccccc16535af4ec3ad23830ef0aa5d776ac Reviewed-on: https://go-review.googlesource.com/27193 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Minux Ma <minux@golang.org> 
Fix suggested by Minux.

Change-Id: Ia7aa8ccccc16535af4ec3ad23830ef0aa5d776ac
Reviewed-on: https://go-review.googlesource.com/27193
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Minux Ma <minux@golang.org>
cmd/compile/internal/syntax: match old parser errors and line numbers 2016-08-16T21:32:09+00:00 Matthew Dempsky mdempsky@google.com 2016-06-07T00:59:05+00:00 504a104a2cbc7e7e2a1c01be31c97f363369fe3e This makes a bunch of changes to package syntax to tweak line numbers for AST nodes. For example, short variable declaration statements are now associated with the location of the ":=" token, and function calls are associated with the location of the final ")" token. These help satisfy many unit tests that assume the old parser's behavior. Because many of these changes are questionable, they're guarded behind a new "gcCompat" const to make them easy to identify and revisit in the future. A handful of remaining tests are too difficult to make behave identically. These have been updated to execute with -newparser=0 and comments explaining why they need to be fixed. all.bash now passes with both the old and new parsers. Change-Id: Iab834b71ca8698d39269f261eb5c92a0d55a3bf4 
This makes a bunch of changes to package syntax to tweak line numbers
for AST nodes. For example, short variable declaration statements are
now associated with the location of the ":=" token, and function calls
are associated with the location of the final ")" token. These help
satisfy many unit tests that assume the old parser's behavior.

Because many of these changes are questionable, they're guarded behind
a new "gcCompat" const to make them easy to identify and revisit in
the future.

A handful of remaining tests are too difficult to make behave
identically. These have been updated to execute with -newparser=0 and
comments explaining why they need to be fixed.

all.bash now passes with both the old and new parsers.

Change-Id: Iab834b71ca8698d39269f261eb5c92a0d55a3bf4
cmd/compile/internal/gc: use new AST parser 2016-08-16T21:32:09+00:00 Matthew Dempsky mdempsky@google.com 2016-05-07T06:17:29+00:00 29cfbcfef42cc1ae77b35fb2cd65245e8ce8f706 Introduce a new noder type to transform package syntax's AST into gc's Node tree. Hidden behind a new -newparser flag. Change-Id: Id0e862ef6196c41533876afc4ec289e21d422d18 
Introduce a new noder type to transform package syntax's AST into gc's
Node tree. Hidden behind a new -newparser flag.

Change-Id: Id0e862ef6196c41533876afc4ec289e21d422d18
cmd/dist: build cmd/compile/internal/syntax 2016-08-16T21:32:09+00:00 Matthew Dempsky mdempsky@google.com 2016-05-07T06:16:15+00:00 55b9234023a224e047dcb2ef4796091f79ee3453 Change-Id: Ie6dd2318e031be445c0b1ae65d4c78723d5a1167 
Change-Id: Ie6dd2318e031be445c0b1ae65d4c78723d5a1167
cmd/compile/internal/syntax: add a Line method to interface Node 2016-08-16T21:32:09+00:00 Matthew Dempsky mdempsky@google.com 2016-08-16T20:33:29+00:00 d6d493fc569ce5e8925843da213cea249ce34aae Change-Id: I64baf334a35c72336d26fa6755c67eb9d6f4e93c 
Change-Id: I64baf334a35c72336d26fa6755c67eb9d6f4e93c
cmd/compile/internal/syntax: refactor DeclStmt parsing 2016-08-16T21:32:09+00:00 Matthew Dempsky mdempsky@google.com 2016-06-27T21:51:54+00:00 4bc85b2eb8664470c131517d9fab1090827857b6 No behavior change. Change-Id: I93c7cb7ab76b5afa74e6a1f092b7045fb96467b1 
No behavior change.

Change-Id: I93c7cb7ab76b5afa74e6a1f092b7045fb96467b1
cmd/compile/internal/syntax: emit errors for unexpected top-level tokens 2016-08-16T21:32:09+00:00 Matthew Dempsky mdempsky@google.com 2016-06-10T21:18:29+00:00 83153e7f372a5822a771e132885633cd24d3df12 Fixes cmd/go's TestIssue7108. Change-Id: I8436b0e3e5a9b36649d46a9c2c741d820115a5d1 
Fixes cmd/go's TestIssue7108.

Change-Id: I8436b0e3e5a9b36649d46a9c2c741d820115a5d1
cmd/compile/internal/syntax: change Read to still return the AST 2016-08-16T21:32:09+00:00 Matthew Dempsky mdempsky@google.com 2016-08-16T18:27:55+00:00 7a8201b92470c729e4e30fd22d16dca600ec9b7e If we the caller provided an error handler, still return our best effort parsed AST tree. 
If we the caller provided an error handler, still return our best
effort parsed AST tree.
cmd/compile/internal/syntax: fix off-by-1 for implicit semicolons 2016-08-16T21:32:08+00:00 Matthew Dempsky mdempsky@google.com 2016-06-10T22:31:25+00:00 38d52ef0c49035d00d753f9fe192c4f66f3f8ccc pos and line already refer to the position immediately before the returned newline character, so no need to decrement them further. Change-Id: I1d7a32cde55a5b8a1c6fd882ec8ba532869cc858 
pos and line already refer to the position immediately before the
returned newline character, so no need to decrement them further.

Change-Id: I1d7a32cde55a5b8a1c6fd882ec8ba532869cc858
cmd/compile/internal/syntax: better error positions for scanner errors 2016-08-16T21:32:08+00:00 Robert Griesemer gri@golang.org 2016-06-10T21:34:00+00:00 f82bd3cc7d49491d43846907e4a1e63f1e42cef9 For string/comment not terminated errors, report error at the start of the string/comment rather than the end of the file. 
For string/comment not terminated errors, report error at the
start of the string/comment rather than the end of the file.