delta/gnutls.git/lib, branch tmp-cli-buffer-term

ext/key_share: check the validity of server key shares

2018-07-27T12:13:35+00:00

That is, when generating the public key based on the server's
key share, ensure that the algorithms match completely with
the key shares the client initially sent. This was detected
by the updated traces for TLS1.3 fuzzying.

Signed-off-by: Nikos Mavrogiannopoulos

gnutls.h: corrected typo

2018-07-25T14:41:38+00:00

Signed-off-by: Nikos Mavrogiannopoulos

send_client_hello: don't override version after HRR is received

2018-07-25T13:32:45+00:00

When a Hello Retry Request is received, do not set our (transient)
version to TLS1.2 on the second client hello. That's because both
peers have already negotiated TLS1.3.

This addresses issue with peers which may send a changecipherspec
message at this stage, which is now allowed when our version is
set to be TLS1.2. Introduced test suite using openssl and resumption
using HRR which reproduces the issue.

Signed-off-by: Nikos Mavrogiannopoulos

hello_ext_parse: apply the test for pre-shared key ext being last on client hello

2018-07-25T11:11:17+00:00

We were incorrectly insisting on pre-shared key extension being last in
both client and server hello. That was incorrect, as only in client hello
it is required by TLS1.3 to be last.

Quoting:
   The "pre_shared_key" extension MUST be the last extension in the
   ClientHello (this facilitates implementation as described below).
   Servers MUST check that it is the last extension and otherwise fail
   the handshake with an "illegal_parameter" alert.

Resolves #525

Signed-off-by: Nikos Mavrogiannopoulos

allow no certificates to be reported by the gnutls_certificate_retrieve_function callbacks

2018-07-24T20:06:03+00:00

In 9829ef9a we introduced a wrapper over the older callback functions
which didn't handle this case.

Resolves #528

Signed-off-by: Nikos Mavrogiannopoulos

cert-cred: fix possible segfault when resetting cert retrieval function

2018-07-24T07:39:57+00:00

Reset get_cert_callback3 callback to NULL if provided callback is NULL.
Otherwise after the certificate request call_legacy_cert_cb1 /
call_legacy_cert_cb2 will try to unconditionally call legacy_cert_cb1 /
legacy_cert_cb2 callback (set to NULL) leading to segfault.

Fixes: 9829ef9a3ca06d60472599df7c74ebb9a53f1fe2
Signed-off-by: Dmitry Eremin-Solenikov

kx: for uniformity print master secret size

2018-07-23T15:20:20+00:00

During keys setup phase debug log will contain sizes of all keys and
secrets, except master secret. Dump MS length (48) to log for
uniformity.

Signed-off-by: Dmitry Eremin-Solenikov

constate: dump full key block to log

2018-07-23T15:20:20+00:00

Include full key block to the debug log.

Signed-off-by: Dmitry Eremin-Solenikov

constate: dump MAC keys to debug log

2018-07-23T15:20:20+00:00

_gnutls_set_keys() can dump client/server write keys/ivs to debug log,
but it skips MAC keys. Add MAC keys to log.

Signed-off-by: Dmitry Eremin-Solenikov

constate: drop unused variable in _gnutls_set_keys

2018-07-23T15:20:20+00:00

_gnutls_set_keys() creates rrnd as client random + server random, but
does not use it (it was used before for export key generation, but was
not removed when dropping support for export cipher suites).

Signed-off-by: Dmitry Eremin-Solenikov 
Fixes: 8bdb8d53aa5b4c5d04255b6c9b5f2dac8b23d51b