| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is especially important for libstdc++ on distributions that
don't have it directly in a libdir and the runtime linker doesn't
look where needed without /etc/ld.so.cache (e.g. if libstdc++ is
in a GCC per-version subdirectory handled via /etc/ld.so.conf.d/).
If /etc/ld.so.cache is not available, the runtime linker will look
only at a set of predetermined paths - as seen with LD_DEBUG=libs
added to the bwrap call with "--setenv LD_DEBUG libs":
find library=libstdc++.so.6 [0]; searching
search cache=/etc/ld.so.cache
search path=/lib64:/usr/lib64 (system search path)
trying file=/lib64/libstdc++.so.6
trying file=/usr/lib64/libstdc++.so.6
followed by:
/usr/bin/totem-video-thumbnailer: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory
If /etc/ld.so.cache is available, it will use that for the paths:
find library=libstdc++.so.6 [0]; searching
search cache=/etc/ld.so.cache
trying file=/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/libstdc++.so.6
By bind mounting just that file out of /etc, we get it to work on
such a system.
Closes: #81
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_file_info_get_attribute_object() is transfer none, so when getting a
preview GIcon from a gvfs-backed file that supports it, we need to
reference the preview otherwise we might crash.
==19044== Invalid read of size 8
==19044== at 0x48607E7: get_preview_thumbnail (gnome-desktop-thumbnail.c:978)
==19044== by 0x48607E7: gnome_desktop_thumbnail_factory_generate_thumbnail (gnome-desktop-thumbnail.c:1058)
==19044== by 0x401181: main (test-desktop-thumbnail.c:51)
==19044== Address 0x700f750 is 0 bytes inside a block of size 40 free'd
==19044== at 0x4839A0C: free (vg_replace_malloc.c:530)
==19044== by 0x48DFCD0: g_type_free_instance (gtype.c:1943)
==19044== by 0x4E7F7B5: _g_file_attribute_value_clear (gfileattribute.c:176)
==19044== by 0x4E83D46: g_file_info_finalize (gfileinfo.c:327)
==19044== by 0x48C1C61: g_object_unref (gobject.c:3346)
==19044== by 0x48607D5: get_preview_thumbnail (gnome-desktop-thumbnail.c:974)
==19044== by 0x48607D5: gnome_desktop_thumbnail_factory_generate_thumbnail (gnome-desktop-thumbnail.c:1058)
==19044== by 0x401181: main (test-desktop-thumbnail.c:51)
==19044== Block was alloc'd at
==19044== at 0x483880B: malloc (vg_replace_malloc.c:299)
==19044== by 0x4B54F20: g_malloc (gmem.c:99)
==19044== by 0x4B6C3C2: g_slice_alloc (gslice.c:1024)
==19044== by 0x4B6C9F8: g_slice_alloc0 (gslice.c:1050)
==19044== by 0x48DFA33: g_type_create_instance (gtype.c:1846)
==19044== by 0x48C2397: g_object_new_internal (gobject.c:1805)
==19044== by 0x48C4113: g_object_new_valist (gobject.c:2128)
==19044== by 0x48C443B: g_object_new (gobject.c:1648)
==19044== by 0x7451CF7: g_vfs_icon_new (gvfsicon.c:178)
==19044== by 0x7451D47: g_vfs_icon_from_tokens (gvfsicon.c:268)
==19044== by 0x4E8BA45: g_icon_new_from_tokens (gicon.c:381)
==19044== by 0x4E8BA45: g_icon_new_for_string (gicon.c:462)
==19044== by 0x7450C5F: _g_dbus_get_file_attribute (gvfsdaemonprotocol.c:300)
==19044== by 0x7450D26: _g_dbus_get_file_info (gvfsdaemonprotocol.c:340)
==19044== by 0x867A74C: g_daemon_file_query_info (gdaemonfile.c:830)
==19044== by 0x486078D: get_preview_thumbnail (gnome-desktop-thumbnail.c:960)
==19044== by 0x486078D: gnome_desktop_thumbnail_factory_generate_thumbnail (gnome-desktop-thumbnail.c:1058)
==19044== by 0x401181: main (test-desktop-thumbnail.c:51)
==19044==
==19044== Invalid read of size 8
==19044== at 0x48607F0: get_preview_thumbnail (gnome-desktop-thumbnail.c:978)
==19044== by 0x48607F0: gnome_desktop_thumbnail_factory_generate_thumbnail (gnome-desktop-thumbnail.c:1058)
==19044== by 0x401181: main (test-desktop-thumbnail.c:51)
==19044== Address 0xaaaaaaaaaaaaaaaa is not stack'd, malloc'd or (recently) free'd
Root-caused by "Just Me"
Closes: #87
|
|
|
|
| |
Closes: #82
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On systems where /usr-merge hasn't been carried out, /bin (etc) won't
point to /usr/bin. In that case we should --ro-bind the directory
instead of --symlinking it.
This implements the suggestion from Simon McVittie on
https://bugzilla.gnome.org/show_bug.cgi?id=787072.
It also handles source directories not existing, which for example
/lib64 won't on 32-bit systems.
Closes: #4
Closes: #89
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to handle the clock's various display setting correctly for
different locales, we mark strftime format strings for translation.
However those translations are looked up according to the locale
defined by LC_MESSAGES, while the conversion characters themselves
are resolved according to LC_TIME, with rather odd results when
mixing locales.
The correct solution would be to install translations for format
strings in the LC_TIME catalogue and look them up with dcgettext(),
but we don't have the infrastructure to do that easily. Work around
this by adding a helper method that looks up a string in LC_MESSAGES
using the locale defined by LC_TIME and use that to translate the
format strings, which has the same result.
https://bugzilla.gnome.org/show_bug.cgi?id=789205
|
|
|
|
|
|
| |
Also, update the totally-incorrect comment above the libversion string.
Clearly this isn't libtool versioning as the numbers we use here will be
literally used for the installed library.
|
|
|
|
|
|
| |
This reverts commit 7c46216f3e961abe799d8c99812728039c2049c0.
Just kidding!
|
|
|
|
| |
I want to edit the settings for this repo....
|
|
|
|
| |
(cherry picked from commit 3bdbeb3ccd42420d083fac9b24959ffbd5cb8534)
|
|
|
|
| |
(cherry picked from commit 8f220c26d0cb6f8264000b37bb5a6dd718c34efb)
|
|\ |
|
| | |
|
|/ |
|
|
|
|
| |
(cherry picked from commit 478d19738b831ec489434748efd2d12956ff20f5)
|
| |
|
|
|
|
| |
(cherry picked from commit a42b80e1be57baf1acfde4d73f60fdc3c21cd45e)
|
|
|
|
| |
Thanks for your previous contributions, Colin.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using `#ifdef` in your code (vs `#if`), the C preprocessor doesn't
check the value of the macro, only whether it is defined at all.
By using `conf.set10()`, the macros were defined, whether the
boolean values in the meson build file were false or not. So, to fix
this, you either have to start using `#if`, or you make sure you use
`conf.set()` instead.
This fixes the flatpak build of GNOME Contacts (which turns off udev
support).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With Meson, using the `soversion` argument of a library() target means
setting the explicit soname, e.g.:
soversion: 17.0.2
will be used to generate:
libgnome-desktop-3.so.17.0.2
Unlike libtool, though, Meson will not generate the symbolic links for
the first component of the soversion:
libgnome-desktop-3.so.17
Which is what the dynamic linker will actually use to resolve the
library dependency at link time.
In order to get a symbolic link, we need to use the `version` field for
the soname, and the `soversion` field for the first component:
version: '17.0.2'
soversion: '17'
To avoid having to manually set two fields, we can generate the
`soversion` value from the `version` one, so that they will always be in
sync.
This fixes the build of gnome-shell on Continuous, which has been
failing since gnome-desktop has been moved to Meson with the error:
ld: warning: libgnome-desktop-3.so.17, needed by /usr/lib/libmutter-3.so,
not found (try using -rpath or -rpath-link)
Signed-off-by: Emmanuele Bassi <ebassi@gnome.org>
|
|
|
|
|
|
| |
It's meson all the way now ...
https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/7
|
|
|
|
|
|
| |
It is faster and it needs the extra testing.
https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/7
|
|
|
|
|
|
|
| |
This allows running them through regular `make check`/`ninja test`
instead of requiring `gnome-desktop-testing-runner`...
https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/7
|
|
|
|
|
|
| |
Yay, one more module off the list!
https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/7
|
|
|
|
|
|
|
| |
This is what meson's gnome.yelp() function prefers, and we can make
it work with autotools as well ...
https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/7
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The wall-clock weekday test assumes that only the time is shown when
the weekday setting is disabled. This is only true while the clock
doesn't include the date by default, which is may happen as proposed
in gsettings-desktop-schemas!2. But even if the default isn't changed
it is still safer to spell out the assumptions, so explicitly disable
the date.
https://gitlab.gnome.org/GNOME/gnome-desktop/merge_requests/18
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|