From ea47b53b8453f8b5e0ab87d5f6f11fc314bba49d Mon Sep 17 00:00:00 2001 From: Michael Catanzaro Date: Wed, 24 Feb 2021 11:32:07 -0600 Subject: session: return earlier if no page has been loaded There is no need to bother creating the SaveData object in this case. --- src/ephy-session.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ephy-session.c b/src/ephy-session.c index b106e0b4e..5dda793ba 100644 --- a/src/ephy-session.c +++ b/src/ephy-session.c @@ -997,6 +997,9 @@ ephy_session_save_timeout_cb (EphySession *session) session->save_source_id = 0; + if (!session->loaded_page) + return G_SOURCE_REMOVE; + /* If we have never successfully loaded any page, or any web view has an * insane URL, then something has probably gone wrong inside WebKit. For * instance, if the web process is nonfunctional, the UI process could have @@ -1005,7 +1008,7 @@ ephy_session_save_timeout_cb (EphySession *session) * file with our new bogus state. Bug #768250. */ data = save_data_new (session); - if (!session->loaded_page || !session_seems_reasonable (data->windows)) { + if (!session_seems_reasonable (data->windows)) { save_data_free (data); return G_SOURCE_REMOVE; } -- cgit v1.2.1