From 6666530fa0afee89371413ffaa59a2a81eba2b8d Mon Sep 17 00:00:00 2001 From: Michael Catanzaro Date: Fri, 28 Oct 2016 06:04:49 -0500 Subject: history-service: Initialize tables even in read-only mode The history service just is not built to handle the case where no history tables exist. We either need to upgrade every error path in this directory to not call g_warning in read-only mode, or just create the tables. Creating tables is harmless; we just don't want to insert history into them. --- lib/history/ephy-history-service.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/history/ephy-history-service.c b/lib/history/ephy-history-service.c index 276f2640c..e90239f9b 100644 --- a/lib/history/ephy-history-service.c +++ b/lib/history/ephy-history-service.c @@ -383,9 +383,6 @@ ephy_history_service_open_database_connections (EphyHistoryService *self) ephy_history_service_enable_foreign_keys (self); - if (self->read_only) - return TRUE; - ephy_sqlite_connection_begin_transaction (self->history_database, &error); if (error) { g_warning ("Could not begin long running transaction in history database: %s", error->message); -- cgit v1.2.1